mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-09-11 05:34:30 +00:00
byrongamatosandClaude Sonnet 4.6
06e4fe335a
Resolve all 160 undeclared names that were latent ReferenceErrors in the
ES-module-scoped renderer.js. Module scope never chains into screen.js's
IIFE scope; every name was a crash on first execution path.
Changes:
- renderer.js: move 44 private names into createRenderer closure (Category E
no-screen-use); DI 13 shared mutable names as getter/setter pairs; DI 43
Category-B consts, 37 Category-C fn-refs, 3 Category-D getters (ren/scene/cam),
11 Category-F stable refs + getter/setter, 5 Category-G lane-material getters;
2 extra getters for chordFrameGradTex/Arp.
- score-fx.js: add fxClearSeen() to exports so renderer can clear _fxSeen
without a direct reference.
- screen.js: remove 44 declarations moved to closure; wire all 129 new DI
params in createRenderer call; destructure fxClearSeen from createScoreFx.
- tests: update DI count pin 184→313; fix 4 test regexes for new API surface;
add 3 actual execution smoke tests (new Function pattern, no-ReferenceError
assertion, documents first crash at d475899).
ESLint no-undef: 0 errors on renderer.js.
Suite: 1405/1406 (test 46 pre-existing, unchanged since cut-8).
DI count: 313 (getters=105, setters=48, shorthands=160).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014uZ169yfoFYArXz962g7KW
67 lines
3.3 KiB
JavaScript
67 lines
3.3 KiB
JavaScript
// Pins slide-target gem suppression in plugins/highway_3d/screen.js (PR #329).
|
|
// A note that is the slide/link destination of a preceding sustained note has
|
|
// its gem body suppressed (skipBody=true) so it does not render a duplicate
|
|
// gem on top of the slide trail — but the sustain/slide trail itself still
|
|
// renders so the slide motion stays visible. A refactor that drops the
|
|
// _slideTargetSet pre-pass, stops threading _isSlideTgt into drawNote, or
|
|
// moves the trail back inside the !skipBody gate would silently reintroduce
|
|
// duplicate gems or erase slide trails.
|
|
//
|
|
// Source-level only — same strategy as the other tests/js/ files.
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
const SCREEN_JS = path.join(__dirname, '..', '..', 'plugins', 'highway_3d', 'screen.js');
|
|
// h3d-carve-14: V-section moved to note-renderer.js
|
|
const NOTE_RENDERER_JS = path.join(__dirname, '..', '..', 'plugins', 'highway_3d', 'src', 'note-renderer.js');
|
|
const RENDERER_JS = path.join(__dirname, '..', '..', 'plugins', 'highway_3d', 'src', 'renderer.js');
|
|
const _noteSrc = fs.readFileSync(NOTE_RENDERER_JS, 'utf8');
|
|
|
|
test('a _slideTargetSet pre-pass builds the suppressed-gem set from bundle.notes', () => {
|
|
const src = fs.readFileSync(SCREEN_JS, 'utf8') + '\n' + _noteSrc + '\n' + fs.readFileSync(RENDERER_JS, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/const\s+checkSrc\s*=\s*\([^)]*\)\s*=>\s*\{[\s\S]*?stSet\.add\(/,
|
|
'pre-pass checkSrc must populate the slide-target set',
|
|
);
|
|
assert.match(
|
|
src,
|
|
/if\s*\(\s*stSet\.size\s*>\s*0\s*\)\s*(?:_slideTargetSet\s*=\s*stSet|setSlideTargetSet\s*\(\s*stSet\s*\))/,
|
|
'_slideTargetSet must be assigned from the pre-pass result',
|
|
);
|
|
});
|
|
|
|
test('_isSlideTgt is derived from _slideTargetSet membership', () => {
|
|
const src = fs.readFileSync(SCREEN_JS, 'utf8') + '\n' + _noteSrc + '\n' + fs.readFileSync(RENDERER_JS, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/_isSlideTgt\s*=\s*!!\(\s*(?:_slideTargetSet|getSlideTargetSet\(\))\s*&&\s*(?:_slideTargetSet|getSlideTargetSet\(\))\.has\(/,
|
|
'_isSlideTgt must test _slideTargetSet membership',
|
|
);
|
|
});
|
|
|
|
test('_isSlideTgt is threaded into drawNote as the skipBody argument', () => {
|
|
// drawNote(n, now, openX, skipLabel, skipBody, ...) — _isSlideTgt sits in
|
|
// the 5th (skipBody) position so the gem body is suppressed.
|
|
const src = fs.readFileSync(SCREEN_JS, 'utf8') + '\n' + _noteSrc + '\n' + fs.readFileSync(RENDERER_JS, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/drawNote\(\s*n\s*,\s*now\s*,\s*singleOpenX\s*,\s*skipLabel\s*,\s*_isSlideTgt\s*,/,
|
|
'_isSlideTgt must be passed as drawNote\'s skipBody argument',
|
|
);
|
|
});
|
|
|
|
test('the sustain trail renders for all notes, including skipBody slide targets', () => {
|
|
// The trail block must stay outside the !skipBody gem gate so suppressed
|
|
// slide-target gems still show their slide trail.
|
|
const src = fs.readFileSync(SCREEN_JS, 'utf8') + '\n' + _noteSrc + '\n' + fs.readFileSync(RENDERER_JS, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/Rendered for ALL notes with sustain, including skipBody=true/,
|
|
'the sustain-trail comment contract must remain, marking the trail as unconditional',
|
|
);
|
|
});
|