mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-22 12:52:29 +00:00
09f7e450a5
static/js/format.js (17). One function. Retires the formatTime hook: 12 -> 11. WHY A MODULE FOR ONE FUNCTION. formatTime was a host hook — loops.js and section-practice.js both reached back through the seam for it. It is ALSO, by pure accident of who calls it, inside the dependency closure of the library carve that comes next. Leaving it there would have made loops.js and section-practice.js import the LIBRARY in order to format a timestamp — nonsense, and a cycle waiting to happen. Same rule as the transport carve: a hook is a cycle you agreed to live with; an import is a dependency you actually have. formatTime has a real owner. It just isn't app.js, and it certainly isn't the library. Give it a home and both consumers import it directly. A leaf on purpose. Anything else that turns out to be a shared pure formatter belongs here too; nothing does yet (I checked — formatBadge, _safeImageUrl and _fetchJsonOrThrow have no callers outside the library), so nothing else is here. node 1040/1040, host contract 2/2, ESLint 0. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
18 lines
973 B
JavaScript
18 lines
973 B
JavaScript
// Display formatters. A LEAF module: imports nothing.
|
|
//
|
|
// WHY THIS EXISTS FOR ONE FUNCTION. formatTime was a HOST HOOK — loops.js and
|
|
// section-practice.js both reached back through the seam for it. It was also, by pure
|
|
// accident of who calls it, inside the dependency closure of the library carve. Leaving
|
|
// it there would have made loops.js and section-practice.js import the LIBRARY to format
|
|
// a timestamp, which is nonsense, and a cycle waiting to happen.
|
|
//
|
|
// A hook is a cycle you agreed to live with. This one has a real owner — it just isn't
|
|
// app.js, and it certainly isn't the library. Give it a home of its own and both
|
|
// consumers import it directly.
|
|
//
|
|
// It is a leaf on purpose. Anything else that turns out to be a shared pure formatter
|
|
// belongs here too; nothing does yet, so nothing else is here.
|
|
|
|
/** Seconds -> `M:SS`. */
|
|
export function formatTime(s) { return `${Math.floor(s / 60)}:${String(Math.floor(s % 60)).padStart(2, '0')}`; }
|