feedBack/tests/test_diagnostics_hardware.py
Bret Mogilefsky af2949677a
rename: slopsmith → feedBack, byron → got-feedBack (#537)
* Update GitHub repo references from feedback* to feedBack*

* rename: slopsmith -> feedBack, byron -> got-feedBack

Renames across the entire codebase:
- slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack
- byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack
- /home/byron/ -> /opt/got-feedBack/
- byron@ougsoft.com -> hi@got-feedBack.org
- github.com/byrongamatos/ -> github.com/got-feedback/
- com.byron. -> com.got-feedback.
- SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback
- Protocol/storage strings migrated with read-old/write-new pattern
- window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias

Refs: #rename-slopsmith

* rename: complete regen against current main + fix backward-compat alias

Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of
current main (3 commits had landed since the branch: #572/#554/#574),
resolving the four content conflicts in favour of main's newer content
(autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge).

Completion fixes on top of the mechanical rename:
- Re-apply rename to post-branch content the original rename never saw:
  window.slopsmith(.Tour) consumers in lessons.js / notifications.js /
  onboarding-tour.js, and the matching JS + python tests (autoplay_exit,
  progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env
  vars now match server.py (which reads FEEDBACK_SYNC_STARTUP /
  FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real
  path again.
- Restore the window.slopsmith backward-compat alias dropped during conflict
  resolution, and move the bus aliases to AFTER the _feedBackExisting merge
  block so they reference the fully-assembled object (also fixes the
  loop_api.test.js API-surface regex, which the original PR latently broke).
- Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR)
  and gitignore it.
- Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped
  source labels.

Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669
passed / 1683 collected with 0 import errors; zero residual slopsmith/byron
except the two intentional window.slopsmith aliases.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* rename: implement advertised backward-compat + prune dead community plugins

Address gaps where PR #537's "Backward compatibility" section was advertised
but not implemented, and clean up the community plugin list.

Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured):
- New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py
  (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and
  tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI /
  SLOPSMITH_PLUGINS_DIR / etc. deployments keep working.
- Fix the rename collapsing plugins/__init__.py and minigames/routes.py from
  `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant
  `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost).

Storage (app.js update-channel):
- Read feedBack-update-channel, fall back to legacy slopsmith-update-channel,
  and clear the legacy key on write — so a user's update-channel preference
  survives the rename instead of resetting to "stable".

Community plugin list (README): the rename rewrote third-party repo URLs we
don't own. Probed every one; their owners never renamed, so:
- Restore the 13 live community plugins to their real slopsmith-* names.
- Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex
  tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle).
- Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory).

Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors,
rename-sensitive + startup suites green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: byrongamatos <xasiklas@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 11:03:01 +02:00

83 lines
2.7 KiB
Python

import json
from unittest import mock
import diagnostics_hardware as dh
def test_collect_has_required_top_level_keys():
result = dh.collect()
assert result["schema"] == "system.hardware.v1"
for key in ("runtime", "os", "cpu", "memory", "gpu", "notes"):
assert key in result
def test_runtime_detect_env_override(monkeypatch):
monkeypatch.setenv("FEEDBACK_RUNTIME", "electron")
monkeypatch.delenv("KUBERNETES_SERVICE_HOST", raising=False)
out = dh.detect_runtime()
assert out["kind"] == "electron"
def test_runtime_detect_kubernetes(monkeypatch):
monkeypatch.delenv("FEEDBACK_RUNTIME", raising=False)
monkeypatch.setenv("KUBERNETES_SERVICE_HOST", "10.0.0.1")
out = dh.detect_runtime()
assert out["in_kubernetes"] is True
def test_safe_run_missing_binary_returns_127():
rc, stdout, stderr = dh._safe_run(["this-binary-does-not-exist-xyz123"])
assert rc == 127
assert stdout == ""
def test_gpu_probe_nvidia_parses_csv():
fake_out = "NVIDIA GeForce RTX 4070, 550.54.14, 12282\n"
with mock.patch.object(dh, "_safe_run", return_value=(0, fake_out, "")):
gpus = dh._probe_gpu_nvidia()
assert len(gpus) == 1
assert gpus[0]["name"] == "NVIDIA GeForce RTX 4070"
assert gpus[0]["driver"] == "550.54.14"
assert gpus[0]["memory_total_mb"] == 12282
assert gpus[0]["source"] == "nvidia-smi"
def test_gpu_probe_nvidia_absent_returns_empty():
with mock.patch.object(dh, "_safe_run", return_value=(127, "", "")):
assert dh._probe_gpu_nvidia() == []
def test_collect_with_no_gpus_records_note():
with mock.patch.object(dh, "_probe_gpus", return_value=[]):
# _probe_gpus internally appends; mock it to also append via spec
result = dh.collect()
assert "notes" in result
def test_collect_returns_runtime_kind():
result = dh.collect()
assert result["runtime"]["kind"] in ("docker", "electron", "bare")
def test_gpu_probe_rocm_parses_product_and_driver():
fake_out = json.dumps({
"card0": {
"Card series": "AMD Radeon RX 7900 XTX",
"Driver version": "6.2.4",
}
})
with mock.patch.object(dh, "_safe_run", return_value=(0, fake_out, "")):
gpus = dh._probe_gpu_rocm()
assert len(gpus) == 1
assert gpus[0]["name"] == "AMD Radeon RX 7900 XTX"
assert gpus[0]["driver"] == "6.2.4"
assert gpus[0]["source"] == "rocm-smi"
def test_gpu_probe_rocm_absent_driver_omits_field():
fake_out = json.dumps({"card0": {"Card series": "AMD Radeon RX 6800"}})
with mock.patch.object(dh, "_safe_run", return_value=(0, fake_out, "")):
gpus = dh._probe_gpu_rocm()
assert gpus[0]["name"] == "AMD Radeon RX 6800"
assert "driver" not in gpus[0]