mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-21 12:21:49 +00:00
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
116 lines
5.0 KiB
JavaScript
116 lines
5.0 KiB
JavaScript
// Contract tests for progression-core's _diff(): the quest-progressed /
|
|
// path-progressed "advance" events that feed the achievement toasts, plus the
|
|
// guards that keep a completion / level-up from also firing a progress event.
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const vm = require('node:vm');
|
|
const { ROOT } = require('./capabilities_test_harness');
|
|
|
|
const SRC = fs.readFileSync(path.join(ROOT, 'static', 'v3', 'progression-core.js'), 'utf8');
|
|
|
|
// Load progression-core.js in a sandbox whose fetch returns `states` in order.
|
|
// Boot consumes states[0] (prev=null → no diff); each later refresh() diffs
|
|
// against the previous state.
|
|
function load(states) {
|
|
const events = [];
|
|
let i = 0;
|
|
const sandbox = {
|
|
console,
|
|
setTimeout, clearTimeout,
|
|
fetch: async () => ({ ok: true, json: async () => states[Math.min(i++, states.length - 1)] }),
|
|
};
|
|
sandbox.window = sandbox;
|
|
sandbox.window.feedBack = { emit: (name, detail) => events.push({ name, detail }) };
|
|
sandbox.document = { readyState: 'complete', addEventListener: () => {} };
|
|
vm.createContext(sandbox);
|
|
vm.runInContext(SRC, sandbox);
|
|
return { sandbox, events };
|
|
}
|
|
|
|
const stateA = {
|
|
mastery_rank: 2,
|
|
wallet: { balance: 100 },
|
|
quests: {
|
|
daily: { quests: [
|
|
{ id: 'q1', title: 'Play 3 songs', count: 1, target: 3, completed: false, reward_db: 50 },
|
|
{ id: 'q2', title: 'Finish one', count: 0, target: 1, completed: false, reward_db: 20 },
|
|
] },
|
|
weekly: { quests: [
|
|
{ id: 'w1', title: 'Weekly grind', count: 2, target: 10, completed: false, reward_db: 200 },
|
|
] },
|
|
},
|
|
paths: [
|
|
{ id: 'guitar', name: 'Guitar', level: 1, max_level: 10, next: { level: 2, required: 3, completed: 1 } },
|
|
{ id: 'bass', name: 'Bass', level: 0, max_level: 10, next: { level: 1, required: 2, completed: 0 } },
|
|
],
|
|
};
|
|
|
|
const stateB = {
|
|
mastery_rank: 3, // rank up
|
|
wallet: { balance: 170 }, // dB changed
|
|
quests: {
|
|
daily: { quests: [
|
|
{ id: 'q1', title: 'Play 3 songs', count: 2, target: 3, completed: false, reward_db: 50 }, // advanced
|
|
{ id: 'q2', title: 'Finish one', count: 1, target: 1, completed: true, reward_db: 20 }, // COMPLETED
|
|
] },
|
|
weekly: { quests: [
|
|
{ id: 'w1', title: 'Weekly grind', count: 3, target: 10, completed: false, reward_db: 200 }, // advanced
|
|
] },
|
|
},
|
|
paths: [
|
|
{ id: 'guitar', name: 'Guitar', level: 1, max_level: 10, next: { level: 2, required: 3, completed: 2 } }, // progressed
|
|
{ id: 'bass', name: 'Bass', level: 1, max_level: 10, next: { level: 2, required: 3, completed: 0 } }, // LEVELED UP
|
|
],
|
|
};
|
|
|
|
async function diffEvents() {
|
|
const { sandbox, events } = load([stateA, stateB]);
|
|
await sandbox.window.v3Progression.refresh(); // coalesces with boot → state = A
|
|
events.length = 0; // drop boot's progression:updated
|
|
await sandbox.window.v3Progression.refresh(); // state = B → _diff(A, B)
|
|
return events.filter((e) => e.name !== 'progression:updated');
|
|
}
|
|
|
|
test('quest advance emits quest-progressed with period_type, completion does not', async () => {
|
|
const ev = await diffEvents();
|
|
const progressed = ev.filter((e) => e.name === 'progression:quest-progressed');
|
|
const ids = progressed.map((e) => e.detail.id).sort();
|
|
assert.deepEqual(ids, ['q1', 'w1']); // q2 completed → not a progress event
|
|
const q1 = progressed.find((e) => e.detail.id === 'q1').detail;
|
|
assert.equal(q1.period_type, 'daily');
|
|
assert.equal(q1.count, 2);
|
|
assert.equal(q1.target, 3);
|
|
const w1 = progressed.find((e) => e.detail.id === 'w1').detail;
|
|
assert.equal(w1.period_type, 'weekly');
|
|
});
|
|
|
|
test('path challenge progress emits path-progressed; a level-up does not', async () => {
|
|
const ev = await diffEvents();
|
|
const progressed = ev.filter((e) => e.name === 'progression:path-progressed');
|
|
assert.equal(progressed.length, 1);
|
|
const g = progressed[0].detail;
|
|
assert.equal(g.id, 'guitar');
|
|
assert.equal(g.name, 'Guitar');
|
|
assert.equal(g.completed, 2);
|
|
assert.equal(g.required, 3);
|
|
assert.equal(g.next_level, 2);
|
|
// bass leveled up (level 0 → 1) → handled by path-level-up, not path-progressed.
|
|
assert.ok(!progressed.some((e) => e.detail.id === 'bass'));
|
|
});
|
|
|
|
test('rank-up and dB change still emit their events', async () => {
|
|
const ev = await diffEvents();
|
|
const rank = ev.find((e) => e.name === 'progression:rank-changed');
|
|
assert.ok(rank && rank.detail.from === 2 && rank.detail.to === 3);
|
|
assert.ok(ev.some((e) => e.name === 'progression:db-changed'));
|
|
});
|
|
|
|
test('no progress events fire on the very first state (prev=null)', async () => {
|
|
const { sandbox, events } = load([stateA]);
|
|
await sandbox.window.v3Progression.refresh();
|
|
assert.ok(!events.some((e) => /progressed|changed/.test(e.name)));
|
|
});
|