mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-21 12:21:49 +00:00
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
242 lines
8.5 KiB
JavaScript
242 lines
8.5 KiB
JavaScript
// Lightweight contract tests for v3 Progress calibration retry/success modals.
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const vm = require('node:vm');
|
|
const { ROOT } = require('./capabilities_test_harness');
|
|
|
|
const PROGRESS_JS = path.join(ROOT, 'static', 'v3', 'progress.js');
|
|
|
|
function createProgressWindow(progressionState) {
|
|
class CustomEvent {
|
|
constructor(type, init = {}) {
|
|
this.type = type;
|
|
this.detail = init.detail;
|
|
}
|
|
}
|
|
|
|
const listeners = new Map();
|
|
const byId = new Map();
|
|
|
|
function wireElement(el) {
|
|
if (el.id) byId.set(el.id, el);
|
|
el.querySelector = (sel) => {
|
|
const m = sel.match(/^\[data-([^\]]+)\]$/);
|
|
if (!m) return null;
|
|
const attr = `data-${m[1]}`;
|
|
const walk = (node) => {
|
|
if (node.getAttribute && node.getAttribute(attr) != null) return node;
|
|
for (const child of (node.children || [])) {
|
|
const hit = walk(child);
|
|
if (hit) return hit;
|
|
}
|
|
return null;
|
|
};
|
|
return walk(el);
|
|
};
|
|
el.querySelectorAll = (sel) => {
|
|
const one = el.querySelector(sel);
|
|
return one ? [one] : [];
|
|
};
|
|
el.addEventListener = (type, handler) => {
|
|
const list = el.__handlers || (el.__handlers = {});
|
|
(list[type] || (list[type] = [])).push(handler);
|
|
};
|
|
el.remove = () => {
|
|
if (el.id) byId.delete(el.id);
|
|
const idx = bodyChildren.indexOf(el);
|
|
if (idx !== -1) bodyChildren.splice(idx, 1);
|
|
};
|
|
return el;
|
|
}
|
|
|
|
const bodyChildren = [];
|
|
const body = wireElement({
|
|
id: '',
|
|
tagName: 'BODY',
|
|
children: bodyChildren,
|
|
appendChild(child) {
|
|
wireElement(child);
|
|
bodyChildren.push(child);
|
|
child.parentNode = body;
|
|
return child;
|
|
},
|
|
});
|
|
|
|
const window = {
|
|
console,
|
|
CustomEvent,
|
|
setTimeout,
|
|
clearTimeout,
|
|
performance: { now: () => Date.now() },
|
|
document: {
|
|
readyState: 'complete',
|
|
body,
|
|
getElementById(id) { return byId.get(id) || null; },
|
|
createElement(tag) {
|
|
const el = {
|
|
id: '',
|
|
tagName: String(tag || '').toUpperCase(),
|
|
children: [],
|
|
_html: '',
|
|
className: '',
|
|
};
|
|
Object.defineProperty(el, 'innerHTML', {
|
|
get() { return el._html; },
|
|
set(html) {
|
|
el._html = html;
|
|
el.children.length = 0;
|
|
const btnRe = /<button[^>]*data-([^=\s]+)[^>]*>/g;
|
|
let m;
|
|
while ((m = btnRe.exec(html))) {
|
|
const attr = m[1];
|
|
const btn = wireElement({
|
|
tagName: 'BUTTON',
|
|
getAttribute(name) {
|
|
if (name === `data-${attr}`) return '';
|
|
return null;
|
|
},
|
|
addEventListener(type, handler) {
|
|
const list = this.__handlers || (this.__handlers = {});
|
|
(list[type] || (list[type] = [])).push(handler);
|
|
},
|
|
click() {
|
|
for (const h of (this.__handlers || {}).click || []) h();
|
|
},
|
|
disabled: false,
|
|
});
|
|
el.children.push(btn);
|
|
}
|
|
},
|
|
appendChild(child) {
|
|
wireElement(child);
|
|
el.children.push(child);
|
|
return child;
|
|
},
|
|
});
|
|
return wireElement(el);
|
|
},
|
|
addEventListener(type, handler) {
|
|
const list = listeners.get(type) || [];
|
|
list.push(handler);
|
|
listeners.set(type, list);
|
|
},
|
|
},
|
|
v3Progression: {
|
|
get() { return progressionState; },
|
|
refresh() { return Promise.resolve(progressionState); },
|
|
},
|
|
playSong() {},
|
|
feedBack: {
|
|
on(type, handler) {
|
|
const list = listeners.get(type) || [];
|
|
list.push(handler);
|
|
listeners.set(type, list);
|
|
},
|
|
emit(type, detail) {
|
|
for (const handler of (listeners.get(type) || []).slice()) {
|
|
handler({ detail });
|
|
}
|
|
},
|
|
},
|
|
showScreen() {},
|
|
__listeners: listeners,
|
|
__byId: byId,
|
|
__bodyChildren: bodyChildren,
|
|
};
|
|
window.window = window;
|
|
window.globalThis = window;
|
|
|
|
const progressRoot = window.document.createElement('div');
|
|
progressRoot.id = 'v3-progress';
|
|
window.document.body.appendChild(progressRoot);
|
|
|
|
const context = vm.createContext(window);
|
|
vm.runInContext(fs.readFileSync(PROGRESS_JS, 'utf8'), context, { filename: PROGRESS_JS });
|
|
return window;
|
|
}
|
|
|
|
test('progression:calibration-attempt with 0.92 shows retry overlay and So close!', () => {
|
|
const win = createProgressWindow({
|
|
mastery_rank: 0,
|
|
onboarding: {
|
|
calibration_status: 'pending',
|
|
diagnostic_filename: 'diagnostics-builtin/feedBack-diagnostic-basic-guitar.sloppak',
|
|
},
|
|
paths: [],
|
|
wallet: { balance: 0, lifetime_db: 0 },
|
|
quests: {},
|
|
});
|
|
|
|
win.feedBack.emit('progression:calibration-attempt', { accuracy: 0.92 });
|
|
|
|
const overlay = win.document.getElementById('v3-calibration-retry');
|
|
assert.ok(overlay, 'retry overlay should exist');
|
|
assert.match(overlay.innerHTML, /So close!/);
|
|
assert.match(overlay.innerHTML, /92%/);
|
|
assert.equal(win.document.getElementById('v3-calibration-success'), null);
|
|
});
|
|
|
|
test('progression:calibration-completed shows success overlay and Setup verified!', () => {
|
|
const win = createProgressWindow({
|
|
mastery_rank: 0,
|
|
onboarding: {
|
|
calibration_status: 'pending',
|
|
diagnostic_filename: 'diagnostics-builtin/feedBack-diagnostic-basic-guitar.sloppak',
|
|
},
|
|
paths: [],
|
|
wallet: { balance: 0, lifetime_db: 0 },
|
|
quests: {},
|
|
});
|
|
|
|
win.feedBack.emit('progression:calibration-completed', {});
|
|
|
|
const overlay = win.document.getElementById('v3-calibration-success');
|
|
assert.ok(overlay, 'success overlay should exist');
|
|
assert.match(overlay.innerHTML, /Setup verified!/);
|
|
assert.match(overlay.innerHTML, /Mastery Rank 1 is ready/);
|
|
assert.equal(win.document.getElementById('v3-calibration-retry'), null);
|
|
});
|
|
|
|
test('success overlay for skipped state does not claim rank-up', () => {
|
|
const win = createProgressWindow({
|
|
mastery_rank: 1,
|
|
onboarding: {
|
|
calibration_status: 'skipped',
|
|
diagnostic_filename: 'diagnostics-builtin/feedBack-diagnostic-basic-guitar.sloppak',
|
|
},
|
|
paths: [],
|
|
wallet: { balance: 0, lifetime_db: 0 },
|
|
quests: {},
|
|
});
|
|
|
|
win.feedBack.emit('progression:calibration-completed', {});
|
|
|
|
const overlay = win.document.getElementById('v3-calibration-success');
|
|
assert.ok(overlay);
|
|
assert.match(overlay.innerHTML, /Your input and note detection setup is verified/);
|
|
assert.doesNotMatch(overlay.innerHTML, /Mastery Rank 1/);
|
|
assert.match(overlay.innerHTML, /Play again/);
|
|
});
|
|
|
|
test('calibration-completed does not stack duplicate success overlays', () => {
|
|
const win = createProgressWindow({
|
|
mastery_rank: 1,
|
|
onboarding: {
|
|
calibration_status: 'skipped',
|
|
diagnostic_filename: 'diagnostics-builtin/feedBack-diagnostic-basic-guitar.sloppak',
|
|
},
|
|
paths: [],
|
|
wallet: { balance: 0, lifetime_db: 0 },
|
|
quests: {},
|
|
});
|
|
|
|
win.feedBack.emit('progression:calibration-completed', {});
|
|
win.feedBack.emit('progression:calibration-completed', {});
|
|
|
|
const overlays = win.__bodyChildren.filter((el) => el.id === 'v3-calibration-success');
|
|
assert.equal(overlays.length, 1);
|
|
});
|