mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-21 12:21:49 +00:00
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
102 lines
5.8 KiB
JavaScript
102 lines
5.8 KiB
JavaScript
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const { loadPlayback, captureEvents, diagnosticsSnapshot, makeTarget, dispatch, makeAdapter, ROOT } = require('./playback_test_harness');
|
|
const { loadCapabilities } = require('./capabilities_test_harness');
|
|
|
|
test('requester and observer registration is idempotent and visible in diagnostics', async () => {
|
|
const window = loadPlayback();
|
|
await dispatch(window, 'register-requester', { requesterId: 'plugin.practice', kind: 'plugin', requests: ['pause'] });
|
|
await dispatch(window, 'register-requester', { requesterId: 'plugin.practice', kind: 'plugin', requests: ['seek'], status: 'available' });
|
|
await dispatch(window, 'register-observer', { observerId: 'plugin.hud', observes: ['ready', 'seeked'] });
|
|
|
|
const participants = diagnosticsSnapshot(window).participants;
|
|
assert.equal(participants.filter(item => item.requesterId === 'plugin.practice').length, 1);
|
|
assert.equal(participants.filter(item => item.observerId === 'plugin.hud').length, 1);
|
|
});
|
|
|
|
test('plugin fresh starts require user action and incompatible playback participants do not execute', async () => {
|
|
const window = loadPlayback();
|
|
const denied = await dispatch(window, 'start', { requesterId: 'plugin.remote', target: makeTarget() });
|
|
assert.equal(denied.status, 'user-action-required');
|
|
|
|
const incompatibleWindow = loadCapabilities();
|
|
const fixture = JSON.parse(fs.readFileSync(path.join(ROOT, 'tests', 'fixtures', 'plugin_capabilities', 'unsupported_capability_version.json'), 'utf8'));
|
|
fixture.id = 'future_playback';
|
|
fixture.capabilities = { playback: { roles: ['owner'], commands: ['inspect'], runtime: true, version: 999, handlers: { inspect: () => ({ outcome: 'handled' }) } } };
|
|
incompatibleWindow.feedBack.capabilities.registerParticipants([fixture]);
|
|
const result = await incompatibleWindow.feedBack.capabilities.dispatch({ capability: 'playback', command: 'inspect', requester: 'test' });
|
|
assert.equal(result.status, 'incompatible-version');
|
|
});
|
|
|
|
test('same-priority latest controls remain non-stale while user-priority commands deny background automation', async () => {
|
|
const window = loadPlayback();
|
|
window.feedBack.playback.registerTransportAdapter(makeAdapter());
|
|
await dispatch(window, 'start', { authorization: 'user-action', requesterId: 'core.player.controls', target: makeTarget() });
|
|
const firstPause = await dispatch(window, 'pause', { requesterId: 'plugin.a', priority: 'normal' });
|
|
const normalResume = await dispatch(window, 'resume', { requesterId: 'plugin.b', priority: 'normal' });
|
|
await dispatch(window, 'pause', { requesterId: 'core.player.controls', priority: 'user' });
|
|
const blockedResume = await dispatch(window, 'resume', { requesterId: 'plugin.b', priority: 'normal' });
|
|
|
|
assert.equal(firstPause.status, 'paused');
|
|
assert.equal(normalResume.status, 'playing');
|
|
assert.equal(blockedResume.status, 'denied');
|
|
});
|
|
|
|
test('legacy bridge hits are attributed to playback compatibility shims', () => {
|
|
const window = loadPlayback();
|
|
const bridgeEvents = captureEvents(window, 'playback:bridge-hit');
|
|
|
|
window.feedBack.playback.recordBridgeHit({
|
|
bridgeId: 'playback.window-play-song',
|
|
legacySurface: 'window.playSong',
|
|
source: 'core.app',
|
|
reason: 'legacy playSong entry point used',
|
|
});
|
|
|
|
const playback = diagnosticsSnapshot(window);
|
|
const runtime = window.feedBack.capabilities.snapshotDiagnostics();
|
|
const shim = runtime.compatibilityShims.find(item => item.capability === 'playback' && item.legacySurface === 'window.playSong');
|
|
|
|
assert.equal(bridgeEvents.length, 1);
|
|
assert.equal(playback.bridges[0].bridgeId, 'playback.window-play-song');
|
|
assert.equal(playback.bridges[0].hitCount, 1);
|
|
assert.ok(shim);
|
|
assert.equal(shim.hitCount, 1);
|
|
});
|
|
|
|
test('legacy song events update playback state without exposing raw filenames', () => {
|
|
const window = loadPlayback();
|
|
window.feedBack.emit('song:loading', { filename: '/Users/example/Secret Folder/Artist - Song_p.archive', arrangement: 0 });
|
|
window.feedBack.emit('song:loaded', makeTarget({ filename: '/Users/example/Secret Folder/Artist - Song_p.archive' }));
|
|
window.feedBack.emit('song:play', { time: 4, audioT: 4, chartT: 4 });
|
|
window.feedBack.emit('song:seek', { from: 4, to: 12, reason: 'seek-by' });
|
|
|
|
const playback = diagnosticsSnapshot(window);
|
|
const encoded = JSON.stringify(playback);
|
|
|
|
assert.equal(playback.state.state, 'playing');
|
|
assert.equal(playback.state.media.currentTime, 12);
|
|
assert.match(playback.state.target.settingsKey, /^settings-v1-[a-z0-9]{7}$/);
|
|
assert.ok(playback.bridges.some(bridge => bridge.bridgeId === 'playback.song-events'));
|
|
assert.doesNotMatch(encoded, /Secret Folder/);
|
|
assert.doesNotMatch(encoded, /Artist - Song_p\.archive/);
|
|
});
|
|
|
|
test('route changes are captured as redaction-safe playback lifecycle events', () => {
|
|
const window = loadPlayback();
|
|
const changing = captureEvents(window, 'playback:route-changing');
|
|
const changed = captureEvents(window, 'playback:route-changed');
|
|
|
|
window.feedBack.playback.recordRouteChange({ routeKind: 'desktop-native', state: 'switching', preservedTime: true, safeReason: 'desktop engine active' });
|
|
window.feedBack.playback.recordRouteChange({ routeKind: 'desktop-native', state: 'active', preservedTime: true, safeReason: 'desktop route active' });
|
|
|
|
const playback = diagnosticsSnapshot(window);
|
|
assert.equal(changing.length, 1);
|
|
assert.equal(changed.length, 1);
|
|
assert.equal(playback.state.route.routeKind, 'desktop-native');
|
|
assert.equal(playback.state.route.state, 'active');
|
|
assert.equal(playback.state.route.preservedTime, true);
|
|
});
|