feedBack/tests/js/pedal_cables.test.js
Bret Mogilefsky af2949677a
rename: slopsmith → feedBack, byron → got-feedBack (#537)
* Update GitHub repo references from feedback* to feedBack*

* rename: slopsmith -> feedBack, byron -> got-feedBack

Renames across the entire codebase:
- slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack
- byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack
- /home/byron/ -> /opt/got-feedBack/
- byron@ougsoft.com -> hi@got-feedBack.org
- github.com/byrongamatos/ -> github.com/got-feedback/
- com.byron. -> com.got-feedback.
- SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback
- Protocol/storage strings migrated with read-old/write-new pattern
- window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias

Refs: #rename-slopsmith

* rename: complete regen against current main + fix backward-compat alias

Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of
current main (3 commits had landed since the branch: #572/#554/#574),
resolving the four content conflicts in favour of main's newer content
(autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge).

Completion fixes on top of the mechanical rename:
- Re-apply rename to post-branch content the original rename never saw:
  window.slopsmith(.Tour) consumers in lessons.js / notifications.js /
  onboarding-tour.js, and the matching JS + python tests (autoplay_exit,
  progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env
  vars now match server.py (which reads FEEDBACK_SYNC_STARTUP /
  FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real
  path again.
- Restore the window.slopsmith backward-compat alias dropped during conflict
  resolution, and move the bus aliases to AFTER the _feedBackExisting merge
  block so they reference the fully-assembled object (also fixes the
  loop_api.test.js API-surface regex, which the original PR latently broke).
- Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR)
  and gitignore it.
- Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped
  source labels.

Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669
passed / 1683 collected with 0 import errors; zero residual slopsmith/byron
except the two intentional window.slopsmith aliases.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* rename: implement advertised backward-compat + prune dead community plugins

Address gaps where PR #537's "Backward compatibility" section was advertised
but not implemented, and clean up the community plugin list.

Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured):
- New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py
  (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and
  tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI /
  SLOPSMITH_PLUGINS_DIR / etc. deployments keep working.
- Fix the rename collapsing plugins/__init__.py and minigames/routes.py from
  `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant
  `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost).

Storage (app.js update-channel):
- Read feedBack-update-channel, fall back to legacy slopsmith-update-channel,
  and clear the legacy key on write — so a user's update-channel preference
  survives the rename instead of resetting to "stable".

Community plugin list (README): the rename rewrote third-party repo URLs we
don't own. Probed every one; their owners never renamed, so:
- Restore the 13 live community plugins to their real slopsmith-* names.
- Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex
  tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle).
- Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory).

Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors,
rename-sensitive + startup suites green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: byrongamatos <xasiklas@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 11:03:01 +02:00

130 lines
5.5 KiB
JavaScript

// Verify the decorative pedalboard patch-cable engine (static/v3/pedal-cables.js):
// pure geometry helpers (jack positions, point seeding, path building, static
// sag), the segment cap, and the prefers-reduced-motion branch — which must
// draw a STATIC sagged path and start NO requestAnimationFrame loop, while the
// normal path DOES start the loop.
const { test } = require('node:test');
// Non-strict assert: helpers return objects created inside the vm realm, whose
// Object.prototype differs from this realm's — strict deepEqual would fail the
// prototype check even when the structure matches.
const assert = require('node:assert');
const fs = require('node:fs');
const path = require('node:path');
const vm = require('node:vm');
const SRC = path.join(__dirname, '..', '..', 'static', 'v3', 'pedal-cables.js');
function rect(l, t, r, b) { return { left: l, top: t, right: r, bottom: b, width: r - l, height: b - t }; }
function loadCables(opts) {
opts = opts || {};
const rafCalls = [];
const created = []; // every createElementNS node
const win = { feedBack: null };
win.addEventListener = () => {};
win.matchMedia = () => ({ matches: !!opts.reduce });
const doc = {
createElementNS: (ns, tag) => {
const node = {
_tag: tag, attrs: {}, children: [],
setAttribute: (k, v) => { node.attrs[k] = v; },
appendChild: (c) => { node.children.push(c); },
insertBefore: (c) => { node.children.unshift(c); },
firstChild: null,
};
created.push(node);
return node;
},
};
const ctx = {
window: win, document: doc, console,
requestAnimationFrame: (cb) => { rafCalls.push(cb); return rafCalls.length; },
cancelAnimationFrame: () => {},
};
vm.createContext(ctx);
vm.runInContext(fs.readFileSync(SRC, 'utf8'), ctx, { filename: 'pedal-cables.js' });
return { api: win.v3PedalCables, t: win.v3PedalCables._test, rafCalls, created };
}
// A fake board containing two pedals; root yields the one board.
function fakeRoot() {
const pedalA = { getBoundingClientRect: () => rect(10, 10, 160, 210) };
const pedalB = { getBoundingClientRect: () => rect(220, 10, 370, 210) };
const board = {
firstChild: null,
scrollWidth: 800, scrollHeight: 420,
getBoundingClientRect: () => rect(0, 0, 800, 420),
setAttribute: () => {},
insertBefore: () => {},
querySelectorAll: (sel) => (sel === '.v3-pedal' ? [pedalA, pedalB] : []),
};
return { querySelectorAll: (sel) => (sel === '.v3-pedalboard' ? [board] : []) };
}
test('computeJacks: out = right side, in = left side, both at vertical centre', () => {
const { t } = loadCables();
const j = t.computeJacks(rect(100, 50, 250, 250), rect(0, 0, 800, 400), 10);
// pedal spans x[100,250] y[50,250]; jack y = top + JACK_FRAC*height to line
// up with the photo's side jacks.
const y = 50 + t.JACK_FRAC * 200;
assert.deepEqual(j.out, { x: 240, y }); // right-10
assert.deepEqual(j.in, { x: 110, y }); // left+10
});
test('seedPoints: N points, endpoints pinned to a and b', () => {
const { t } = loadCables();
const pts = t.seedPoints({ x: 0, y: 0 }, { x: 100, y: 0 }, 12);
assert.equal(pts.length, 12);
assert.deepEqual({ x: pts[0].x, y: pts[0].y }, { x: 0, y: 0 });
assert.deepEqual({ x: pts[11].x, y: pts[11].y }, { x: 100, y: 0 });
});
test('pointsToPath: M then L per subsequent point', () => {
const { t } = loadCables();
const d = t.pointsToPath([{ x: 0, y: 0 }, { x: 5, y: 5 }, { x: 9, y: 1 }]);
assert.ok(d.startsWith('M 0.0 0.0'));
assert.equal((d.match(/L /g) || []).length, 2);
});
test('staticCablePath: quadratic with a downward sag', () => {
const { t } = loadCables();
const d = t.staticCablePath({ x: 0, y: 100 }, { x: 100, y: 100 }, 0.2);
assert.ok(d.startsWith('M 0.0 100.0'));
assert.ok(d.includes('Q '));
// Control-point y is below the endpoints (larger y == lower on screen).
const cy = parseFloat(d.split('Q ')[1].split(' ')[1]);
assert.ok(cy > 100);
});
test('segment cap constants are sane', () => {
const { t } = loadCables();
assert.ok(t.SEGMENTS >= 2 && t.SEGMENTS <= 40);
assert.ok(t.MAX_CABLES >= 1);
});
test('attach draws each cable as a static curve with NO idle rAF loop', () => {
// The cable shape is a pure function of the endpoints (no Verlet/inertia),
// so attach renders once and schedules no continuous animation loop —
// there is nothing to settle, which is what kills the "moon gravity" drift.
const { api, rafCalls, created } = loadCables({ reduce: false });
api.attach(fakeRoot());
assert.equal(rafCalls.length, 0, 'no idle animation loop');
const paths = created.filter((n) => n._tag === 'path');
assert.equal(paths.length, 1, 'one cable between two pedals');
assert.ok((paths[0].attrs.d || '').includes('Q '), 'curved (quadratic) path drawn');
});
test('a drag schedules a short tracking loop; ending it stops the loop', () => {
const { api, rafCalls } = loadCables({ reduce: false });
api.attach(fakeRoot());
api.setDragging(true);
assert.ok(rafCalls.length >= 1, 'drag runs a per-frame tracking loop');
const before = rafCalls.length;
api.setDragging(false);
// Run the already-scheduled frame: with dragging off it renders once and
// does NOT reschedule.
rafCalls[rafCalls.length - 1]();
assert.equal(rafCalls.length, before, 'loop is not rescheduled after drag ends');
});