got-feedBack/feedBack
1
0
Fork 0
mirror of https://github.com/got-feedBack/feedBack.git synced 2026-07-21 12:21:49 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity
main
feedBack/tests/js/capability_inspector_nav.test.js
Byron Gamatos 38772f604a
refactor(app): carve the plugin loader out of app.js into static/js/ (R3a) (#878) 
The first carve, and deliberately the riskiest: app.js IS the plugin loader (the
R0 host rails), so it goes first while the module graph is still one edge deep.

static/js/plugin-loader.js (829 lines) — bodies VERBATIM. app.js 12,217 → 11,439.
Core's first `static/js/` module, exactly as constitution II anticipates.

CLOSURE (measured with acorn, not regex — brace-matching stripped source drifted):
the block at app.js:11246-12031 is contiguous and self-contained. It needs only
TWO things from the rest of app.js, and exports only TWO:
  exports: loadPlugins (the window contract), bootstrapPluginsAndUi (boot)
  inbound: window.showScreen — already the public host contract (constitution II),
           so it is called through `window`, not re-coupled as an import
           _populateVizPicker — injected via configurePluginLoader()

WHY A SEAM, NOT AN IMPORT. plugin-loader must not import app.js: app.js imports
it, so that would close a cycle. I checked whether _populateVizPicker could just
move into the module instead (which would delete the seam entirely) — it drags 9
further symbols (_canRun3D, _autoMatchViz, _showPromotionNag, …), i.e. a whole
viz cluster. That is its own carve, so the seam stays.

THE SEAM'S DEFAULT IS LOUD, ON PURPOSE. A no-op stub is the classic silent
failure for this pattern (see the editor's setHostHooks trap, hit twice): drop the
wiring call and the loader keeps working while the viz picker quietly stops
refreshing — no test, no boot check says a word. The default now console.errors,
so the smoke harness catches it. VERIFIED BY BITE TEST: removing
configurePluginLoader() from app.js surfaces
"[plugin-loader] host seam not configured" at boot. The seam IS exercised on the
plugin-startup path, so an unwired hook cannot pass silently.

no-cycle is now LIVE on core's own graph for the first time. eslint.config.js
gains `static/app.js` + `static/js/**` to the module block — app.js now `import`s,
so parsing it as a script would be a syntax error. VERIFIED BY BITE TEST: making
plugin-loader import app.js back fails with "Dependency cycle detected".

HARNESSES (the R3a note said budget one conversion per carve — it was five):
retargeted capability_inspector_nav, plugin_hydration_wipe,
plugin_loader_script_type, plugin_style_injection, legacy_shim_hits (SPLIT — one
test needs the loader, one still needs app.js) + test_plugin_runtime_idempotence.
legacy_shim_hits was missed by a symbol-name grep because it greps for a code
STRING; only the failing run found it. test_capability_events' NEGATIVE asserts
now span app.js + the loader — carving code out of app.js would otherwise make
them vacuous instead of failing.

VERIFIED: A/B against origin/main in two browsers — mounted plugin screens, 14
loaded plugin scripts, the 3 module plugins injected as <script type="module">,
37 capability participants, 14 shims, window.loadPlugins: IDENTICAL, zero
console/page errors on both. /static/js/plugin-loader.js serves 200; R0 rails
intact (src/main.js 200, conditional GET 304, script_type passthrough).
pytest 2396, node 1032/1032, ESLint 0, Codex 0.

Codex preflight caught a REAL [P1] first pass: static/js/plugin-loader.js was
untracked, so a checkout would have served an app.js importing a nonexistent
module — a failed static import kills the whole module and every window handler
with it. Now tracked.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-11 18:18:00 +02:00

133 lines
7.4 KiB
JavaScript
Raw Permalink Blame History

const { test } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const path = require('node:path');
const ROOT = path.join(__dirname, '..', '..');
const PLUGIN_LOADER_JS = path.join(ROOT, 'static', 'js', 'plugin-loader.js');
const MANIFEST = path.join(ROOT, 'plugins', 'capability_inspector', 'plugin.json');
const SCREEN_HTML = path.join(ROOT, 'plugins', 'capability_inspector', 'screen.html');
const SETTINGS_HTML = path.join(ROOT, 'plugins', 'capability_inspector', 'settings.html');
function source(file) {
return fs.readFileSync(file, 'utf8');
}
function region(src, needle, length = 1800) {
const start = src.indexOf(needle);
assert.ok(start !== -1, `missing source needle: ${needle}`);
return src.slice(start, start + length);
}
test('capability inspector manifest ships settings but no default nav entry', () => {
const manifest = JSON.parse(source(MANIFEST));
assert.equal(manifest.id, 'capability_inspector');
assert.equal(manifest.nav, undefined);
assert.equal(manifest.settings.html, 'settings.html');
});
test('capability inspector plugins menu entry is localStorage opt-in', () => {
const src = source(PLUGIN_LOADER_JS);
const helper = region(src, "const CAPABILITY_INSPECTOR_NAV_SETTING = 'capability_inspector.showInPluginsMenu'", 1400);
const menu = region(src, 'const navPlugins = plugins.map', 1000);
const contributions = region(src, 'async function _registerLegacyPluginUiContributions(plugin)', 1400);
assert.match(helper, /localStorage\.getItem\(CAPABILITY_INSPECTOR_NAV_SETTING\)\s*===\s*['"]1['"]/);
assert.match(helper, /if \(plugin\.id === ['"]capability_inspector['"]\)/);
assert.match(helper, /return null/);
assert.match(helper, /label:\s*['"]Capabilities['"]/);
assert.match(menu, /_pluginNav\(plugin\)/);
assert.match(contributions, /const nav = _pluginNav\(plugin\)/);
assert.doesNotMatch(contributions, /if \(plugin\.nav\)/);
});
test('capability inspector settings toggles the plugins menu setting', () => {
const html = source(SETTINGS_HTML);
assert.match(html, /id="capability-inspector-show-nav"/);
assert.match(html, /capability_inspector\.showInPluginsMenu/);
assert.match(html, /localStorage\.setItem\(key, '1'\)/);
assert.match(html, /localStorage\.removeItem\(key\)/);
assert.match(html, /window\.loadPlugins\(\)/);
assert.match(html, /window\.showScreen\('plugin-capability_inspector'\)/);
});
test('capability inspector screen ships scoped graph lane CSS', () => {
const html = source(SCREEN_HTML);
assert.match(html, /<style>/);
assert.match(html, /\.capability-inspector \[data-domain-graph-fallback\]/);
assert.match(html, /display: flex !important/);
assert.match(html, /\.capability-inspector \[data-domain-provider-card\]/);
assert.match(html, /\.capability-inspector \[data-domain-participant-lane\]/);
assert.match(html, /flex: 0 0 24rem/);
assert.match(html, /\.capability-inspector \[data-domain-graph-cy\]/);
assert.match(html, /display: block !important/);
assert.match(html, /\.capability-inspector \[data-endpoint-icon="command"\]/);
assert.match(html, /background: #fb923c !important/);
assert.match(html, /\.capability-inspector \[data-endpoint-icon="operation"\]/);
assert.match(html, /background: #c084fc !important/);
assert.match(html, /\.capability-inspector \[data-endpoint-flow="provider-operation"\]/);
assert.match(html, /background: #d8b4fe !important/);
assert.match(html, /\.capability-inspector \[data-toggle-graph-group\]/);
assert.match(html, /gap: 0\.625rem !important/);
assert.match(html, /\.capability-inspector \[data-graph-provider-endpoint-row\]/);
assert.match(html, /\.capability-inspector \[data-graph-participant-endpoint-row\]/);
assert.match(html, /\.capability-inspector \[data-role-icon\]/);
assert.match(html, /\.capability-inspector \[data-origin-icon\]/);
assert.match(html, /\.capability-inspector \[data-availability-icon\]/);
assert.match(html, /width: 2\.125rem !important/);
assert.match(html, /margin-left: 0\.5rem !important/);
assert.match(html, /\.capability-inspector \[data-domain-owner-footer\]/);
assert.match(html, /padding-top: 1rem !important/);
assert.match(html, /\.capability-inspector \[data-domain-owner-description\]/);
assert.match(html, /line-height: 1\.45 !important/);
assert.match(html, /\.capability-inspector \[data-domain-graph-filter\]/);
assert.match(html, /background: rgba\(31, 41, 55, 0\.72\) !important/);
assert.match(html, /\.capability-inspector \[data-domain-graph-filter\]\[aria-pressed="true"\]/);
assert.match(html, /background: rgba\(126, 34, 206, 0\.55\) !important/);
assert.match(html, /\.capability-inspector \[data-legend-icon="command"\]/);
assert.match(html, /background: #fb923c !important/);
assert.match(html, /\.capability-inspector \[data-legend-line="shimmed"\]/);
assert.match(html, /border-top: 2px dashed #9ca3af !important/);
assert.match(html, /<div class="max-w-7xl mx-auto px-6 pt-24 pb-16 capability-inspector">/);
assert.match(html, /data-inspector-header/);
assert.match(html, /\.capability-inspector \[data-summary-dashboard\]/);
assert.match(html, /width: 100% !important/);
assert.match(html, /grid-template-columns: repeat\(4, minmax\(0, 1fr\)\) !important/);
assert.match(html, /\.capability-inspector \[data-summary-card\]\[data-tone="clean"\]/);
assert.match(html, /border-color: rgba\(52, 211, 153, 0\.55\) !important/);
assert.match(html, /\.capability-inspector \[data-summary-status-value\]/);
assert.match(html, /color: #34d399 !important/);
assert.match(html, /\.capability-inspector \[data-graph-capability-port\]/);
assert.match(html, /right: -1\.75rem/);
assert.match(html, /\.capability-inspector \[data-graph-participant-port\]/);
assert.match(html, /left: -1\.75rem/);
});
test('_navLabel resolves string, object, synthesized, and empty nav values', () => {
const src = source(PLUGIN_LOADER_JS);
const m = src.match(/function _navLabel\(nav, plugin\) \{[\s\S]*?\n\}/);
assert.ok(m, 'could not extract _navLabel from app.js');
const _navLabel = new Function(`${m[0]}; return _navLabel;`)();
// String nav (manifest "nav": "Declared") must win over the plugin name.
assert.equal(_navLabel('Declared', { name: 'Fallback', id: 'x' }), 'Declared');
// Object nav with a label.
assert.equal(_navLabel({ label: 'Capabilities' }, { name: 'Fallback', id: 'x' }), 'Capabilities');
// Object nav without a label falls back to name then id.
assert.equal(_navLabel({}, { name: 'My Plugin', id: 'x' }), 'My Plugin');
assert.equal(_navLabel({}, { id: 'x' }), 'x');
// Null / whitespace-only nav falls back too.
assert.equal(_navLabel(null, { name: 'My Plugin' }), 'My Plugin');
assert.equal(_navLabel(' ', { name: 'My Plugin' }), 'My Plugin');
});
test('plugin nav dropdown label uses the computed nav, not the raw plugin.nav', () => {
const src = source(PLUGIN_LOADER_JS);
// Regression guard for the string/synthesized-nav label fix: the dropdown
// label must derive from the loop's computed nav via _navLabel, not from
// plugin.nav?.label (which drops string and synthesized labels).
assert.match(src, /const label = _navLabel\(nav, plugin\);/);
assert.doesNotMatch(src, /const label = plugin\.nav\?\.label/);
});
Reference in New Issue View Git Blame Copy Permalink