mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-21 12:21:49 +00:00
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
212 lines
10 KiB
JavaScript
212 lines
10 KiB
JavaScript
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const { loadCapabilities, ROOT } = require('./capabilities_test_harness');
|
|
|
|
const FIXTURE_DIR = path.join(ROOT, 'tests', 'fixtures', 'plugin_capabilities');
|
|
|
|
function fixture(name) {
|
|
return JSON.parse(fs.readFileSync(path.join(FIXTURE_DIR, name), 'utf8'));
|
|
}
|
|
|
|
test('manifest participants are visible before runtime handlers register', () => {
|
|
const window = loadCapabilities();
|
|
const api = window.feedBack.capabilities;
|
|
api.registerParticipants([fixture('valid_owner_provider.json'), fixture('valid_requester_observer.json')]);
|
|
|
|
const stems = api.inspect('stems');
|
|
assert.equal(stems.participants.length, 2);
|
|
const owner = stems.participants.find(p => p.pluginId === 'stems');
|
|
assert.equal(owner.runtime, false);
|
|
assert.equal(JSON.stringify(owner.commands.slice().sort()), JSON.stringify(['inspect', 'mute', 'restore']));
|
|
assert.equal(owner.description, 'Owns stem mute and restore coordination for integrated audio plugins.');
|
|
assert.equal(owner.ownership, 'exclusive-owner');
|
|
assert.equal(owner.safety, 'safe');
|
|
});
|
|
|
|
test('runtime registration refreshes an existing manifest participant without duplicating it', async () => {
|
|
const window = loadCapabilities();
|
|
const api = window.feedBack.capabilities;
|
|
api.registerParticipants([fixture('valid_owner_provider.json')]);
|
|
api.registerParticipant('stems', {
|
|
capabilities: {
|
|
stems: {
|
|
roles: ['owner', 'provider'],
|
|
commands: ['mute'],
|
|
runtime: true,
|
|
handlers: { mute: () => ({ outcome: 'handled', payload: { muted: true } }) },
|
|
},
|
|
},
|
|
});
|
|
api.registerParticipant('stems', {
|
|
stems: {
|
|
roles: ['owner', 'provider'],
|
|
commands: ['mute'],
|
|
runtime: true,
|
|
handlers: { mute: () => ({ outcome: 'handled', payload: { muted: 'refreshed' } }) },
|
|
},
|
|
});
|
|
|
|
const stems = api.inspect('stems');
|
|
assert.equal(stems.participants.filter(p => p.pluginId === 'stems').length, 1);
|
|
assert.equal(stems.participants[0].runtime, true);
|
|
const result = await api.dispatch({ capability: 'stems', command: 'mute', source: 'test' });
|
|
assert.equal(result.status, 'applied');
|
|
assert.deepEqual(result.payload, { muted: 'refreshed' });
|
|
});
|
|
|
|
test('native library provider capability coordinates providers', async () => {
|
|
const providers = [
|
|
{ id: 'local', label: 'My Library', capabilities: ['library.read'], default: true },
|
|
{ id: 'remote:frodo', label: 'Frodo', capabilities: ['library.read', 'song.sync'], owner_plugin_id: 'frodo_library' },
|
|
];
|
|
const synced = [];
|
|
const window = loadCapabilities({ library: true });
|
|
window.fetch = async (url, options = {}) => {
|
|
const text = String(url);
|
|
if (text === '/api/library/providers') {
|
|
return { ok: true, json: async () => ({ providers }) };
|
|
}
|
|
if (text.includes('/sync') && options.method === 'POST') {
|
|
synced.push(text);
|
|
return { ok: true, json: async () => ({ ok: true, filename: 'remote:frodo:song-1' }) };
|
|
}
|
|
throw new Error(`unexpected fetch ${text}`);
|
|
};
|
|
const api = window.feedBack.capabilities;
|
|
const events = [];
|
|
api.subscribe('library:source-changed', event => events.push(event));
|
|
|
|
await api.command('library', 'refresh-providers', { requester: 'test', payload: { restoreSaved: true } });
|
|
const listed = await api.command('library', 'list-providers', { requester: 'test' });
|
|
assert.equal(listed.outcome, 'handled');
|
|
assert.equal(listed.payload.providers[1].owner_plugin_id, 'frodo_library');
|
|
|
|
const libraryPipeline = api.inspect('library');
|
|
const providerParticipants = libraryPipeline.participants.filter(participant => participant.roles.includes('provider'));
|
|
const localProvider = providerParticipants.find(participant => participant.pluginId === 'core.library.local');
|
|
const remoteProvider = providerParticipants.find(participant => participant.pluginId === 'frodo_library');
|
|
assert.ok(localProvider);
|
|
assert.equal(localProvider.providerPolicy.providerId, 'local');
|
|
assert.ok(localProvider.operations.includes('query-page'));
|
|
assert.ok(remoteProvider);
|
|
assert.equal(remoteProvider.providerPolicy.providerId, 'remote:frodo');
|
|
assert.ok(remoteProvider.operations.includes('sync-song'));
|
|
|
|
const selected = await api.command('library', 'select-provider', {
|
|
requester: 'test',
|
|
target: { providerId: 'remote:frodo' },
|
|
});
|
|
assert.equal(selected.payload.current, 'remote:frodo');
|
|
assert.equal(events.length, 1);
|
|
assert.equal(events[0].payload.to, 'remote:frodo');
|
|
assert.equal(window.feedBack.libraryProviders.snapshot().current, 'remote:frodo');
|
|
|
|
const syncResult = await api.command('library', 'sync-song', {
|
|
requester: 'test',
|
|
target: { providerId: 'remote:frodo', songId: 'song-1' },
|
|
});
|
|
assert.equal(syncResult.outcome, 'handled');
|
|
assert.equal(syncResult.payload.result.filename, 'remote:frodo:song-1');
|
|
assert.equal(synced.length, 1);
|
|
});
|
|
|
|
test('removed library providers are unregistered as library participants on refresh', async () => {
|
|
let providerSet = [
|
|
{ id: 'local', label: 'My Library', capabilities: ['library.read'], default: true },
|
|
{ id: 'remote:frodo', label: 'Frodo', capabilities: ['library.read', 'song.sync'], owner_plugin_id: 'frodo_library' },
|
|
{ id: 'remote:sam', label: 'Sam', capabilities: ['library.read'], owner_plugin_id: 'sam_library' },
|
|
];
|
|
const window = loadCapabilities({ library: true });
|
|
window.fetch = async (url) => {
|
|
if (String(url) === '/api/library/providers') return { ok: true, json: async () => ({ providers: providerSet }) };
|
|
throw new Error(`unexpected fetch ${url}`);
|
|
};
|
|
const api = window.feedBack.capabilities;
|
|
|
|
await api.command('library', 'refresh-providers', { requester: 'test' });
|
|
let ids = api.inspect('library').participants.map(p => p.pluginId);
|
|
assert.ok(ids.includes('frodo_library'));
|
|
assert.ok(ids.includes('sam_library'));
|
|
|
|
// Sam is removed and the endpoint now omits it; the stale participant must
|
|
// not linger in the capability registry / Inspector snapshot.
|
|
providerSet = [
|
|
{ id: 'local', label: 'My Library', capabilities: ['library.read'], default: true },
|
|
{ id: 'remote:frodo', label: 'Frodo', capabilities: ['library.read', 'song.sync'], owner_plugin_id: 'frodo_library' },
|
|
];
|
|
await api.command('library', 'refresh-providers', { requester: 'test' });
|
|
ids = api.inspect('library').participants.map(p => p.pluginId);
|
|
assert.ok(ids.includes('frodo_library'));
|
|
assert.equal(ids.includes('sam_library'), false);
|
|
assert.ok(ids.includes('core.library.local'));
|
|
|
|
// A fetch failure falls back to local-only — all remote providers drop.
|
|
window.fetch = async () => { throw new Error('network down'); };
|
|
await api.command('library', 'refresh-providers', { requester: 'test' });
|
|
ids = api.inspect('library').participants.map(p => p.pluginId);
|
|
assert.equal(ids.includes('frodo_library'), false);
|
|
assert.ok(ids.includes('core.library.local'));
|
|
});
|
|
|
|
test('a plugin with non-provider library roles is not wiped when its provider disappears', async () => {
|
|
let providerSet = [
|
|
{ id: 'local', label: 'My Library', capabilities: ['library.read'], default: true },
|
|
{ id: 'remote:sam', label: 'Sam', capabilities: ['library.read'], owner_plugin_id: 'sam_library' },
|
|
];
|
|
const window = loadCapabilities({ library: true });
|
|
window.fetch = async (url) => {
|
|
if (String(url) === '/api/library/providers') return { ok: true, json: async () => ({ providers: providerSet }) };
|
|
throw new Error(`unexpected fetch ${url}`);
|
|
};
|
|
const api = window.feedBack.capabilities;
|
|
|
|
// The same plugin also declares an observer library role via its manifest —
|
|
// legitimate participation the provider-cleanup path must not delete.
|
|
api.registerParticipants([{
|
|
id: 'sam_library',
|
|
name: 'Sam Library',
|
|
runtime_domains: { library: { role: 'observer', observes: ['source-changed'] } },
|
|
}]);
|
|
|
|
await api.command('library', 'refresh-providers', { requester: 'test' });
|
|
let sam = api.inspect('library').participants.find(p => p.pluginId === 'sam_library');
|
|
assert.ok(sam);
|
|
assert.ok(sam.roles.includes('provider'));
|
|
assert.ok(sam.roles.includes('observer'));
|
|
|
|
// Sam's provider is removed from the backend list. The participant stays
|
|
// because it still carries the manifest-declared observer role.
|
|
providerSet = [{ id: 'local', label: 'My Library', capabilities: ['library.read'], default: true }];
|
|
await api.command('library', 'refresh-providers', { requester: 'test' });
|
|
sam = api.inspect('library').participants.find(p => p.pluginId === 'sam_library');
|
|
assert.ok(sam, 'plugin with a manifest library role must survive provider removal');
|
|
assert.ok(sam.roles.includes('observer'));
|
|
});
|
|
|
|
test('runtime domain library declarations appear as library participants', () => {
|
|
const window = loadCapabilities();
|
|
const api = window.feedBack.capabilities;
|
|
|
|
const touched = api.registerParticipants([{
|
|
id: 'remote-library-client',
|
|
name: 'Remote Library Client',
|
|
runtime_domains: {
|
|
library: {
|
|
role: 'provider',
|
|
operations: ['query-page'],
|
|
description: 'Adds a remote source to the library provider list.',
|
|
},
|
|
},
|
|
}]);
|
|
|
|
assert.deepEqual(Array.from(touched), ['library']);
|
|
const library = api.inspect('library');
|
|
const participant = library.participants.find(item => item.pluginId === 'remote-library-client');
|
|
assert.ok(participant);
|
|
assert.deepEqual(Array.from(participant.roles), ['provider']);
|
|
assert.ok(participant.operations.includes('query-page'));
|
|
assert.equal(participant.description, 'Adds a remote source to the library provider list.');
|
|
assert.equal(participant.ownership, 'exclusive-owner');
|
|
}); |