feedBack/tests/js/capabilities_lifecycle.test.js
Bret Mogilefsky af2949677a
rename: slopsmith → feedBack, byron → got-feedBack (#537)
* Update GitHub repo references from feedback* to feedBack*

* rename: slopsmith -> feedBack, byron -> got-feedBack

Renames across the entire codebase:
- slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack
- byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack
- /home/byron/ -> /opt/got-feedBack/
- byron@ougsoft.com -> hi@got-feedBack.org
- github.com/byrongamatos/ -> github.com/got-feedback/
- com.byron. -> com.got-feedback.
- SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback
- Protocol/storage strings migrated with read-old/write-new pattern
- window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias

Refs: #rename-slopsmith

* rename: complete regen against current main + fix backward-compat alias

Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of
current main (3 commits had landed since the branch: #572/#554/#574),
resolving the four content conflicts in favour of main's newer content
(autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge).

Completion fixes on top of the mechanical rename:
- Re-apply rename to post-branch content the original rename never saw:
  window.slopsmith(.Tour) consumers in lessons.js / notifications.js /
  onboarding-tour.js, and the matching JS + python tests (autoplay_exit,
  progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env
  vars now match server.py (which reads FEEDBACK_SYNC_STARTUP /
  FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real
  path again.
- Restore the window.slopsmith backward-compat alias dropped during conflict
  resolution, and move the bus aliases to AFTER the _feedBackExisting merge
  block so they reference the fully-assembled object (also fixes the
  loop_api.test.js API-surface regex, which the original PR latently broke).
- Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR)
  and gitignore it.
- Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped
  source labels.

Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669
passed / 1683 collected with 0 import errors; zero residual slopsmith/byron
except the two intentional window.slopsmith aliases.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* rename: implement advertised backward-compat + prune dead community plugins

Address gaps where PR #537's "Backward compatibility" section was advertised
but not implemented, and clean up the community plugin list.

Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured):
- New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py
  (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and
  tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI /
  SLOPSMITH_PLUGINS_DIR / etc. deployments keep working.
- Fix the rename collapsing plugins/__init__.py and minigames/routes.py from
  `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant
  `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost).

Storage (app.js update-channel):
- Read feedBack-update-channel, fall back to legacy slopsmith-update-channel,
  and clear the legacy key on write — so a user's update-channel preference
  survives the rename instead of resetting to "stable".

Community plugin list (README): the rename rewrote third-party repo URLs we
don't own. Probed every one; their owners never renamed, so:
- Restore the 13 live community plugins to their real slopsmith-* names.
- Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex
  tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle).
- Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory).

Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors,
rename-sensitive + startup suites green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: byrongamatos <xasiklas@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 11:03:01 +02:00

80 lines
4.2 KiB
JavaScript

const { test } = require('node:test');
const assert = require('node:assert/strict');
const { loadCapabilities } = require('./capabilities_test_harness');
test('capability runtime installs early feedBack event bus', () => {
const window = loadCapabilities();
const events = [];
const onceEvents = [];
window.feedBack.on('screen:changed', event => events.push(event.detail));
window.feedBack.on('song:ready', event => onceEvents.push(event.detail), { once: true });
window.feedBack.emit('screen:changed', { id: 'home' });
window.feedBack.emit('song:ready', { title: 'First' });
window.feedBack.emit('song:ready', { title: 'Second' });
assert.deepEqual(events, [{ id: 'home' }]);
assert.deepEqual(onceEvents, [{ title: 'First' }]);
assert.equal(typeof window.feedBack.off, 'function');
});
test('unregistering requester releases its claims', () => {
const window = loadCapabilities();
const api = window.feedBack.capabilities;
api.registerParticipant('stems', { stems: { roles: ['owner'], commands: ['mute'], handlers: { mute: () => ({ outcome: 'handled' }) }, runtime: true } });
api.registerParticipant('nam_tone', { stems: { roles: ['requester'], commands: ['mute'], runtime: true } });
api.claim({ capability: 'stems', claimId: 'nam.amp-active', requester: 'nam_tone' });
api.unregisterParticipant('nam_tone');
const snapshot = api.snapshotDiagnostics();
assert.equal(snapshot.activeClaims.some(c => c.claimId === 'nam.amp-active'), false);
assert.equal(snapshot.claimLifecycle.some(c => c.claimId === 'nam.amp-active' && c.state === 'released'), true);
});
test('unregistering owner or handler orphans claim and prevents dispatch', async () => {
const window = loadCapabilities();
const api = window.feedBack.capabilities;
api.registerParticipant('stems', { stems: { roles: ['owner'], commands: ['mute'], handlers: { mute: () => ({ outcome: 'handled' }) }, runtime: true } });
api.claim({ capability: 'stems', claimId: 'nam.amp-active', requester: 'nam_tone' });
api.unregisterParticipant('stems');
const snapshot = api.snapshotDiagnostics();
const claim = snapshot.activeClaims.find(c => c.claimId === 'nam.amp-active');
assert.equal(claim.state, 'orphaned');
assert.equal(claim.nonDispatchable, true);
const result = await api.dispatch({ capability: 'stems', command: 'mute', source: 'nam_tone', claim: { claimId: 'nam.amp-active' } });
assert.equal(result.status, 'no-owner');
assert.equal(result.outcome, 'no-owner');
});
test('runtime enable disable is lifecycle state rather than user override', () => {
const window = loadCapabilities();
const api = window.feedBack.capabilities;
api.registerParticipant('plugin_a', { stems: { roles: ['provider'], commands: ['inspect'], runtime: true } });
const disabled = api.setParticipantEnabled('plugin_a', 'stems', false, { requester: 'test' });
const enabled = api.setParticipantEnabled('plugin_a', 'stems', true, { requester: 'test' });
const snapshot = api.snapshotDiagnostics();
assert.equal(disabled.ok, true);
assert.equal(enabled.ok, true);
assert.equal(snapshot.userOverrides.length, 0);
assert.equal(snapshot.participants.find(p => p.pluginId === 'plugin_a').runtimeOverride.enabled, true);
});
test('failed no-op registrations do not block reload and rehydrate replacement', async () => {
const window = loadCapabilities();
const api = window.feedBack.capabilities;
api.registerParticipant('', { stems: { roles: ['owner'] } });
api.registerParticipant('stems', { stems: { roles: ['owner'], commands: ['mute'], handlers: { mute: () => ({ outcome: 'handled', payload: { generation: 1 } }) }, runtime: true } });
api.unregisterParticipant('stems');
api.registerParticipant('stems', { stems: { roles: ['owner'], commands: ['mute'], handlers: { mute: () => ({ outcome: 'handled', payload: { generation: 2 } }) }, runtime: true } });
const result = await api.dispatch({ capability: 'stems', command: 'mute', source: 'test' });
const participants = api.inspect('stems').participants.filter(p => p.pluginId === 'stems');
assert.equal(participants.length, 1);
assert.equal(result.status, 'applied');
assert.equal(result.payload.generation, 2);
});