feedBack/tests/js/capabilities_diagnostics.test.js
Bret Mogilefsky af2949677a
rename: slopsmith → feedBack, byron → got-feedBack (#537)
* Update GitHub repo references from feedback* to feedBack*

* rename: slopsmith -> feedBack, byron -> got-feedBack

Renames across the entire codebase:
- slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack
- byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack
- /home/byron/ -> /opt/got-feedBack/
- byron@ougsoft.com -> hi@got-feedBack.org
- github.com/byrongamatos/ -> github.com/got-feedback/
- com.byron. -> com.got-feedback.
- SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback
- Protocol/storage strings migrated with read-old/write-new pattern
- window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias

Refs: #rename-slopsmith

* rename: complete regen against current main + fix backward-compat alias

Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of
current main (3 commits had landed since the branch: #572/#554/#574),
resolving the four content conflicts in favour of main's newer content
(autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge).

Completion fixes on top of the mechanical rename:
- Re-apply rename to post-branch content the original rename never saw:
  window.slopsmith(.Tour) consumers in lessons.js / notifications.js /
  onboarding-tour.js, and the matching JS + python tests (autoplay_exit,
  progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env
  vars now match server.py (which reads FEEDBACK_SYNC_STARTUP /
  FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real
  path again.
- Restore the window.slopsmith backward-compat alias dropped during conflict
  resolution, and move the bus aliases to AFTER the _feedBackExisting merge
  block so they reference the fully-assembled object (also fixes the
  loop_api.test.js API-surface regex, which the original PR latently broke).
- Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR)
  and gitignore it.
- Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped
  source labels.

Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669
passed / 1683 collected with 0 import errors; zero residual slopsmith/byron
except the two intentional window.slopsmith aliases.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* rename: implement advertised backward-compat + prune dead community plugins

Address gaps where PR #537's "Backward compatibility" section was advertised
but not implemented, and clean up the community plugin list.

Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured):
- New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py
  (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and
  tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI /
  SLOPSMITH_PLUGINS_DIR / etc. deployments keep working.
- Fix the rename collapsing plugins/__init__.py and minigames/routes.py from
  `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant
  `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost).

Storage (app.js update-channel):
- Read feedBack-update-channel, fall back to legacy slopsmith-update-channel,
  and clear the legacy key on write — so a user's update-channel preference
  survives the rename instead of resetting to "stable".

Community plugin list (README): the rename rewrote third-party repo URLs we
don't own. Probed every one; their owners never renamed, so:
- Restore the 13 live community plugins to their real slopsmith-* names.
- Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex
  tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle).
- Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory).

Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors,
rename-sensitive + startup suites green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: byrongamatos <xasiklas@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 11:03:01 +02:00

183 lines
8.1 KiB
JavaScript

const { test } = require('node:test');
const assert = require('node:assert/strict');
const { loadCapabilities } = require('./capabilities_test_harness');
test('diagnostics snapshots redact paths and trim recent decisions under 64 KB', async () => {
const window = loadCapabilities();
const api = window.feedBack.capabilities;
api.registerParticipant('owner', {
stems: {
roles: ['owner'],
commands: ['mute'],
runtime: true,
handlers: { mute: () => ({ outcome: 'failed', reason: 'token=abc123 path /Users/example/secret/file.txt ' + 'x'.repeat(2000) }) },
},
});
for (let i = 0; i < 120; i += 1) {
await api.dispatch({ capability: 'stems', command: 'mute', source: 'diag-test', args: { target: { id: `target-${i}` } } });
}
const snapshot = api.snapshotDiagnostics();
const encoded = JSON.stringify(snapshot);
assert.ok(encoded.length <= 64 * 1024);
assert.equal(encoded.includes('/Users/example'), false);
assert.equal(encoded.includes('abc123'), false);
assert.equal(snapshot.snapshotBytes <= 64 * 1024, true);
});
test('compatibility shim hit counts and attribution are exported', () => {
const window = loadCapabilities();
const api = window.feedBack.capabilities;
api.registerCompatibilityShim({ shimId: 'stems:legacy-window', source: 'stems', capability: 'stems', legacySurface: 'window._stemsState', status: 'active', reason: 'legacy global bridge' });
api.registerCompatibilityShim({ shimId: 'stems:legacy-window', source: 'stems', capability: 'stems', legacySurface: 'window._stemsState', status: 'used', used: true });
api.registerCompatibilityShim({ shimId: 'stems:legacy-window', source: 'stems', capability: 'stems', legacySurface: 'window._stemsState', status: 'used', hit: true });
const shim = api.snapshotDiagnostics().compatibilityShims.find(entry => entry.shimId === 'stems:legacy-window');
assert.equal(shim.source, 'stems');
assert.equal(shim.capability, 'stems');
assert.equal(shim.hitCount, 2);
assert.ok(shim.lastHitAt);
});
test('diagnostics export expected compatibility shim surfaces', () => {
const window = loadCapabilities();
const api = window.feedBack.capabilities;
const expected = api.snapshotDiagnostics().expectedCompatibilityShims;
assert.ok(Array.isArray(expected));
assert.equal(expected.some(entry => entry.capability === 'library'), false);
assert.equal(expected.some(entry => entry.capability === 'backend.routes'), false);
assert.equal(expected.some(entry => entry.capability === 'playback'), false);
assert.equal(expected.some(entry => entry.capability === 'visualization'), false);
assert.equal(expected.some(entry => entry.capability === 'jobs'), false);
});
test('diagnostics include active playback but exclude deferred and documentation-only future core domains', () => {
const window = loadCapabilities();
const api = window.feedBack.capabilities;
api.registerParticipant('playback_probe', {
playback: {
roles: ['provider'],
commands: ['snapshot'],
runtime: true,
},
});
api.registerParticipant('future_plugin', {
'ui.player-panels': {
roles: ['provider'],
commands: ['register-contribution'],
runtime: true,
},
});
api.registerParticipants([{ id: 'future_manifest', capabilities: { jobs: { roles: ['provider'], commands: ['register'] } } }]);
api.registerCompatibilityShim({ shimId: 'deferred:viz', source: 'highway_3d', capability: 'visualization', legacySurface: 'highway.setRenderer', status: 'used', hit: true });
api.registerCompatibilityShim({ shimId: 'deferred:routes', source: 'legacy_routes_plugin', capability: 'backend.routes', legacySurface: 'routes', status: 'used', hit: true });
const pipelines = api.snapshotDiagnostics().pipelines;
const playback = pipelines.find(entry => entry.name === 'playback');
assert.ok(playback, 'playback should be part of the active runtime graph when participants register');
assert.equal(playback.review.lifecycle, 'active');
// `visualization` (cap:6 slice) and `note-detection` (spec 009 slice)
// left this list when their domains were promoted.
const futureDomains = [
'ui.navigation', 'ui.plugin-screens', 'settings',
'backend.routes', 'ui.player-controls',
'ui.player-panels', 'ui.player-overlays', 'plugins', 'jobs', 'midi-control',
'tempo-clock',
];
for (const domain of futureDomains) {
assert.equal(pipelines.some(entry => entry.name === domain), false, `${domain} should stay out of the runtime graph`);
}
// visualization is active now, so its shim entries are recorded rather
// than dropped; backend.routes stays reserved and dropped.
assert.equal(api.snapshotDiagnostics().compatibilityShims.some(entry => entry.capability === 'visualization'), true);
assert.equal(api.snapshotDiagnostics().compatibilityShims.some(entry => entry.capability === 'backend.routes'), false);
});
test('server-reported shim hit counts are not inflated by refresh registration', () => {
const window = loadCapabilities();
const api = window.feedBack.capabilities;
const shim = {
shimId: 'stems:legacy-window',
source: 'stems',
capability: 'stems',
legacySurface: 'window._stemsState',
status: 'used',
hitCount: 1,
};
api.registerCompatibilityShim(shim);
api.registerCompatibilityShim(shim);
const exported = api.snapshotDiagnostics().compatibilityShims.find(entry => entry.shimId === shim.shimId);
assert.equal(exported.hitCount, 1);
assert.equal(exported.source, 'stems');
assert.ok(exported.lastHitAt);
});
test('recordLegacyHit preserves non-library shim attribution', () => {
const window = loadCapabilities();
const api = window.feedBack.capabilities;
const first = api.recordLegacyHit({
capability: 'stems',
legacySurface: 'window._stemsState',
source: 'legacy-stems',
});
api.registerCompatibilityShim({
shimId: first.shimId,
source: 'legacy-stems',
capability: 'stems',
legacySurface: 'window._stemsState',
status: 'active',
});
const exported = api.snapshotDiagnostics().compatibilityShims.find(entry => entry.shimId === first.shimId);
assert.equal(exported.status, 'used');
assert.equal(exported.hitCount, 1);
assert.equal(exported.source, 'legacy-stems');
});
test('recordLegacyHit counts runtime use and preserves used status across active refreshes', () => {
const window = loadCapabilities();
const api = window.feedBack.capabilities;
const first = api.recordLegacyHit({
capability: 'stems',
legacySurface: 'window._stemsState',
source: 'legacy-event-bus',
reason: 'legacy event emitted',
});
api.registerCompatibilityShim({
shimId: first.shimId,
source: 'legacy-event-bus',
capability: 'stems',
legacySurface: 'window._stemsState',
status: 'active',
reason: 'static metadata refresh',
});
api.recordLegacyHit({
capability: 'stems',
legacySurface: 'window._stemsState',
source: 'legacy-event-bus',
reason: 'legacy event emitted again',
});
const exported = api.snapshotDiagnostics().compatibilityShims.find(entry => entry.shimId === first.shimId);
assert.equal(exported.status, 'used');
assert.equal(exported.hitCount, 2);
assert.equal(exported.capability, 'stems');
assert.equal(exported.legacySurface, 'window._stemsState');
assert.ok(exported.lastHitAt);
});
test('capability diagnostics emit a changed event after runtime updates', async () => {
const window = loadCapabilities();
const api = window.feedBack.capabilities;
let changes = 0;
window.addEventListener('feedBack:capabilities:changed', () => { changes += 1; });
api.recordLegacyHit({
capability: 'stems',
legacySurface: 'window._stemsState',
source: 'legacy-event-listener',
});
await new Promise(resolve => setTimeout(resolve, 10));
assert.ok(changes >= 1);
});