mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-21 12:21:49 +00:00
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
62 lines
3.4 KiB
JavaScript
62 lines
3.4 KiB
JavaScript
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const { loadAudioSession } = require('./audio_session_test_harness');
|
|
|
|
test('stem owner claim restore orphan and manual override lifecycle is recorded', async () => {
|
|
const window = loadAudioSession();
|
|
const api = window.feedBack.capabilities;
|
|
const audioSession = window.feedBack.audioSession;
|
|
|
|
const noOwner = await api.dispatch({ capability: 'stems', command: 'mute', source: 'nam_tone', payload: { stemIds: ['guitar'] } });
|
|
assert.equal(noOwner.outcome, 'no-owner');
|
|
|
|
audioSession.registerStemOwner({ ownerId: 'stems.plugin', stemIds: ['guitar', 'bass'], stemStates: { guitar: { muted: false } } });
|
|
const muted = await api.dispatch({ capability: 'stems', command: 'mute', source: 'nam_tone', payload: { claimId: 'nam.amp-active', stemIds: ['guitar'] } });
|
|
assert.equal(muted.status, 'applied');
|
|
assert.equal(muted.payload.state, 'active');
|
|
assert.equal(api.snapshotDiagnostics().activeClaims.some(claim => claim.claimId === 'nam.amp-active'), true);
|
|
|
|
const override = audioSession.recordStemManualOverride({ stemIds: ['guitar'], requester: 'user' });
|
|
assert.equal(override.overriddenClaims.length, 1);
|
|
assert.equal(audioSession.snapshot().domains.stems.claims[0].state, 'overridden');
|
|
|
|
const restored = await api.dispatch({ capability: 'stems', command: 'restore', source: 'nam_tone', payload: { claimId: 'nam.amp-active' } });
|
|
assert.equal(restored.outcome, 'overridden');
|
|
});
|
|
|
|
test('audio session coordinates stems without replacing the active stems owner', () => {
|
|
const window = loadAudioSession();
|
|
const api = window.feedBack.capabilities;
|
|
const audioSession = window.feedBack.audioSession;
|
|
|
|
let stemsPipeline = api.inspect('stems');
|
|
let coordinator = stemsPipeline.participants.find(entry => entry.pluginId === 'core.audio.session');
|
|
assert.equal(coordinator.roles.includes('coordinator'), true);
|
|
assert.equal(coordinator.roles.includes('owner'), false);
|
|
|
|
audioSession.registerStemOwner({ ownerId: 'stems.plugin', stemIds: ['guitar'] });
|
|
stemsPipeline = api.inspect('stems');
|
|
coordinator = stemsPipeline.participants.find(entry => entry.pluginId === 'core.audio.session');
|
|
const provider = stemsPipeline.participants.find(entry => entry.pluginId === 'stems.plugin');
|
|
|
|
assert.equal(coordinator.roles.includes('owner'), false);
|
|
assert.equal(provider.roles.includes('provider'), true);
|
|
assert.equal(audioSession.snapshot().domains.stems.owner.ownerId, 'stems.plugin');
|
|
});
|
|
|
|
test('stem automation claims become orphaned when owner disappears', () => {
|
|
const window = loadAudioSession();
|
|
const api = window.feedBack.capabilities;
|
|
const audioSession = window.feedBack.audioSession;
|
|
const unavailableEvents = [];
|
|
api.subscribe('stems:owner-unavailable', detail => unavailableEvents.push(detail));
|
|
|
|
audioSession.registerStemOwner({ ownerId: 'stems.plugin', stemIds: ['guitar'] });
|
|
audioSession.muteStems({ claimId: 'claim-one', requester: 'nam_tone', stemIds: ['guitar'] });
|
|
audioSession.registerStemOwner({ ownerId: 'stems.plugin', availability: 'disabled', stemIds: ['guitar'] });
|
|
|
|
const claim = audioSession.snapshot().domains.stems.claims.find(entry => entry.claimId === 'claim-one');
|
|
assert.equal(claim.state, 'orphaned');
|
|
assert.equal(unavailableEvents.length, 1);
|
|
assert.equal(unavailableEvents[0].payload.availability, 'disabled');
|
|
}); |