mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-21 12:21:49 +00:00
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
121 lines
6.3 KiB
JavaScript
121 lines
6.3 KiB
JavaScript
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const { loadAudioSession, runBrowserScript, installMixerDom } = require('./audio_session_test_harness');
|
|
|
|
test('audio session records route transitions without blocking callers', () => {
|
|
const window = loadAudioSession();
|
|
const audioSession = window.feedBack.audioSession;
|
|
|
|
const html5 = audioSession.setRoute({ routeKind: 'html5', availability: 'available', selectedByUser: true });
|
|
const stems = audioSession.setRoute({ routeKind: 'stems', availability: 'available', selectedByUser: true });
|
|
const juce = audioSession.setRoute({ routeKind: 'juce', availability: 'degraded', fallbackReason: 'native route unavailable' });
|
|
const snapshot = audioSession.snapshot();
|
|
|
|
assert.equal(html5.routeKind, 'html5');
|
|
assert.equal(stems.routeKind, 'stems');
|
|
assert.equal(juce.availability, 'degraded');
|
|
assert.equal(snapshot.domains['audio-mix'].route.routeKind, 'juce');
|
|
assert.equal(snapshot.recentOutcomes.at(-1).outcome, 'degraded');
|
|
});
|
|
|
|
test('legacy song fader registration is bridged into audio-mix participants and route diagnostics', async () => {
|
|
const window = loadAudioSession();
|
|
const { audio } = installMixerDom(window);
|
|
window.localStorage.setItem('volume', '65');
|
|
|
|
runBrowserScript(window, 'static/audio-mixer.js');
|
|
assert.equal(typeof window.feedBack.audio.applySongVolume, 'function');
|
|
|
|
await window.feedBack.audio.applySongVolume(72);
|
|
const snapshot = window.feedBack.audioSession.snapshot();
|
|
const songParticipant = snapshot.domains['audio-mix'].participants.find(p => p.participantId === 'core.song');
|
|
|
|
assert.equal(audio.volume, 0.72);
|
|
assert.equal(songParticipant.label, 'Song');
|
|
assert.equal(songParticipant.fader.currentValue, 72);
|
|
assert.equal(snapshot.domains['audio-mix'].route.routeKind, 'html5');
|
|
assert.equal(snapshot.domains['audio-mix'].bridges.some(b => b.bridgeId === 'audio-mix.song-volume'), true);
|
|
});
|
|
|
|
test('song volume persists through html5 stems and desktop routes', async () => {
|
|
const window = loadAudioSession();
|
|
const { audio } = installMixerDom(window);
|
|
const stemsCalls = [];
|
|
const desktopCalls = [];
|
|
window.localStorage.setItem('volume', '41');
|
|
window.feedBack.stems = { setMasterVolume(value) { stemsCalls.push(value); return Promise.resolve(); } };
|
|
window.feedBackDesktop = { audio: { setGain(name, value) { desktopCalls.push([name, value]); return Promise.resolve(); } } };
|
|
|
|
runBrowserScript(window, 'static/audio-mixer.js');
|
|
assert.equal(window.feedBack.audio.readSongVolume(), 41);
|
|
|
|
await window.feedBack.audio.applySongVolume(55);
|
|
assert.equal(audio.volume, 0.55);
|
|
assert.equal(stemsCalls.at(-1), 0.55);
|
|
assert.equal(window.feedBack.audioSession.snapshot().domains['audio-mix'].route.routeKind, 'stems');
|
|
|
|
window._juceMode = true;
|
|
delete window.feedBack.stems;
|
|
await window.feedBack.audio.applySongVolume(66);
|
|
assert.deepEqual(desktopCalls.at(-1), ['backing', 0.66]);
|
|
assert.equal(window.feedBack.audioSession.snapshot().domains['audio-mix'].route.routeKind, 'juce');
|
|
});
|
|
|
|
test('stems provider ownership remains separate from audio-mix stem participation', async () => {
|
|
const window = loadAudioSession();
|
|
const audioSession = window.feedBack.audioSession;
|
|
audioSession.startSession({ sessionId: 'main:stems-song' });
|
|
audioSession.registerStemOwner({ ownerId: 'stems_plugin', stemIds: ['guitar', 'bass'], availability: 'available' });
|
|
audioSession.registerMixParticipant({
|
|
participantId: 'stems.master',
|
|
ownerPluginId: 'stems_plugin',
|
|
label: 'Stems',
|
|
kind: 'stem',
|
|
sourceMode: 'native',
|
|
fader: { id: 'master', label: 'Stems', min: 0, max: 1, step: 0.1, defaultValue: 1, currentValue: 1 },
|
|
operations: ['fader.get-value', 'fader.set-value'],
|
|
});
|
|
|
|
const stemsInspect = await window.feedBack.capabilities.dispatch({ capability: 'stems', command: 'inspect', source: 'test' });
|
|
const mixInspect = await window.feedBack.capabilities.dispatch({ capability: 'audio-mix', command: 'inspect', source: 'test' });
|
|
|
|
assert.equal(stemsInspect.payload.owner.ownerId, 'stems_plugin');
|
|
assert.equal(mixInspect.payload.faders.some(fader => fader.kind === 'stem' && fader.ownerPluginId === 'stems_plugin'), true);
|
|
});
|
|
|
|
test('audio-input selection and registered providers survive song session switches without live sessions', async () => {
|
|
const window = loadAudioSession();
|
|
const api = window.feedBack.capabilities;
|
|
const audioSession = window.feedBack.audioSession;
|
|
|
|
audioSession.startSession({ sessionId: 'main:first-song', songKey: 'first-song.sloppak', songFormat: 'sloppak' });
|
|
await api.dispatch({
|
|
capability: 'audio-input',
|
|
command: 'register-source',
|
|
source: 'note_detect',
|
|
payload: {
|
|
sourceId: 'switch-source',
|
|
logicalSourceKey: 'switch:instrument:primary',
|
|
providerId: 'note_detect',
|
|
kind: 'instrument',
|
|
safeLabel: 'Switch Input',
|
|
channelSummary: { channelCount: 1, channelShape: 'mono', supports: ['mono'] },
|
|
operations: ['source.open', 'source.close'],
|
|
operationHandlers: {
|
|
'source.open': () => ({ outcome: 'handled' }),
|
|
'source.close': () => ({ outcome: 'handled' }),
|
|
},
|
|
},
|
|
});
|
|
await api.dispatch({ capability: 'audio-input', command: 'select-source', source: 'user', payload: { logicalSourceKey: 'switch:instrument:primary' } });
|
|
const open = await api.dispatch({ capability: 'audio-input', command: 'open-source', source: 'note_detect', payload: { requesterId: 'note_detect', requiredChannelShape: 'mono' } });
|
|
assert.equal(open.outcome, 'handled');
|
|
|
|
const next = audioSession.startSession({ sessionId: 'main:second-song', songKey: 'second-song.archive', songFormat: 'archive' });
|
|
const listed = await api.dispatch({ capability: 'audio-input', command: 'list-sources', source: 'note_detect' });
|
|
|
|
assert.equal(next.session.songFormat, 'archive');
|
|
assert.equal(next.domains['audio-input'].selected.logicalSourceKey, 'switch:instrument:primary');
|
|
assert.equal(next.domains['audio-input'].totalOpenSessions, 0);
|
|
assert.equal(listed.payload.sources.some(source => source.logicalSourceKey === 'switch:instrument:primary'), true);
|
|
}); |