mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-21 12:21:49 +00:00
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
159 lines
7.8 KiB
TypeScript
159 lines
7.8 KiB
TypeScript
import { test, expect } from '@playwright/test';
|
|
|
|
// Issue #686 — a Screen Wake Lock is held only while a song plays so the OS
|
|
// screensaver doesn't kick in during windowed-mode playback. We stub
|
|
// navigator.wakeLock before app.js runs (headless Chromium rejects a real
|
|
// 'screen' request — there is no display) and drive the song:* bus events the
|
|
// wake-lock helper listens to. `held` flips true only once a request actually
|
|
// resolves and the lock is kept, so the fast play→pause race is observable.
|
|
const installWakeLockSpy = () => {
|
|
(window as any).__wakeLockSpy = {
|
|
requestCount: 0,
|
|
releaseCount: 0,
|
|
lastType: null as string | null,
|
|
held: false,
|
|
lastSentinel: null as any,
|
|
};
|
|
Object.defineProperty(navigator, 'wakeLock', {
|
|
configurable: true,
|
|
value: {
|
|
request(type: string) {
|
|
const spy = (window as any).__wakeLockSpy;
|
|
spy.requestCount++;
|
|
spy.lastType = type;
|
|
const listeners: Array<() => void> = [];
|
|
const sentinel = {
|
|
released: false,
|
|
addEventListener(t: string, fn: () => void) {
|
|
if (t === 'release') listeners.push(fn);
|
|
},
|
|
removeEventListener() {},
|
|
release() {
|
|
if (this.released) return Promise.resolve();
|
|
this.released = true;
|
|
spy.releaseCount++;
|
|
spy.held = false;
|
|
listeners.forEach((fn) => fn());
|
|
return Promise.resolve();
|
|
},
|
|
};
|
|
spy.lastSentinel = sentinel;
|
|
// The lock is only "held" once the request resolves and is kept — model
|
|
// that on the microtask so a release that lands first wins the race.
|
|
Promise.resolve().then(() => { if (!sentinel.released) spy.held = true; });
|
|
return Promise.resolve(sentinel);
|
|
},
|
|
},
|
|
});
|
|
};
|
|
|
|
test.beforeEach(async ({ page }) => {
|
|
await page.addInitScript(installWakeLockSpy);
|
|
await page.goto('/');
|
|
await page.waitForSelector('.screen.active', { timeout: 10000 });
|
|
await page.waitForFunction(() => typeof (window as any).feedBack?.emit === 'function');
|
|
});
|
|
|
|
test('acquires a single screen wake lock on play and releases on pause', async ({ page }) => {
|
|
// The audio 'play' listener emits song:play AND song:resume synchronously;
|
|
// only one 'screen' lock should be requested (the in-flight guard must hold
|
|
// before the first request resolves).
|
|
await page.evaluate(() => {
|
|
(window as any).feedBack.emit('song:play');
|
|
(window as any).feedBack.emit('song:resume');
|
|
});
|
|
await page.waitForFunction(() => (window as any).__wakeLockSpy.held === true);
|
|
expect(await page.evaluate(() => (window as any).__wakeLockSpy.requestCount)).toBe(1);
|
|
expect(await page.evaluate(() => (window as any).__wakeLockSpy.lastType)).toBe('screen');
|
|
|
|
await page.evaluate(() => (window as any).feedBack.emit('song:pause'));
|
|
await page.waitForFunction(() => (window as any).__wakeLockSpy.held === false);
|
|
});
|
|
|
|
test('song:ended and song:stop release the wake lock', async ({ page }) => {
|
|
await page.evaluate(() => (window as any).feedBack.emit('song:play'));
|
|
await page.waitForFunction(() => (window as any).__wakeLockSpy.held === true);
|
|
await page.evaluate(() => (window as any).feedBack.emit('song:ended'));
|
|
await page.waitForFunction(() => (window as any).__wakeLockSpy.held === false);
|
|
|
|
await page.evaluate(() => (window as any).feedBack.emit('song:play'));
|
|
await page.waitForFunction(() => (window as any).__wakeLockSpy.held === true);
|
|
await page.evaluate(() => (window as any).feedBack.emit('song:stop'));
|
|
await page.waitForFunction(() => (window as any).__wakeLockSpy.held === false);
|
|
});
|
|
|
|
test('fast play→pause before the request resolves leaves no stale lock', async ({ page }) => {
|
|
const before = await page.evaluate(() => (window as any).__wakeLockSpy.requestCount);
|
|
// Pause arrives while navigator.wakeLock.request is still in flight — the
|
|
// resolved sentinel must release itself instead of being held stale.
|
|
await page.evaluate(() => {
|
|
(window as any).feedBack.emit('song:play');
|
|
(window as any).feedBack.emit('song:pause');
|
|
});
|
|
await page.waitForTimeout(150);
|
|
expect(await page.evaluate(() => (window as any).__wakeLockSpy.held)).toBe(false);
|
|
expect(await page.evaluate((n) => (window as any).__wakeLockSpy.requestCount === n + 1, before)).toBe(true);
|
|
expect(await page.evaluate(() => (window as any).__wakeLockSpy.lastSentinel.released)).toBe(true);
|
|
});
|
|
|
|
test('re-acquires the wake lock when the UA releases it while still playing', async ({ page }) => {
|
|
await page.evaluate(() => (window as any).feedBack.emit('song:play'));
|
|
await page.waitForFunction(() => (window as any).__wakeLockSpy.held === true);
|
|
const before = await page.evaluate(() => (window as any).__wakeLockSpy.requestCount);
|
|
|
|
// Simulate the UA releasing the lock (power policy / page hide) while
|
|
// playback continues; the release handler re-acquires when still visible.
|
|
await page.evaluate(() => {
|
|
(window as any).feedBack.isPlaying = true;
|
|
(window as any).__wakeLockSpy.lastSentinel.release();
|
|
});
|
|
await page.waitForFunction((n) => (window as any).__wakeLockSpy.requestCount === n + 1 && (window as any).__wakeLockSpy.held === true, before);
|
|
|
|
// After a real pause there must be no further re-acquire churn.
|
|
await page.evaluate(() => (window as any).feedBack.emit('song:pause'));
|
|
await page.waitForFunction(() => (window as any).__wakeLockSpy.held === false);
|
|
const settled = await page.evaluate(() => (window as any).__wakeLockSpy.requestCount);
|
|
await page.waitForTimeout(150);
|
|
expect(await page.evaluate(() => (window as any).__wakeLockSpy.requestCount)).toBe(settled);
|
|
});
|
|
|
|
test('drives the feedBack-desktop native power bridge, deduped and visibility-gated', async ({ page }) => {
|
|
// In the packaged Electron app navigator.wakeLock is unreliable, so the
|
|
// helper also drives window.feedBackDesktop.power.setScreenAwake — to
|
|
// exactly (wanted && visible), emitting only on change. Inject a spy bridge
|
|
// before app.js runs and assert it tracks playback without duplicate starts.
|
|
await page.addInitScript(() => {
|
|
(window as any).__bridgeCalls = [];
|
|
(window as any).feedBackDesktop = {
|
|
power: { setScreenAwake: (keep: boolean) => (window as any).__bridgeCalls.push(keep) },
|
|
};
|
|
});
|
|
await page.reload();
|
|
await page.waitForSelector('.screen.active', { timeout: 10000 });
|
|
await page.waitForFunction(() => typeof (window as any).feedBack?.emit === 'function');
|
|
|
|
// song:play + song:resume fire together but must produce a single `true`.
|
|
await page.evaluate(() => {
|
|
(window as any).feedBack.emit('song:play');
|
|
(window as any).feedBack.emit('song:resume');
|
|
});
|
|
await page.waitForFunction(() => (window as any).__bridgeCalls.filter((x: boolean) => x === true).length === 1);
|
|
await page.evaluate(() => (window as any).feedBack.emit('song:pause'));
|
|
await page.waitForFunction(() => (window as any).__bridgeCalls.filter((x: boolean) => x === false).length === 1);
|
|
|
|
// Hidden while playing → bridge OFF (a minimized window mustn't keep the
|
|
// whole display awake); restoring visibility while playing turns it back ON.
|
|
await page.evaluate(() => (window as any).feedBack.emit('song:play'));
|
|
await page.waitForFunction(() => (window as any).__bridgeCalls[(window as any).__bridgeCalls.length - 1] === true);
|
|
await page.evaluate(() => {
|
|
Object.defineProperty(document, 'visibilityState', { configurable: true, get: () => 'hidden' });
|
|
document.dispatchEvent(new Event('visibilitychange'));
|
|
});
|
|
await page.waitForFunction(() => (window as any).__bridgeCalls[(window as any).__bridgeCalls.length - 1] === false);
|
|
await page.evaluate(() => {
|
|
Object.defineProperty(document, 'visibilityState', { configurable: true, get: () => 'visible' });
|
|
document.dispatchEvent(new Event('visibilitychange'));
|
|
});
|
|
await page.waitForFunction(() => (window as any).__bridgeCalls[(window as any).__bridgeCalls.length - 1] === true);
|
|
});
|