mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-21 20:31:21 +00:00
73 bare `highway.x` references -> `window.highway.x`, across app.js and 10 other files. Provably a NO-OP today. It is the precondition for flipping highway.js to a module. ━━━ WHY THIS HAS TO LAND FIRST ━━━ highway.js is a CLASSIC script. Its top-level `const highway = createHighway()` therefore creates a GLOBAL LEXICAL BINDING — visible as a bare name to every other classic script AND to every ES module. 73 call sites quietly rely on that. The moment highway.js becomes a module, that binding is gone. `const` in a module is module-scoped, not global. Every one of those 73 sites becomes a ReferenceError, and the flip is impossible until they say what they mean. `window.highway = highway` is already set, to the same object, on the same line. So this is an identity rewrite — verified in the browser below. ━━━ THE REWRITE BIT ME THREE TIMES. REGEX IS NOT ENOUGH FOR THIS. ━━━ 1. A SHADOWED LOCAL. capabilities/note-detection.js does `const highway = window.highway`. Its 9 bare uses are LOCAL and already correct; a blind rewrite would have emitted `const window.highway = window.highway`. Excluded. 2. HALF-CONVERTED GUARDS — the dangerous one. Six sites read `typeof highway !== 'undefined' && highway && typeof highway.setTime === 'function'`. The regex converted the CONSEQUENT and left the TEST, which is WORSE than not touching them: after the flip `typeof highway` is 'undefined', so each guard is PERMANENTLY FALSE and the code behind it silently never runs. transport.js's was the seek->setTime sync: the chart clock would have quietly desynced after every seek, with nothing failing. All six now test window.highway. 3. TWO MORE BARE REFERENCES, found by Codex [P2] and confirmed by an AST scan: app.js:3114 and :3176 use `highway && typeof window.highway.getSections === 'function'`. My grep searched for `typeof highway`, not `highway &&`. After the flip these throw, the catch swallows it, and the editor silently falls back to a ±4s edit window and arrangement 0. Regex missed a shadow, a half-conversion, and two bare reads. The final check is an AST pass that resolves scopes and reports every `highway` identifier not bound locally. It now reports ZERO. VERIFIED. A/B against origin/main in two browsers, 15 probes, IDENTICAL, zero page errors: window.highway is the same object as the bare global, the whole API surface resolves, a real song plays, the chart clock advances, getPerf().drawMs > 0 — and `seek syncs chart` passes, which is the exact guard I nearly broke in (2). node 1045, pytest 2416, ESLint 0, Codex 0. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
158 lines
7.7 KiB
JavaScript
158 lines
7.7 KiB
JavaScript
// Resume last session — the snapshot taken when you leave a song, and the pill that
|
|
// offers it back.
|
|
//
|
|
// The fifth slice out of app.js's strongly-connected core. Small and self-contained:
|
|
// ONE hook (playSong) plus a currentFilename getter.
|
|
//
|
|
// The armed resume request itself lives on the shared container as S.pendingResume,
|
|
// not here, because app.js WRITES it — playSong({ resume }) arms it and the song:ready
|
|
// listener consumes it — while this module reads it. An imported binding is read-only,
|
|
// so shared mutable state has to live on the container. Same reason isPlaying does.
|
|
//
|
|
// See ./host.js: reading an unwired hook THROWS, and tests/js/host_contract.test.js
|
|
// fails CI if the hooks used here and the hooks app.js wires ever drift apart.
|
|
import { host } from './host.js';
|
|
import { _curPlaybackSpeed } from './player-controls.js';
|
|
import { S } from './player-state.js';
|
|
|
|
// ── Resume last session ────────────────────────────────────────────────────
|
|
// Leaving a song snapshots where you were — song, arrangement, position, and
|
|
// speed — so an exit (especially an accidental one, now that Escape reliably
|
|
// leaves regardless of focus) is recoverable instead of restarting from bar 1.
|
|
// The snapshot is offered back through a non-blocking "Resume" pill; it never
|
|
// gates, blocks, or auto-acts. Cleared on natural song-end and once consumed.
|
|
// (This is the player-session slice; the broader nav/state-resume work — e.g.
|
|
// returning to a song after wandering into Settings → Tone Builder — is a
|
|
// separate, larger track.)
|
|
const _RESUME_KEY = 'feedBack.resumeSession';
|
|
const _RESUME_MAX_AGE_MS = 24 * 60 * 60 * 1000; // a day-old snapshot is stale
|
|
const _RESUME_MIN_POSITION_S = 3; // ignore barely-started songs
|
|
const _RESUME_END_GUARD_S = 5; // ignore basically-finished songs
|
|
let _resumePillDismissed = false; // per-session: user waved off the current snapshot
|
|
|
|
// Snapshot the live session. Called from showScreen()'s teardown before
|
|
// window.highway.stop()/audio unload, while getSongInfo() + position are still valid.
|
|
export function _snapshotResumeSession(position) {
|
|
try {
|
|
if (!host.currentFilename()) return;
|
|
const si = (window.highway && typeof window.highway.getSongInfo === 'function')
|
|
? (window.highway.getSongInfo() || {}) : {};
|
|
const dur = Number(si.duration) || 0;
|
|
const pos = Number(position) || 0;
|
|
// Only worth resuming a song you were genuinely mid-way through — not a
|
|
// glance at the first seconds, and not one that already basically ended.
|
|
if (pos < _RESUME_MIN_POSITION_S) { _clearResumeSession(); return; }
|
|
if (dur && pos > dur - _RESUME_END_GUARD_S) { _clearResumeSession(); return; }
|
|
const snap = {
|
|
f: host.currentFilename(),
|
|
a: (typeof si.arrangement_index === 'number' && si.arrangement_index >= 0)
|
|
? si.arrangement_index : undefined,
|
|
t: pos,
|
|
sp: _curPlaybackSpeed(),
|
|
title: si.title || '',
|
|
artist: si.artist || '',
|
|
ts: Date.now(),
|
|
};
|
|
localStorage.setItem(_RESUME_KEY, JSON.stringify(snap));
|
|
// A fresh snapshot earns one offer — undo any earlier dismissal.
|
|
_resumePillDismissed = false;
|
|
} catch (_) { /* storage unavailable — resume is best-effort */ }
|
|
}
|
|
|
|
export function _readResumeSession() {
|
|
try {
|
|
const raw = localStorage.getItem(_RESUME_KEY);
|
|
if (!raw) return null;
|
|
const snap = JSON.parse(raw);
|
|
if (!snap || !snap.f || !(Number(snap.t) > 0)) return null;
|
|
if (!snap.ts || Date.now() - snap.ts > _RESUME_MAX_AGE_MS) { _clearResumeSession(); return null; }
|
|
return snap;
|
|
} catch (_) { return null; }
|
|
}
|
|
|
|
export function _clearResumeSession() {
|
|
try { localStorage.removeItem(_RESUME_KEY); } catch (_) {}
|
|
}
|
|
|
|
// Re-enter the snapshotted song and restore arrangement + position + speed.
|
|
export async function resumeLastSession() {
|
|
const snap = _readResumeSession();
|
|
if (!snap) { _hideResumePill(); return false; }
|
|
_hideResumePill();
|
|
try {
|
|
await host.playSong(snap.f, snap.a, {
|
|
resume: { position: Number(snap.t) || 0, speed: Number(snap.sp) || 1 },
|
|
});
|
|
} catch (err) {
|
|
// A transient load/connect failure must not strand the user: keep the
|
|
// snapshot so the pill can re-offer it on the next non-player screen,
|
|
// rather than consuming the only copy before the song actually loaded.
|
|
console.warn('[app] resume failed to load; keeping snapshot:', err);
|
|
S.pendingResume = null;
|
|
return false;
|
|
}
|
|
_clearResumeSession(); // consumed only after a successful load
|
|
return true;
|
|
}
|
|
|
|
// ── Resume pill (non-blocking "continue where you left off") ────────────────
|
|
// Self-contained, inline-styled, body-appended so it works identically in the
|
|
// classic (v2) and v3 shells with no Tailwind rebuild. It only ever appears off
|
|
// the player screen, never blocks, and a dismiss forgets the current snapshot
|
|
// for the session.
|
|
export function _hideResumePill() {
|
|
const el = document.getElementById('fb-resume-pill');
|
|
if (el) el.remove();
|
|
}
|
|
|
|
export function _maybeShowResumePill() {
|
|
const active = document.querySelector('.screen.active');
|
|
if (active && active.id === 'player') { _hideResumePill(); return; }
|
|
if (_resumePillDismissed) return;
|
|
const snap = _readResumeSession();
|
|
if (!snap) { _hideResumePill(); return; }
|
|
if (document.getElementById('fb-resume-pill')) return; // already shown
|
|
|
|
const label = (snap.title || decodeURIComponent(snap.f || 'your last song')).toString();
|
|
const pill = document.createElement('div');
|
|
pill.id = 'fb-resume-pill';
|
|
pill.setAttribute('role', 'status');
|
|
pill.style.cssText = [
|
|
'position:fixed', 'left:16px', 'bottom:16px', 'z-index:120',
|
|
'display:flex', 'align-items:center', 'gap:10px',
|
|
'max-width:min(90vw,360px)', 'padding:10px 12px',
|
|
'background:rgba(17,24,39,0.96)', 'color:#e5e7eb',
|
|
'border:1px solid rgba(148,163,184,0.25)', 'border-radius:10px',
|
|
'box-shadow:0 6px 24px rgba(0,0,0,0.4)',
|
|
'font:13px/1.3 system-ui,-apple-system,"Segoe UI",Roboto,sans-serif',
|
|
].join(';');
|
|
|
|
const text = document.createElement('div');
|
|
text.style.cssText = 'flex:1;min-width:0';
|
|
const t1 = document.createElement('div');
|
|
t1.textContent = 'Resume practice';
|
|
t1.style.cssText = 'font-weight:600;color:#fff';
|
|
const t2 = document.createElement('div');
|
|
t2.textContent = label;
|
|
t2.style.cssText = 'opacity:0.7;white-space:nowrap;overflow:hidden;text-overflow:ellipsis';
|
|
text.appendChild(t1); text.appendChild(t2);
|
|
|
|
const resumeBtn = document.createElement('button');
|
|
resumeBtn.type = 'button';
|
|
resumeBtn.textContent = 'Resume ▸';
|
|
resumeBtn.style.cssText = 'flex:none;padding:6px 10px;border:0;border-radius:7px;background:#4080e0;color:#fff;font-weight:600;cursor:pointer';
|
|
resumeBtn.addEventListener('click', () => { resumeLastSession(); });
|
|
|
|
const dismissBtn = document.createElement('button');
|
|
dismissBtn.type = 'button';
|
|
dismissBtn.setAttribute('aria-label', 'Dismiss');
|
|
dismissBtn.textContent = '✕';
|
|
dismissBtn.style.cssText = 'flex:none;padding:4px 6px;border:0;border-radius:7px;background:transparent;color:#9ca3af;cursor:pointer;font-size:14px';
|
|
dismissBtn.addEventListener('click', () => { _resumePillDismissed = true; _hideResumePill(); });
|
|
|
|
pill.appendChild(text);
|
|
pill.appendChild(resumeBtn);
|
|
pill.appendChild(dismissBtn);
|
|
(document.body || document.documentElement).appendChild(pill);
|
|
}
|