feedBack/.github/workflows/sync-version.yml
Bret Mogilefsky af2949677a
rename: slopsmith → feedBack, byron → got-feedBack (#537)
* Update GitHub repo references from feedback* to feedBack*

* rename: slopsmith -> feedBack, byron -> got-feedBack

Renames across the entire codebase:
- slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack
- byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack
- /home/byron/ -> /opt/got-feedBack/
- byron@ougsoft.com -> hi@got-feedBack.org
- github.com/byrongamatos/ -> github.com/got-feedback/
- com.byron. -> com.got-feedback.
- SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback
- Protocol/storage strings migrated with read-old/write-new pattern
- window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias

Refs: #rename-slopsmith

* rename: complete regen against current main + fix backward-compat alias

Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of
current main (3 commits had landed since the branch: #572/#554/#574),
resolving the four content conflicts in favour of main's newer content
(autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge).

Completion fixes on top of the mechanical rename:
- Re-apply rename to post-branch content the original rename never saw:
  window.slopsmith(.Tour) consumers in lessons.js / notifications.js /
  onboarding-tour.js, and the matching JS + python tests (autoplay_exit,
  progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env
  vars now match server.py (which reads FEEDBACK_SYNC_STARTUP /
  FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real
  path again.
- Restore the window.slopsmith backward-compat alias dropped during conflict
  resolution, and move the bus aliases to AFTER the _feedBackExisting merge
  block so they reference the fully-assembled object (also fixes the
  loop_api.test.js API-surface regex, which the original PR latently broke).
- Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR)
  and gitignore it.
- Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped
  source labels.

Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669
passed / 1683 collected with 0 import errors; zero residual slopsmith/byron
except the two intentional window.slopsmith aliases.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* rename: implement advertised backward-compat + prune dead community plugins

Address gaps where PR #537's "Backward compatibility" section was advertised
but not implemented, and clean up the community plugin list.

Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured):
- New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py
  (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and
  tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI /
  SLOPSMITH_PLUGINS_DIR / etc. deployments keep working.
- Fix the rename collapsing plugins/__init__.py and minigames/routes.py from
  `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant
  `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost).

Storage (app.js update-channel):
- Read feedBack-update-channel, fall back to legacy slopsmith-update-channel,
  and clear the legacy key on write — so a user's update-channel preference
  survives the rename instead of resetting to "stable".

Community plugin list (README): the rename rewrote third-party repo URLs we
don't own. Probed every one; their owners never renamed, so:
- Restore the 13 live community plugins to their real slopsmith-* names.
- Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex
  tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle).
- Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory).

Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors,
rename-sensitive + startup suites green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: byrongamatos <xasiklas@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 11:03:01 +02:00

99 lines
3.5 KiB
YAML

name: Sync VERSION from desktop release
# Updates the VERSION file in this repo whenever feedBack-desktop
# publishes a new tagged release. feedBack-desktop's build.yml
# dispatches the `desktop-released` event at the end of a successful
# tag build (see docs in CLAUDE.md). A `workflow_dispatch` trigger is
# kept for manual testing / recovery.
#
# Related issue: #81.
on:
repository_dispatch:
types: [desktop-released]
workflow_dispatch:
inputs:
version:
description: 'Version to sync (vX.Y.Z or X.Y.Z)'
required: true
permissions:
contents: write
# Serialize runs so a rapid-fire pair of dispatches can't produce a
# non-fast-forward push race. Later runs queue behind earlier ones.
concurrency:
group: sync-version
cancel-in-progress: false
jobs:
sync:
runs-on: ubuntu-latest
steps:
# Always operate on main regardless of trigger branch. repository_dispatch
# already runs against the default branch, but workflow_dispatch can be
# launched from any branch in the UI — pinning ref: main keeps both
# paths committing to the same place.
- uses: actions/checkout@v4
with:
ref: main
- name: Determine target version
id: v
# Pass untrusted payloads through env vars instead of ${{ }}
# expansion inside the shell body — inline expansion makes the
# script vulnerable to command injection if a dispatch client
# sent a value like `$(...)` or a quote break.
env:
RAW_DISPATCH: ${{ github.event.client_payload.version }}
RAW_INPUT: ${{ inputs.version }}
EVENT_NAME: ${{ github.event_name }}
run: |
if [ "$EVENT_NAME" = "workflow_dispatch" ]; then
raw="$RAW_INPUT"
else
raw="$RAW_DISPATCH"
fi
# Accept both "vX.Y.Z" and "X.Y.Z" on the wire.
version="${raw#v}"
# Anchored semver guard — rejects payloads like
# "soundfonts-v1" (seen in the desktop release list) or any
# stray text. The emitter side validates too, but we don't
# trust cross-repo inputs.
if ! [[ "$version" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
echo "::error::Invalid version payload: '$raw'"
exit 1
fi
echo "version=$version" >> "$GITHUB_OUTPUT"
- name: Compare with current VERSION
id: cmp
env:
TARGET: ${{ steps.v.outputs.version }}
run: |
current=$(tr -d '[:space:]' < VERSION)
if [ "$current" = "$TARGET" ]; then
echo "No change (already at $current)."
echo "changed=false" >> "$GITHUB_OUTPUT"
else
echo "Bumping $current -> $TARGET."
echo "changed=true" >> "$GITHUB_OUTPUT"
echo "previous=$current" >> "$GITHUB_OUTPUT"
fi
- name: Commit and push
if: steps.cmp.outputs.changed == 'true'
env:
TARGET: ${{ steps.v.outputs.version }}
run: |
printf '%s\n' "$TARGET" > VERSION
git config user.name 'github-actions[bot]'
git config user.email 'github-actions[bot]@users.noreply.github.com'
git add VERSION
git commit -m "chore: sync VERSION to $TARGET (desktop release)"
# Explicit HEAD:main push — if workflow_dispatch was somehow
# launched with ref: main overridden in the UI, this still
# lands on main rather than pushing to whatever the tracking
# branch was.
git push origin HEAD:main