feedBack/tests/js/tuning_display.test.js
Byron Gamatos d47883c5e5
refactor(app): carve the tuning-display helpers out of app.js (R3a) (#884)
static/js/tuning-display.js (228 lines) — bodies VERBATIM. app.js 9,838 → 9,650.
A LEAF: imports nothing.

Tuning NAME resolution (Drop D / Eb Standard / raw-offset fallback), bass
detection, effective string count, and the target FREQUENCIES + note names the
tuner checks against. Pure functions over a small MIDI/note-name table; the 3
_TUNING_* tables are read nowhere else and move in.

NOT A SLICE — a node-level extract. The span 2309-2535 INTERLEAVES the functions
with the `window.*` / `window.feedBack.*` assignments that publish them, and one
of those is `window.feedBack = window.feedBack || {}` — the BUS BOOTSTRAP, not
tuning code at all. Every ExpressionStatement stays exactly where it was; only the
16 functions and 3 tables move. app.js re-exposes the imported bindings from the
same lines, so the public surface and its ordering are untouched (constitution II
names window.feedBack).

  app.js -> { plugin-loader, viz, diagnostics-export, dom, highway-colors,
              tuning-display }

HARNESSES — 4 broke, and 3 of them broke in the SAME informative way: they sliced
app.js from `function isBassArrangement(` UP TO the marker
`window.feedBack.parseRawTuningOffsets = parseRawTuningOffsets;` — an end-marker
that (correctly) stayed behind in app.js. The module is now nothing BUT the tuning
helpers, so there is no block to slice: they read it whole and strip `export ` so
the vm sandbox still evaluates it as a script.
  tuner_auto_open is SPLIT — its autoplay-gate test still reads app.js, so it keeps
  APP_JS and gains TUNING_JS. Retargeting its path wholesale (my first attempt)
  silently pointed the autoplay test at the wrong file.

VERIFIED BY DRIVING THE CONTRACT. A/B against origin/main in two browsers, through
the real window surface: displayTuningName -> "E Standard" / "Drop D" /
"Eb Standard", parseRawTuningOffsets('-2,0,0,0,0,0') -> [-2,0,0,0,0,0],
isBassArrangement, effectiveStringCount, displayTuningTargets, and
window.feedBack.displayTuningName / .songTuningContext — IDENTICAL on both, zero
console/page errors either side.

pytest 2396, node 1038/1038, ESLint 0, tailwind-fresh clean, Codex 0.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-11 19:37:44 +02:00

111 lines
4.6 KiB
JavaScript

'use strict';
const { test } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const path = require('node:path');
const vm = require('node:vm');
// The tuning-display helpers were carved out of app.js into their own module (R3a).
const APP_JS = path.join(__dirname, '..', '..', 'static', 'js', 'tuning-display.js');
const HIGHWAY_JS = path.join(__dirname, '..', '..', 'static', 'highway.js');
const V3_HTML = path.join(__dirname, '..', '..', 'static', 'v3', 'index.html');
function extractBlock(src, startMarker) {
const start = src.indexOf(startMarker);
if (start === -1) throw new Error(`extractBlock: '${startMarker}' not found`);
const openBrace = src.indexOf('{', start);
let depth = 1;
let i = openBrace + 1;
while (i < src.length && depth > 0) {
const ch = src[i];
if (ch === '{') depth++;
else if (ch === '}') depth--;
i++;
}
if (depth !== 0) throw new Error(`extractBlock: unbalanced braces after '${startMarker}'`);
return src.slice(start, i);
}
function loadTuningDisplayHelpers() {
const src = fs.readFileSync(APP_JS, 'utf8');
const block = [
extractBlock(src, 'function _looksLikeRawTuningOffsets('),
extractBlock(src, 'function _tuningNameFromOffsets('),
extractBlock(src, 'function parseRawTuningOffsets('),
extractBlock(src, 'function displayTuningName('),
].join('\n');
const sandbox = { window: { feedBack: {} }, exports: {} };
vm.createContext(sandbox);
vm.runInContext(block + '\nexports.displayTuningName = displayTuningName;', sandbox);
return sandbox.exports;
}
const TUNER_UI_JS = path.join(__dirname, '..', '..', 'plugins', 'tuner', 'utils', 'ui.js');
const { displayTuningName } = loadTuningDisplayHelpers();
test('displayTuningName passes through known labels', () => {
assert.equal(displayTuningName('E Standard'), 'E Standard');
assert.equal(displayTuningName('Drop D'), 'Drop D');
assert.equal(displayTuningName('Eb Standard'), 'Eb Standard');
});
test('displayTuningName sanitizes raw offset strings to Custom Tuning', () => {
assert.equal(displayTuningName('-2000-2'), 'Custom Tuning');
assert.equal(displayTuningName('-2 0 0 0 -2'), 'Custom Tuning');
assert.equal(displayTuningName('-3,-1,0,1,2,3'), 'Custom Tuning');
});
test('displayTuningName names a known raw offset string (feedBack#867)', () => {
// Now that the API serves raw offsets, a known tuning passed as a raw
// string must resolve to its real name, not collapse to Custom Tuning.
assert.equal(displayTuningName('-1 -1 -1 -1 -1 -1'), 'Eb Standard');
assert.equal(displayTuningName('-2 0 0 0 0 0'), 'Drop D');
assert.equal(displayTuningName('-2,0,0,0,-2,0'), 'DADGAD');
// Genuinely custom offsets still read Custom Tuning.
assert.equal(displayTuningName('-2 0 0 0 -2 1'), 'Custom Tuning');
});
test('displayTuningName recognizes 4/5-string uniform standard (feedBack#867)', () => {
// A normal 4-string bass [0,0,0,0] must not fall through to Custom Tuning.
assert.equal(displayTuningName(null, [0, 0, 0, 0]), 'E Standard');
assert.equal(displayTuningName(null, [-2, -2, -2, -2]), 'D Standard');
assert.equal(displayTuningName('0 0 0 0'), 'E Standard');
});
test('displayTuningName derives readable names from offsets when value missing', () => {
assert.equal(displayTuningName(null, [0, 0, 0, 0, 0, 0]), 'E Standard');
assert.equal(displayTuningName('', [0, 0, 0, 0, 0, 0]), 'E Standard');
assert.equal(displayTuningName(undefined, [-2, 0, 0, 0, 0, 0]), 'Drop D');
});
test('displayTuningName returns Custom Tuning for unknown offsets', () => {
assert.equal(displayTuningName(null, [-2, 0, 0, 0, -2]), 'Custom Tuning');
assert.equal(displayTuningName('-2 0 0 0 -2', [-2, 0, 0, 0, -2]), 'Custom Tuning');
});
test('displayTuningName returns empty when nothing usable', () => {
assert.equal(displayTuningName(''), '');
assert.equal(displayTuningName(null), '');
assert.equal(displayTuningName('Unknown'), '');
assert.equal(displayTuningName(null, []), '');
});
test('V3 index.html defines hud-tuning', () => {
const html = fs.readFileSync(V3_HTML, 'utf8');
assert.match(html, /id="hud-tuning"/);
});
test('highway.js updates hud-tuning from song_info tuning offsets', () => {
const src = fs.readFileSync(HIGHWAY_JS, 'utf8');
assert.match(src, /getElementById\('hud-tuning'\)/);
assert.match(src, /displayTuningName\(null, msg\.tuning\)/);
assert.match(src, /Tuning: /);
});
test('V3 index.html defines hud-tuning-targets', () => {
const html = fs.readFileSync(V3_HTML, 'utf8');
assert.match(html, /id="hud-tuning-targets"/);
});