mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-22 04:41:23 +00:00
36 declarations + the 4 autoplay/auto-exit gate statements. 359 lines. app.js 3,772 -> 3,242. Bodies VERBATIM. ━━━ THIS WAS "THE UNCUTTABLE HEART", AND IT IS 359 LINES ━━━ At the start of this epic, seeding a dependency closure from count-in, from loops, from section-practice, or from the JUCE seek shim all returned the SAME 178-function, 3,360-line set. playSong and showScreen called each other; everything called them; nothing could be cut anywhere. The conclusion — correct at the time — was that NO closure-based carve could touch it at any seed, and the answer was a host seam. That was true THEN. Every slice taken out since (transport, loops, count-in, section-practice, the library, the edit modal, settings) removed edges, and the strongly-connected component DISSOLVED. This closure is 36 declarations with an interface width of FOUR. The lesson is not that the seam was wrong — the seam is what MADE this possible, by letting the carves proceed against a cyclic core instead of stalling on it. The lesson is to RE-MEASURE. An SCC is a fact about a graph at a moment, not a property of the code. ━━━ THE BUG NO SCAN COULD SEE, AND THE A/B DID ━━━ First cut passed every gate — no-undef clean, no-cycle clean, 1045/1045, pytest green — and THREW IN THE BROWSER: "Assignment to constant variable." window.feedBack.holdAutoplay / holdAutoExit and their two event handlers are TOP-LEVEL STATEMENTS, not declarations. They WRITE this cluster's state (_autoplayHeld, _autoExitTimer, …), and an imported binding is READ-ONLY — so left behind in app.js, every one threw the instant the module existed. A dependency scan that walks DECLARATIONS cannot see them. Mine didn't. This is the same blind spot that nearly shipped a dead library A-Z rail (#896): app.js keeps its public API in top-level statements, and a call-graph is blind to every one of them. The extractor now finds them by construction — any top-level statement that WRITES a moved binding comes with the carve — and the gate statements live beside the machinery they drive, which is where they belonged anyway. ━━━ ZERO OUTSIDE WRITES, BY MOVING THE BOUNDARY RATHER THAN BUILDING MACHINERY ━━━ The autoplay scalars and the wake-lock state were written from outside the cluster, which would have forced a setter or a state container. But the writers — _releaseAutoplay, _acquireWakeLock — plainly belong here. Pulling them in left ZERO outside writes, so every export is a plain import. Same move as settings (#920): measure the writers before you reach for a container. VERIFIED. A/B against origin/main in two browsers, IDENTICAL, zero page errors — including the autoplay gate driven end to end: a plugin HOLDS autoplay, the song loads but does not start, the RELEASE fires it, and a stale release is a no-op. That is the exact machinery that was throwing. node 1045, pytest 2425, ESLint 0 (no-cycle clean), host contract 2/2, Codex 0. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
219 lines
8.4 KiB
JavaScript
219 lines
8.4 KiB
JavaScript
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const vm = require('node:vm');
|
|
|
|
// R3d: playSong moved to static/js/session.js with showScreen and closeCurrentSong.
|
|
const APP_JS = path.join(__dirname, '..', '..', 'static', 'js', 'session.js');
|
|
// The speed controls were carved out into static/js/player-controls.js (R3a); playSong,
|
|
// which resets them on a new song, stayed in app.js. This test spans both.
|
|
const CONTROLS_JS = path.join(__dirname, '..', '..', 'static', 'js', 'player-controls.js');
|
|
|
|
function extractFunction(src, signature) {
|
|
const start = src.indexOf(signature);
|
|
if (start === -1) throw new Error(`extractFunction: '${signature}' not found in app.js`);
|
|
let scan = start + signature.length;
|
|
if (src[scan] === '(') {
|
|
let parenDepth = 1;
|
|
scan++;
|
|
while (scan < src.length && parenDepth > 0) {
|
|
const ch = src[scan];
|
|
if (ch === '(') parenDepth++;
|
|
else if (ch === ')') parenDepth--;
|
|
scan++;
|
|
}
|
|
}
|
|
const openBrace = src.indexOf('{', scan);
|
|
let depth = 1;
|
|
let i = openBrace + 1;
|
|
while (i < src.length && depth > 0) {
|
|
const ch = src[i];
|
|
if (ch === '{') depth++;
|
|
else if (ch === '}') depth--;
|
|
i++;
|
|
}
|
|
if (depth !== 0) throw new Error(`extractFunction: unbalanced braces after '${signature}'`);
|
|
return src.slice(start, i);
|
|
}
|
|
|
|
function buildSandbox({ juceMode = false } = {}) {
|
|
const elements = new Map();
|
|
const makeElement = (id) => ({
|
|
id,
|
|
value: id === 'speed-slider' ? 135 : '',
|
|
textContent: id === 'speed-label' ? '1.35x' : '',
|
|
style: {},
|
|
});
|
|
for (const id of ['speed-slider', 'speed-label', 'quality-select', 'highway']) {
|
|
elements.set(id, makeElement(id));
|
|
}
|
|
elements.set('speed-presets', {
|
|
id: 'speed-presets',
|
|
querySelectorAll() { return []; },
|
|
});
|
|
const backingCalls = [];
|
|
const sliderInputs = [];
|
|
const audio = {
|
|
playbackRate: 1.35,
|
|
pause() {},
|
|
};
|
|
const jucePlayer = {
|
|
_speed: 1.35,
|
|
setRate(rate) { this._speed = rate; },
|
|
stop() { return Promise.resolve(); },
|
|
};
|
|
const sandbox = {
|
|
console: { log() {}, warn() {}, error() {} },
|
|
audio,
|
|
jucePlayer,
|
|
highway: {
|
|
stop() {},
|
|
init() {},
|
|
connect(url) { sandbox.__connectedUrl = url; },
|
|
getRenderScale: () => 1,
|
|
},
|
|
window: {
|
|
_juceMode: juceMode,
|
|
_juceAudioUrl: juceMode ? '/audio/old-song.ogg' : null,
|
|
_currentSongAudio: { url: '/audio/old-song.ogg' },
|
|
_clearJuceRerouteMemo() {},
|
|
feedBack: {
|
|
isPlaying: true,
|
|
emit() {},
|
|
},
|
|
feedBackDesktop: {
|
|
audio: {
|
|
setBackingSpeed(rate) {
|
|
backingCalls.push(['setBackingSpeed', rate]);
|
|
return Promise.resolve();
|
|
},
|
|
setBackingPreservePitch(value) {
|
|
backingCalls.push(['setBackingPreservePitch', value]);
|
|
return Promise.resolve();
|
|
},
|
|
},
|
|
},
|
|
},
|
|
document: {
|
|
getElementById(id) {
|
|
if (!elements.has(id)) elements.set(id, makeElement(id));
|
|
return elements.get(id);
|
|
},
|
|
querySelector(selector) {
|
|
if (selector === '.screen.active') return { id: 'home' };
|
|
return null;
|
|
},
|
|
},
|
|
location: {
|
|
protocol: 'http:',
|
|
host: 'localhost:9999',
|
|
},
|
|
URLSearchParams,
|
|
setTimeout(fn) { fn(); return 0; },
|
|
clearTimeout() {},
|
|
Promise,
|
|
decodeURIComponent,
|
|
__elements: elements,
|
|
__backingCalls: backingCalls,
|
|
__sliderInputs: sliderInputs,
|
|
};
|
|
sandbox.window.jucePlayer = jucePlayer;
|
|
sandbox.handleSliderInput = (el) => {
|
|
if (el) sliderInputs.push(el.id);
|
|
};
|
|
vm.createContext(sandbox);
|
|
// highway.js is loaded as a CLASSIC script today, so its top-level `const highway`
|
|
// creates a global lexical binding that app.js and the modules could reach as a bare
|
|
// name. That binding disappears the moment highway.js becomes a module (R3c), so every
|
|
// consumer now says `window.highway` — the same object, explicitly. Mirror it here.
|
|
if (sandbox.window && sandbox.highway) sandbox.window.highway = sandbox.highway;
|
|
return sandbox;
|
|
}
|
|
|
|
function extractConstLine(src, name) {
|
|
const match = src.match(new RegExp(`const ${name} = [^;]+;`));
|
|
if (!match) throw new Error(`extractConstLine: '${name}' not found in app.js`);
|
|
return match[0];
|
|
}
|
|
|
|
function loadPlaySong(sandbox) {
|
|
const src = fs.readFileSync(APP_JS, 'utf8');
|
|
// the module is ESM; the vm sandbox evaluates plain script text
|
|
const controls = fs.readFileSync(CONTROLS_JS, 'utf8').replace(/^export /gm, '');
|
|
const resetHelper = controls.includes('function _resetPlaybackSpeedForNewSong')
|
|
? extractFunction(controls, 'function _resetPlaybackSpeedForNewSong')
|
|
: '';
|
|
const speedPresetHelpers = controls.includes('function _updateSpeedPresetButtons')
|
|
? `
|
|
${extractConstLine(controls, 'SPEED_PRESET_PCTS')}
|
|
${extractConstLine(controls, 'SPEED_SNAP_THRESHOLD')}
|
|
${extractFunction(controls, 'function _speedPresetPctFromActive')}
|
|
${extractFunction(controls, 'function _updateSpeedPresetButtons')}
|
|
`
|
|
: '';
|
|
const code = `
|
|
var artAbortController = null;
|
|
// isPlaying moved onto the shared player-state container so a carved module can
|
|
// WRITE it (an imported binding is read-only). NB window.feedBack.isPlaying — the
|
|
// public mirror stubbed above — is a different thing and is unchanged.
|
|
var S = { isPlaying: true, lastAudioTime: 0 };
|
|
// The speed controls reach app.js through the host seam (static/js/host.js).
|
|
// Route it at the sandbox's EXISTING handleSliderInput spy — a fresh stub would
|
|
// swallow the call and the assertion below (which checks the slider was actually
|
|
// refreshed) would pass vacuously.
|
|
var host = { handleSliderInput: (el) => handleSliderInput(el) };
|
|
var currentFilename = null;
|
|
var _playerOriginScreen = null;
|
|
var _pendingAutostart = false;
|
|
function _clearAutoExit() {}
|
|
function _clearAutoplayHold() {}
|
|
function _resolvePlayerOrigin() { return 'home'; }
|
|
function _recordPlaybackBridge() {}
|
|
function _cancelCountIn() {}
|
|
function _resetJuceAudioShimChain() {}
|
|
function _resetAudioSeekState() {}
|
|
function setPlayButtonState() {}
|
|
function clearLoop() {}
|
|
function _resetSectionPracticeLog() {}
|
|
function _hideSectionPracticeBar() {}
|
|
function showScreen() {}
|
|
function _getArrangementNamingMode() { return 'default'; }
|
|
function _scheduleSectionPracticeRetries() {}
|
|
function loadSavedLoops() {}
|
|
function _songEventPayload() { return { time: 7, audioT: 7, chartT: 7, perfNow: 7 }; }
|
|
${extractFunction(controls, 'function setSpeed')}
|
|
${speedPresetHelpers}
|
|
${resetHelper}
|
|
${extractFunction(src, 'async function playSong')}
|
|
globalThis.__playSong = playSong;
|
|
`;
|
|
vm.runInContext(code, sandbox);
|
|
}
|
|
|
|
test('new song load resets the HTML audio rate, not only the visible speed controls', async () => {
|
|
const sandbox = buildSandbox();
|
|
loadPlaySong(sandbox);
|
|
|
|
await sandbox.__playSong('next-song.archive');
|
|
|
|
assert.equal(sandbox.__elements.get('speed-slider').value, 100);
|
|
assert.match(sandbox.__elements.get('speed-label').textContent, /^1\.0{1,2}x$/);
|
|
assert.equal(sandbox.audio.playbackRate, 1);
|
|
assert.deepEqual(sandbox.__sliderInputs, ['speed-slider']);
|
|
});
|
|
|
|
test('new song load resets the desktop backing rate when the API is available', async () => {
|
|
const sandbox = buildSandbox({ juceMode: true });
|
|
loadPlaySong(sandbox);
|
|
|
|
await sandbox.__playSong('next-song.archive');
|
|
await new Promise((resolve) => setImmediate(resolve));
|
|
|
|
assert.equal(sandbox.jucePlayer._speed, 1);
|
|
assert.deepEqual(sandbox.__backingCalls, [
|
|
['setBackingSpeed', 1],
|
|
['setBackingPreservePitch', true],
|
|
]);
|
|
});
|