mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-22 12:52:29 +00:00
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
122 lines
5.4 KiB
JavaScript
122 lines
5.4 KiB
JavaScript
// Contract tests for notifications.js: the fbNotify toast surface and the
|
|
// progression:* → toast wiring (period labels, celebratory vs subtle, path
|
|
// name lookup, rank-up-only guard).
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const vm = require('node:vm');
|
|
const { ROOT } = require('./capabilities_test_harness');
|
|
|
|
const SRC = fs.readFileSync(path.join(ROOT, 'static', 'v3', 'notifications.js'), 'utf8');
|
|
|
|
// Minimal DOM: enough for createElement/append/insertBefore/getElementById and
|
|
// the inline-style/innerHTML the toast sets.
|
|
function fakeDom() {
|
|
function mkEl(tag) {
|
|
return {
|
|
tagName: tag, id: '', className: '', innerHTML: '', style: {},
|
|
children: [], get firstChild() { return this.children[0] || null; },
|
|
appendChild(c) { this.children.push(c); c.parent = this; return c; },
|
|
insertBefore(c, ref) {
|
|
const i = ref ? this.children.indexOf(ref) : -1;
|
|
if (i < 0) this.children.push(c); else this.children.splice(i, 0, c);
|
|
c.parent = this; return c;
|
|
},
|
|
remove() { const p = this.parent; if (p) p.children = p.children.filter((x) => x !== this); },
|
|
addEventListener(type, fn) { (this._h || (this._h = {}))[type] = fn; },
|
|
_text() { return (this.innerHTML || '').replace(/<[^>]*>/g, ''); },
|
|
};
|
|
}
|
|
const body = mkEl('body');
|
|
const byId = (node, id) => {
|
|
if (node.id === id) return node;
|
|
for (const c of node.children) { const hit = byId(c, id); if (hit) return hit; }
|
|
return null;
|
|
};
|
|
return {
|
|
body,
|
|
createElement: mkEl,
|
|
getElementById: (id) => byId(body, id),
|
|
};
|
|
}
|
|
|
|
function load(progressionState) {
|
|
const handlers = {};
|
|
const sandbox = {
|
|
console,
|
|
setTimeout: () => 0, clearTimeout: () => {},
|
|
requestAnimationFrame: (fn) => fn(), // run animation callbacks synchronously
|
|
};
|
|
sandbox.window = sandbox;
|
|
sandbox.document = fakeDom();
|
|
// Deliver a CustomEvent-like wrapper ({detail}), exactly as the real bus
|
|
// does (capabilities.js: bus.on → addEventListener, fn gets a CustomEvent).
|
|
// Test call sites pass the raw payload; the handler must unwrap e.detail.
|
|
sandbox.window.feedBack = { on: (name, fn) => { handlers[name] = (payload) => fn({ detail: payload }); } };
|
|
sandbox.window.v3Progression = { get: () => progressionState };
|
|
vm.createContext(sandbox);
|
|
vm.runInContext(SRC, sandbox);
|
|
const stack = () => sandbox.document.getElementById('fb-notify-stack');
|
|
return { sandbox, handlers, stack };
|
|
}
|
|
|
|
test('fbNotify.show renders a card with the title and message', () => {
|
|
const { sandbox, stack } = load(null);
|
|
assert.equal(typeof sandbox.window.fbNotify.show, 'function');
|
|
sandbox.window.fbNotify.show({ title: 'Hello', message: 'World' });
|
|
const cards = stack().children;
|
|
assert.equal(cards.length, 1);
|
|
assert.match(cards[0]._text(), /Hello/);
|
|
assert.match(cards[0]._text(), /World/);
|
|
});
|
|
|
|
test('quest-completed makes a celebratory toast with the period label and reward', () => {
|
|
const { handlers, stack } = load(null);
|
|
handlers['progression:quest-completed']({ id: 'q1', title: 'Play 3 songs', period_type: 'weekly', reward_db: 200 });
|
|
const card = stack().children[0];
|
|
assert.match(card._text(), /Weekly Quest complete!/);
|
|
assert.match(card._text(), /Play 3 songs/);
|
|
assert.match(card._text(), /\+200 dB/);
|
|
});
|
|
|
|
test('quest-progressed makes a subtle toast showing N/M and the daily label', () => {
|
|
const { handlers, stack } = load(null);
|
|
handlers['progression:quest-progressed']({ id: 'q1', title: 'Play 3 songs', period_type: 'daily', count: 2, target: 3 });
|
|
assert.match(stack().children[0]._text(), /Daily Quest advanced/);
|
|
assert.match(stack().children[0]._text(), /2\/3/);
|
|
});
|
|
|
|
test('path-level-up resolves the path name from progression state', () => {
|
|
const { handlers, stack } = load({ paths: [{ id: 'guitar', name: 'Lead Guitar' }] });
|
|
handlers['progression:path-level-up']({ path_id: 'guitar', new_level: 4 });
|
|
assert.match(stack().children[0]._text(), /Lead Guitar — Level 4!/);
|
|
});
|
|
|
|
test('path-progressed shows path name and challenge count toward the next level', () => {
|
|
const { handlers, stack } = load(null);
|
|
handlers['progression:path-progressed']({ id: 'bass', name: 'Bass', completed: 2, required: 3, next_level: 2 });
|
|
assert.match(stack().children[0]._text(), /Bass progress/);
|
|
assert.match(stack().children[0]._text(), /2\/3 to Level 2/);
|
|
});
|
|
|
|
test('rank-changed toasts on a rank up but not a rank drop', () => {
|
|
const up = load(null);
|
|
up.handlers['progression:rank-changed']({ from: 2, to: 3 });
|
|
assert.equal(up.stack().children.length, 1);
|
|
assert.match(up.stack().children[0]._text(), /Mastery Rank 3!/);
|
|
|
|
const down = load(null);
|
|
down.handlers['progression:rank-changed']({ from: 3, to: 2 });
|
|
assert.equal(down.stack() ? down.stack().children.length : 0, 0); // no toast on a drop
|
|
});
|
|
|
|
test('newest toast is inserted on top of the stack', () => {
|
|
const { sandbox, stack } = load(null);
|
|
sandbox.window.fbNotify.show({ title: 'first' });
|
|
sandbox.window.fbNotify.show({ title: 'second' });
|
|
assert.match(stack().children[0]._text(), /second/);
|
|
assert.match(stack().children[1]._text(), /first/);
|
|
});
|