mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-22 12:52:29 +00:00
cb425ed48d
Six more findings from CodeRabbit on #928. Three are real bugs. 1. THE CHIP HID DOCKED PANES. `_onOpened` decided "did the pane take my element?" from `ownerDocument !== document`. That is true for a pane in a pop-out window — and false for a pane moved into the DOCK, which lives in this very document. So docking a pane stamped `.fb-pane-detached` (display:none !important) onto the panel the user was looking at, and put the stub next to it instead of at its home. The element cannot answer this question — `isConnected` is true in a pane window, `ownerDocument` is this one in the dock. Both were live bugs. Ask the manager, which knows exactly what it handed to the host: `panes.elementOf(id)`. That holds for every host, and for reconciling after the fact (detail == null), which is what a plugin rebuilding its panel mid-pop-out triggers. 2. `.fb-paned` FORCED `display: block !important`. A panel that is `display:flex` or `grid` would be silently re-laid-out while detached — the exact opposite of "placement only", and precisely the kind of surprise this feature exists to avoid. Removed. Making a hidden panel visible is a separate job, and it now belongs to the manager, which does it without touching the panel's display MODE: clear `hidden`, and clear an inline `display:none` if that is how the panel hides. 3. VISIBILITY IS NOW RESTORED. The hosts used to set `el.hidden = false` and never put it back, so the docs' "core only changes placement" was a lie and a panel's hidden state was quietly lost. The manager stashes both `hidden` and the inline `display` on open and restores them on dock: a panel that was closed when you opened its pane from the tray goes back to being closed; one that was open stays open. Plus: - The launcher rebuilt its whole list on every panes:opened/closed — including the one fired by clicking a button in that list — destroying the button under the user's finger and dropping focus to <body>. It now restores focus to the toggled pane's button. - `_copyStyles` cloned every stylesheet link, including the panes.css that pane.html already loads. Skip sheets the pane document already has. - Docs: the chip may route to the DOCK, not always a window (it goes through detach() → the host router). `header` precedence was documented backwards — an explicit `header` wins. And the visibility contract above is now written down rather than being a surprise. Signed-off-by: topkoa <topkoa@gmail.com>
194 lines
6.9 KiB
CSS
194 lines
6.9 KiB
CSS
/* fee[dB]ack — detachable panes.
|
|
*
|
|
* Hand-authored (not Tailwind-scanned) so a runtime-installed plugin gets the chip
|
|
* and the dock without shipping its own stylesheet — the same reason .fb-selectable
|
|
* is hand-authored in core CSS.
|
|
*
|
|
* Z-index: the dock is a child of <body>, so it is NOT on the ladder from
|
|
* docs/plugin-v3-ui.md (transport 20, rail 30, popovers 40) — those numbers live
|
|
* *inside* #player's stacking context, and #player itself is `position:fixed;
|
|
* z-index:100` covering the viewport. A dock below 100 is invisible on the one
|
|
* screen panes exist for. Body-level ladder: #player 100 < dock 110 < toasts 120
|
|
* < modals 200.
|
|
*/
|
|
|
|
/* ── The popped-out element ──────────────────────────────────────────────────
|
|
*
|
|
* The single most important rule in this file.
|
|
*
|
|
* A plugin's panel is almost always a fixed overlay pinned to a corner of the app:
|
|
* `position:fixed; top:72px; right:18px; width:288px; z-index:99999`, with a drop
|
|
* shadow and a max-height sized against the viewport. Inside a dock card, or alone
|
|
* in a 320px window, every one of those is wrong — it would float 72px down from
|
|
* the top of its own window, still 288px wide, still casting a shadow over nothing.
|
|
*
|
|
* So we neutralise PLACEMENT and nothing else. Colours, borders, radius, padding,
|
|
* fonts, the panel's own internal layout: all untouched, because the whole promise
|
|
* of this feature is that what you popped out is what you get. */
|
|
.fb-paned {
|
|
position: static !important;
|
|
inset: auto !important;
|
|
margin: 0 !important;
|
|
width: 100% !important;
|
|
max-width: none !important;
|
|
max-height: none !important;
|
|
z-index: auto !important;
|
|
box-shadow: none !important;
|
|
/* Deliberately NO `display` override. Forcing `display:block` would silently
|
|
re-lay-out a panel that is `display:flex` or `grid` — which is the opposite
|
|
of "placement only", and exactly the kind of surprise this feature exists to
|
|
avoid. Making a hidden panel visible is the manager's job (it clears the
|
|
element's `hidden`/inline `display:none` on open and restores them on dock),
|
|
and it does it without touching the panel's own display mode. */
|
|
}
|
|
|
|
/* ── The pop-out chip ────────────────────────────────────────────────────── */
|
|
|
|
.fb-pane-chip {
|
|
flex: 0 0 auto;
|
|
display: inline-flex;
|
|
align-items: center;
|
|
justify-content: center;
|
|
width: 1.5rem;
|
|
height: 1.5rem;
|
|
border: 1px solid rgba(51, 65, 85, .7);
|
|
border-radius: .4rem;
|
|
background: rgba(30, 41, 59, .8);
|
|
color: #94a3b8;
|
|
font-size: .8rem;
|
|
line-height: 1;
|
|
cursor: pointer;
|
|
transition: color .15s, border-color .15s, background .15s;
|
|
}
|
|
.fb-pane-chip:hover {
|
|
color: #e2e8f0;
|
|
border-color: #4080e0;
|
|
background: rgba(64, 128, 224, .18);
|
|
}
|
|
.fb-pane-chip:focus-visible { outline: 2px solid #4080e0; outline-offset: 1px; }
|
|
|
|
/* The panel, while its pane is popped out. A dedicated class rather than
|
|
.hidden/[hidden]: the panels we attach to toggle those themselves, and two owners
|
|
of one class is a bug waiting for a bad day. */
|
|
.fb-pane-detached { display: none !important; }
|
|
|
|
/* What the user sees in the panel's place. */
|
|
.fb-pane-stub {
|
|
display: inline-flex;
|
|
align-items: center;
|
|
gap: .4rem;
|
|
padding: .35rem .6rem;
|
|
border: 1px dashed rgba(64, 128, 224, .55);
|
|
border-radius: .5rem;
|
|
background: rgba(64, 128, 224, .08);
|
|
color: #93b4e8;
|
|
font-size: .72rem;
|
|
cursor: pointer;
|
|
transition: background .15s, border-color .15s;
|
|
}
|
|
.fb-pane-stub:hover { background: rgba(64, 128, 224, .18); border-color: #4080e0; }
|
|
.fb-pane-stub:focus-visible { outline: 2px solid #4080e0; outline-offset: 1px; }
|
|
.fb-pane-stub-glyph { font-size: .85rem; }
|
|
|
|
/* ── The dock ────────────────────────────────────────────────────────────── */
|
|
|
|
.fb-pane-dock {
|
|
position: fixed;
|
|
top: 4.5rem;
|
|
right: 1rem;
|
|
bottom: 1rem;
|
|
z-index: 110; /* above #player (100), below toasts (120) */
|
|
width: 22rem;
|
|
max-width: calc(100vw - 2rem);
|
|
display: flex;
|
|
flex-direction: column;
|
|
gap: .6rem;
|
|
overflow-y: auto;
|
|
overflow-x: hidden;
|
|
/* A frame around cards, not a surface — the empty space below them must never
|
|
eat a click meant for the highway. */
|
|
pointer-events: none;
|
|
scrollbar-width: thin;
|
|
}
|
|
.fb-pane-dock.is-empty { display: none; }
|
|
|
|
.fb-pane-card {
|
|
pointer-events: auto;
|
|
flex: 0 0 auto;
|
|
display: flex;
|
|
flex-direction: column;
|
|
background: rgba(15, 23, 42, .96);
|
|
border: 1px solid rgba(51, 65, 85, .6);
|
|
border-radius: .9rem;
|
|
box-shadow: 0 12px 40px rgba(0, 0, 0, .5);
|
|
overflow: hidden;
|
|
}
|
|
|
|
.fb-pane-card-head {
|
|
display: flex;
|
|
align-items: center;
|
|
gap: .5rem;
|
|
padding: .5rem .7rem;
|
|
border-bottom: 1px solid rgba(51, 65, 85, .5);
|
|
background: rgba(30, 41, 59, .6);
|
|
}
|
|
.fb-pane-card-title {
|
|
flex: 1 1 auto;
|
|
min-width: 0;
|
|
overflow: hidden;
|
|
text-overflow: ellipsis;
|
|
white-space: nowrap;
|
|
font-size: .78rem;
|
|
font-weight: 600;
|
|
color: #cbd5e1;
|
|
}
|
|
.fb-pane-card-btn {
|
|
flex: 0 0 auto;
|
|
width: 1.4rem;
|
|
height: 1.4rem;
|
|
display: inline-flex;
|
|
align-items: center;
|
|
justify-content: center;
|
|
border: 0;
|
|
border-radius: .35rem;
|
|
background: transparent;
|
|
color: #94a3b8;
|
|
font-size: .75rem;
|
|
line-height: 1;
|
|
cursor: pointer;
|
|
}
|
|
.fb-pane-card-btn:hover { background: rgba(51, 65, 85, .7); color: #e2e8f0; }
|
|
.fb-pane-card-btn:focus-visible { outline: 2px solid #4080e0; outline-offset: 1px; }
|
|
|
|
.fb-pane-card-body { overflow: auto; }
|
|
|
|
/* focus(id) — a brief highlight, so re-opening an already-open pane says so
|
|
instead of appearing to do nothing. */
|
|
.fb-pane-card.is-flash { animation: fb-pane-flash .7s ease-out; }
|
|
@keyframes fb-pane-flash {
|
|
0% { border-color: #4080e0; box-shadow: 0 0 0 3px rgba(64, 128, 224, .35), 0 12px 40px rgba(0, 0, 0, .5); }
|
|
100% { border-color: rgba(51, 65, 85, .6); box-shadow: 0 12px 40px rgba(0, 0, 0, .5); }
|
|
}
|
|
@media (prefers-reduced-motion: reduce) {
|
|
.fb-pane-card.is-flash { animation: none; }
|
|
}
|
|
|
|
/* ── The pop-out window (static/panes/pane.html) ─────────────────────────────
|
|
*
|
|
* The window's own chrome — everything INSIDE it is the adopted element, styled by
|
|
* the app's stylesheets, which the host copies into this document. */
|
|
|
|
html.fb-pane-window,
|
|
html.fb-pane-window body {
|
|
margin: 0;
|
|
padding: 0;
|
|
height: 100%;
|
|
background: #0f172a;
|
|
}
|
|
html.fb-pane-window body { display: flex; flex-direction: column; overflow: hidden; }
|
|
#fb-pane-root {
|
|
flex: 1 1 auto;
|
|
overflow: auto;
|
|
padding: .6rem;
|
|
}
|