mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-24 13:51:39 +00:00
static/js/player-controls.js (229) — the speed + mastery sliders and the four
playback-preference reads (autoplay-exit, up-next, countdown-before-song,
confirm-exit). Bodies VERBATIM. app.js 7,914 → 7,727.
The fourth slice out of the strongly-connected core, and by far the easiest: ONE
hook (handleSliderInput) and NO shared mutable state. The three groups are the same
surface — the controls under the highway — and the preference reads are the
one-line localStorage lookups half of app.js consults before deciding whether to
auto-start, show the Up Next pill, run a count-in, or confirm on exit. They travel
with the controls that set them.
Zero missed members on the first build (the no-undef pass was clean), which is the
first time that has happened in this phase.
TWO HARNESSES ARE SPLIT, and both taught something:
* speed_reset spans BOTH files — playSong (app.js) resets the speed controls
(module). Its presence GUARDS still read `src.includes('function setSpeed')`
against app.js, so once the code moved they silently evaluated FALSE and the
helpers were quietly dropped from the sandbox. A guard that disables itself is
worse than no guard. Repointed at the file the code actually lives in.
* Its `host.handleSliderInput` stub had to route at the sandbox's EXISTING spy,
not a fresh `() => {}`. The test asserts the slider was actually refreshed
(`deepEqual(__sliderInputs, ['speed-slider'])`); a fresh stub swallows the call
and the assertion passes VACUOUSLY. Same failure mode as a no-op host default —
the thing this whole seam design exists to prevent.
* autoplay_exit is split too: _autoplayExitEnabled moved, but the auto-exit
machinery around it (_clearAutoExit, holdAutoExit, _resolvePlayerOrigin) stayed.
VERIFIED. A/B against origin/main in two browsers, real song: setSpeed(0.75) ->
playbackRate 0.75; applySpeedPreset(100) -> 1; the speed slider; setMastery;
setAutoplayExit / setCountdownBeforeSong / setShowUpNext — IDENTICAL, zero page errors.
pytest 2396, node 1040/1040, ESLint 0 (no-cycle clean), tailwind clean.
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
213 lines
7.9 KiB
JavaScript
213 lines
7.9 KiB
JavaScript
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const vm = require('node:vm');
|
|
|
|
const APP_JS = path.join(__dirname, '..', '..', 'static', 'app.js');
|
|
// The speed controls were carved out into static/js/player-controls.js (R3a); playSong,
|
|
// which resets them on a new song, stayed in app.js. This test spans both.
|
|
const CONTROLS_JS = path.join(__dirname, '..', '..', 'static', 'js', 'player-controls.js');
|
|
|
|
function extractFunction(src, signature) {
|
|
const start = src.indexOf(signature);
|
|
if (start === -1) throw new Error(`extractFunction: '${signature}' not found in app.js`);
|
|
let scan = start + signature.length;
|
|
if (src[scan] === '(') {
|
|
let parenDepth = 1;
|
|
scan++;
|
|
while (scan < src.length && parenDepth > 0) {
|
|
const ch = src[scan];
|
|
if (ch === '(') parenDepth++;
|
|
else if (ch === ')') parenDepth--;
|
|
scan++;
|
|
}
|
|
}
|
|
const openBrace = src.indexOf('{', scan);
|
|
let depth = 1;
|
|
let i = openBrace + 1;
|
|
while (i < src.length && depth > 0) {
|
|
const ch = src[i];
|
|
if (ch === '{') depth++;
|
|
else if (ch === '}') depth--;
|
|
i++;
|
|
}
|
|
if (depth !== 0) throw new Error(`extractFunction: unbalanced braces after '${signature}'`);
|
|
return src.slice(start, i);
|
|
}
|
|
|
|
function buildSandbox({ juceMode = false } = {}) {
|
|
const elements = new Map();
|
|
const makeElement = (id) => ({
|
|
id,
|
|
value: id === 'speed-slider' ? 135 : '',
|
|
textContent: id === 'speed-label' ? '1.35x' : '',
|
|
style: {},
|
|
});
|
|
for (const id of ['speed-slider', 'speed-label', 'quality-select', 'highway']) {
|
|
elements.set(id, makeElement(id));
|
|
}
|
|
elements.set('speed-presets', {
|
|
id: 'speed-presets',
|
|
querySelectorAll() { return []; },
|
|
});
|
|
const backingCalls = [];
|
|
const sliderInputs = [];
|
|
const audio = {
|
|
playbackRate: 1.35,
|
|
pause() {},
|
|
};
|
|
const jucePlayer = {
|
|
_speed: 1.35,
|
|
setRate(rate) { this._speed = rate; },
|
|
stop() { return Promise.resolve(); },
|
|
};
|
|
const sandbox = {
|
|
console: { log() {}, warn() {}, error() {} },
|
|
audio,
|
|
jucePlayer,
|
|
highway: {
|
|
stop() {},
|
|
init() {},
|
|
connect(url) { sandbox.__connectedUrl = url; },
|
|
getRenderScale: () => 1,
|
|
},
|
|
window: {
|
|
_juceMode: juceMode,
|
|
_juceAudioUrl: juceMode ? '/audio/old-song.ogg' : null,
|
|
_currentSongAudio: { url: '/audio/old-song.ogg' },
|
|
_clearJuceRerouteMemo() {},
|
|
feedBack: {
|
|
isPlaying: true,
|
|
emit() {},
|
|
},
|
|
feedBackDesktop: {
|
|
audio: {
|
|
setBackingSpeed(rate) {
|
|
backingCalls.push(['setBackingSpeed', rate]);
|
|
return Promise.resolve();
|
|
},
|
|
setBackingPreservePitch(value) {
|
|
backingCalls.push(['setBackingPreservePitch', value]);
|
|
return Promise.resolve();
|
|
},
|
|
},
|
|
},
|
|
},
|
|
document: {
|
|
getElementById(id) {
|
|
if (!elements.has(id)) elements.set(id, makeElement(id));
|
|
return elements.get(id);
|
|
},
|
|
querySelector(selector) {
|
|
if (selector === '.screen.active') return { id: 'home' };
|
|
return null;
|
|
},
|
|
},
|
|
location: {
|
|
protocol: 'http:',
|
|
host: 'localhost:9999',
|
|
},
|
|
URLSearchParams,
|
|
setTimeout(fn) { fn(); return 0; },
|
|
clearTimeout() {},
|
|
Promise,
|
|
decodeURIComponent,
|
|
__elements: elements,
|
|
__backingCalls: backingCalls,
|
|
__sliderInputs: sliderInputs,
|
|
};
|
|
sandbox.window.jucePlayer = jucePlayer;
|
|
sandbox.handleSliderInput = (el) => {
|
|
if (el) sliderInputs.push(el.id);
|
|
};
|
|
vm.createContext(sandbox);
|
|
return sandbox;
|
|
}
|
|
|
|
function extractConstLine(src, name) {
|
|
const match = src.match(new RegExp(`const ${name} = [^;]+;`));
|
|
if (!match) throw new Error(`extractConstLine: '${name}' not found in app.js`);
|
|
return match[0];
|
|
}
|
|
|
|
function loadPlaySong(sandbox) {
|
|
const src = fs.readFileSync(APP_JS, 'utf8');
|
|
// the module is ESM; the vm sandbox evaluates plain script text
|
|
const controls = fs.readFileSync(CONTROLS_JS, 'utf8').replace(/^export /gm, '');
|
|
const resetHelper = controls.includes('function _resetPlaybackSpeedForNewSong')
|
|
? extractFunction(controls, 'function _resetPlaybackSpeedForNewSong')
|
|
: '';
|
|
const speedPresetHelpers = controls.includes('function _updateSpeedPresetButtons')
|
|
? `
|
|
${extractConstLine(controls, 'SPEED_PRESET_PCTS')}
|
|
${extractConstLine(controls, 'SPEED_SNAP_THRESHOLD')}
|
|
${extractFunction(controls, 'function _speedPresetPctFromActive')}
|
|
${extractFunction(controls, 'function _updateSpeedPresetButtons')}
|
|
`
|
|
: '';
|
|
const code = `
|
|
var artAbortController = null;
|
|
// isPlaying moved onto the shared player-state container so a carved module can
|
|
// WRITE it (an imported binding is read-only). NB window.feedBack.isPlaying — the
|
|
// public mirror stubbed above — is a different thing and is unchanged.
|
|
var S = { isPlaying: true, lastAudioTime: 0 };
|
|
// The speed controls reach app.js through the host seam (static/js/host.js).
|
|
// Route it at the sandbox's EXISTING handleSliderInput spy — a fresh stub would
|
|
// swallow the call and the assertion below (which checks the slider was actually
|
|
// refreshed) would pass vacuously.
|
|
var host = { handleSliderInput: (el) => handleSliderInput(el) };
|
|
var currentFilename = null;
|
|
var _playerOriginScreen = null;
|
|
var _pendingAutostart = false;
|
|
function _clearAutoExit() {}
|
|
function _clearAutoplayHold() {}
|
|
function _resolvePlayerOrigin() { return 'home'; }
|
|
function _recordPlaybackBridge() {}
|
|
function _cancelCountIn() {}
|
|
function _resetJuceAudioShimChain() {}
|
|
function _resetAudioSeekState() {}
|
|
function setPlayButtonState() {}
|
|
function clearLoop() {}
|
|
function _resetSectionPracticeLog() {}
|
|
function _hideSectionPracticeBar() {}
|
|
function showScreen() {}
|
|
function _getArrangementNamingMode() { return 'default'; }
|
|
function _scheduleSectionPracticeRetries() {}
|
|
function loadSavedLoops() {}
|
|
function _songEventPayload() { return { time: 7, audioT: 7, chartT: 7, perfNow: 7 }; }
|
|
${extractFunction(controls, 'function setSpeed')}
|
|
${speedPresetHelpers}
|
|
${resetHelper}
|
|
${extractFunction(src, 'async function playSong')}
|
|
globalThis.__playSong = playSong;
|
|
`;
|
|
vm.runInContext(code, sandbox);
|
|
}
|
|
|
|
test('new song load resets the HTML audio rate, not only the visible speed controls', async () => {
|
|
const sandbox = buildSandbox();
|
|
loadPlaySong(sandbox);
|
|
|
|
await sandbox.__playSong('next-song.archive');
|
|
|
|
assert.equal(sandbox.__elements.get('speed-slider').value, 100);
|
|
assert.match(sandbox.__elements.get('speed-label').textContent, /^1\.0{1,2}x$/);
|
|
assert.equal(sandbox.audio.playbackRate, 1);
|
|
assert.deepEqual(sandbox.__sliderInputs, ['speed-slider']);
|
|
});
|
|
|
|
test('new song load resets the desktop backing rate when the API is available', async () => {
|
|
const sandbox = buildSandbox({ juceMode: true });
|
|
loadPlaySong(sandbox);
|
|
|
|
await sandbox.__playSong('next-song.archive');
|
|
await new Promise((resolve) => setImmediate(resolve));
|
|
|
|
assert.equal(sandbox.jucePlayer._speed, 1);
|
|
assert.deepEqual(sandbox.__backingCalls, [
|
|
['setBackingSpeed', 1],
|
|
['setBackingPreservePitch', true],
|
|
]);
|
|
});
|