mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-22 21:01:40 +00:00
286c59707b
Two pre-existing failures the segfault had been masking (the run aborted at ~25%, so they never ran until #735 let the suite complete): 1) Tuner group (~24): plugins ship a bare-named routes.py, so sys.modules['routes'] leaked between plugin test dirs (achievements ran first, tuner got its module). Each plugin conftest now pops the stale 'routes' and an autouse fixture binds sys.modules['routes'] to that plugin's module for the duration of its tests (covers runtime 'import routes' in test bodies). 2) Diagnostics group (5): _SONG_FILENAME_RE never matched the tests' .feedpak/.archive filenames — it also lacked 'feedpak' (the current primary format), a real redaction gap. Added feedpak to the regex and switched the tests off the fake .archive to the real .feedpak. Verified: full suite 2183 passed, 0 failed. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
110 lines
3.3 KiB
Python
110 lines
3.3 KiB
Python
from pathlib import Path
|
|
|
|
from diagnostics_redact import Redactor
|
|
|
|
|
|
def test_dlc_path_replaced():
|
|
r = Redactor(dlc_dir=Path("/dlc/songs"))
|
|
out = r.redact_text("loaded from /dlc/songs/foo.feedpak")
|
|
assert "<DLC_DIR>" in out
|
|
assert "/dlc/songs" not in out
|
|
assert r.counts["paths_replaced"] == 1
|
|
|
|
|
|
def test_song_filename_redacted_consistently():
|
|
r = Redactor()
|
|
a = r.redact_text("Loading Test-Artist_Test-Song.feedpak")
|
|
b = r.redact_text("Replaying Test-Artist_Test-Song.feedpak again")
|
|
token_a = a.split("Loading ")[1].strip()
|
|
token_b = b.split("Replaying ")[1].split(" ")[0]
|
|
assert token_a == token_b
|
|
assert token_a.startswith("<song:") and token_a.endswith(">")
|
|
assert r.counts["song_names_replaced"] == 2
|
|
|
|
|
|
def test_ipv4_redacted():
|
|
r = Redactor()
|
|
out = r.redact_text("client 192.168.1.42 connected")
|
|
assert "192.168.1.42" not in out
|
|
assert "<ip:" in out
|
|
assert r.counts["ips_replaced"] == 1
|
|
|
|
|
|
def test_invalid_ipv4_left_alone():
|
|
r = Redactor()
|
|
out = r.redact_text("version 1.2.3.999 not an ip")
|
|
assert "1.2.3.999" in out
|
|
assert r.counts["ips_replaced"] == 0
|
|
|
|
|
|
def test_bearer_token_redacted():
|
|
r = Redactor()
|
|
out = r.redact_text("Authorization: Bearer abc123def456")
|
|
assert "abc123def456" not in out
|
|
assert "<redacted>" in out
|
|
assert r.counts["secrets_replaced"] == 1
|
|
|
|
|
|
def test_qstring_secret_redacted():
|
|
r = Redactor()
|
|
out = r.redact_text("GET /api?api_key=supersecret&foo=bar")
|
|
assert "supersecret" not in out
|
|
assert "api_key=<redacted>" in out
|
|
assert "foo=bar" in out
|
|
|
|
|
|
def test_home_dir_replaced():
|
|
r = Redactor(home_dir=Path("/home/alice"))
|
|
out = r.redact_text("config at /home/alice/.config/feedBack")
|
|
assert "/home/alice" not in out
|
|
assert "<HOME>" in out
|
|
|
|
|
|
def test_different_redactors_produce_different_tokens():
|
|
a = Redactor()
|
|
b = Redactor()
|
|
out_a = a.redact_text("Foo.feedpak")
|
|
out_b = b.redact_text("Foo.feedpak")
|
|
assert out_a != out_b
|
|
|
|
|
|
def test_redact_lines_iterator():
|
|
r = Redactor()
|
|
lines = ["client 10.0.0.1", "client 10.0.0.1 again"]
|
|
out = list(r.redact_lines(lines))
|
|
assert out[0] != lines[0]
|
|
assert out[0].split("client ")[1] == out[1].split("client ")[1].split(" ")[0]
|
|
|
|
|
|
def test_non_string_passes_through():
|
|
r = Redactor()
|
|
assert r.redact_text("") == ""
|
|
assert r.redact_text(None) is None
|
|
|
|
|
|
def test_url_userinfo_redacted():
|
|
"""Credentials embedded as URL userinfo (user:pass@host) must be redacted."""
|
|
r = Redactor()
|
|
out = r.redact_text("connecting to https://admin:secret@myhost.example.com/api")
|
|
assert "admin" not in out
|
|
assert "secret" not in out
|
|
assert "<redacted>@myhost.example.com" in out
|
|
assert r.counts["secrets_replaced"] == 1
|
|
|
|
|
|
def test_url_userinfo_redacted_http():
|
|
"""URL userinfo redaction also applies to http:// URLs."""
|
|
r = Redactor()
|
|
out = r.redact_text("http://user:pass@192.168.1.1:8080/path")
|
|
assert "user:pass" not in out
|
|
assert "<redacted>@" in out
|
|
|
|
|
|
def test_url_no_userinfo_unchanged():
|
|
"""A plain URL without userinfo must not be altered by the userinfo redactor."""
|
|
r = Redactor()
|
|
url = "https://myhost.example.com/api/stream"
|
|
out = r.redact_text(url)
|
|
assert out == url
|
|
assert r.counts["secrets_replaced"] == 0
|