mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-23 05:11:34 +00:00
b103a722ce
Reported on macOS: on a fresh install, pointing at a DLC folder in Settings and running a scan showed NO songs until an app restart. The scan itself was fine — _background_scan re-reads config.json fresh, so it scans the new folder and populates the library — but the v3 Songs grid never reloaded. The Settings Rescan / Full Rescan handlers only refreshed the classic (v2) library via loadLibrary(); the v3 grid (static/v3/songs.js) had no listener for a scan it didn't initiate (only its own upload path self-refreshes via watchUploadScan). So its cached, pre-DLC (empty) DOM/snapshot survived a sidebar return until a full reload (restart). Fix: the rescan handlers now emit `library:changed` (static/app.js). The v3 grid listens and reloads if it's the active screen, else sets `_libraryDirty` so the next onV3SongsScreenEnter does a full re-fetch — a short-circuit placed ahead of every cached-DOM fast-path so it can't restore the stale grid. Tests: tests/js/v3_library_refresh.test.js guards the emit + the reload/dirty wiring (DOM/event glue isn't headlessly unit-testable; end-to-end wants an in-app run of the reporter's flow: set DLC in Settings → scan → Songs populate without restart). Claude-Session: https://claude.ai/code/session_01QbexxfTt8q2tAn436MqGWF Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: byrongamatos <xasiklas@gmail.com>
41 lines
2.1 KiB
JavaScript
41 lines
2.1 KiB
JavaScript
// Regression guard for "No DLC until restart": a library scan triggered from
|
|
// Settings (rescan / full rescan, e.g. right after pointing at a DLC folder)
|
|
// reloaded only the classic library — the v3 Songs grid kept its cached
|
|
// (pre-DLC, empty) state until an app restart.
|
|
//
|
|
// The fix wires a `library:changed` event (emitted by the rescan handlers in
|
|
// app.js) to a reload in static/v3/songs.js. That's DOM/event glue, not a pure
|
|
// function, so these are source-level guards that the wiring isn't dropped; the
|
|
// end-to-end behavior is verified in-app / by a browser test.
|
|
|
|
'use strict';
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
const root = path.join(__dirname, '..', '..');
|
|
const SONGS = fs.readFileSync(path.join(root, 'static', 'v3', 'songs.js'), 'utf8');
|
|
const APP = fs.readFileSync(path.join(root, 'static', 'app.js'), 'utf8');
|
|
|
|
test('app.js emits library:changed when a Settings rescan completes', () => {
|
|
assert.match(APP, /emit\(\s*['"]library:changed['"]/,
|
|
'a completed rescan must broadcast library:changed for the v3 grid');
|
|
});
|
|
|
|
test('songs.js handles library:changed — reload when active, else mark dirty', () => {
|
|
const m = SONGS.match(/sm\.on\(\s*['"]library:changed['"][\s\S]{0,500}?\}\);/);
|
|
assert.ok(m, 'songs.js must subscribe to library:changed');
|
|
assert.match(m[0], /reload\(\)/, 'reloads the grid when the screen is active');
|
|
assert.match(m[0], /_libraryDirty\s*=\s*true/, 'marks dirty when off-screen');
|
|
});
|
|
|
|
test('onV3SongsScreenEnter forces a reload when the library is dirty', () => {
|
|
const m = SONGS.match(/function onV3SongsScreenEnter\(\)[\s\S]{0,400}?\{/);
|
|
assert.ok(m, 'onV3SongsScreenEnter present');
|
|
// The dirty check must short-circuit to a reload before the cached-DOM
|
|
// fast-paths get a chance to restore the stale grid.
|
|
assert.match(SONGS, /if\s*\(_libraryDirty\)\s*\{[^}]*reload\(\)[^}]*return;/,
|
|
'a dirty library must force a full reload on entry, ahead of any fast-path');
|
|
});
|