mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-28 15:42:35 +00:00
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
199 lines
6.7 KiB
JavaScript
199 lines
6.7 KiB
JavaScript
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const vm = require('node:vm');
|
|
|
|
const APP_JS = path.join(__dirname, '..', '..', 'static', 'app.js');
|
|
|
|
function extractFunction(src, signature) {
|
|
const start = src.indexOf(signature);
|
|
if (start === -1) throw new Error(`extractFunction: '${signature}' not found in app.js`);
|
|
let scan = start + signature.length;
|
|
if (src[scan] === '(') {
|
|
let parenDepth = 1;
|
|
scan++;
|
|
while (scan < src.length && parenDepth > 0) {
|
|
const ch = src[scan];
|
|
if (ch === '(') parenDepth++;
|
|
else if (ch === ')') parenDepth--;
|
|
scan++;
|
|
}
|
|
}
|
|
const openBrace = src.indexOf('{', scan);
|
|
let depth = 1;
|
|
let i = openBrace + 1;
|
|
while (i < src.length && depth > 0) {
|
|
const ch = src[i];
|
|
if (ch === '{') depth++;
|
|
else if (ch === '}') depth--;
|
|
i++;
|
|
}
|
|
if (depth !== 0) throw new Error(`extractFunction: unbalanced braces after '${signature}'`);
|
|
return src.slice(start, i);
|
|
}
|
|
|
|
function buildSandbox({ juceMode = false } = {}) {
|
|
const elements = new Map();
|
|
const makeElement = (id) => ({
|
|
id,
|
|
value: id === 'speed-slider' ? 135 : '',
|
|
textContent: id === 'speed-label' ? '1.35x' : '',
|
|
style: {},
|
|
});
|
|
for (const id of ['speed-slider', 'speed-label', 'quality-select', 'highway']) {
|
|
elements.set(id, makeElement(id));
|
|
}
|
|
elements.set('speed-presets', {
|
|
id: 'speed-presets',
|
|
querySelectorAll() { return []; },
|
|
});
|
|
const backingCalls = [];
|
|
const sliderInputs = [];
|
|
const audio = {
|
|
playbackRate: 1.35,
|
|
pause() {},
|
|
};
|
|
const jucePlayer = {
|
|
_speed: 1.35,
|
|
setRate(rate) { this._speed = rate; },
|
|
stop() { return Promise.resolve(); },
|
|
};
|
|
const sandbox = {
|
|
console: { log() {}, warn() {}, error() {} },
|
|
audio,
|
|
jucePlayer,
|
|
highway: {
|
|
stop() {},
|
|
init() {},
|
|
connect(url) { sandbox.__connectedUrl = url; },
|
|
getRenderScale: () => 1,
|
|
},
|
|
window: {
|
|
_juceMode: juceMode,
|
|
_juceAudioUrl: juceMode ? '/audio/old-song.ogg' : null,
|
|
_currentSongAudio: { url: '/audio/old-song.ogg' },
|
|
_clearJuceRerouteMemo() {},
|
|
feedBack: {
|
|
isPlaying: true,
|
|
emit() {},
|
|
},
|
|
feedBackDesktop: {
|
|
audio: {
|
|
setBackingSpeed(rate) {
|
|
backingCalls.push(['setBackingSpeed', rate]);
|
|
return Promise.resolve();
|
|
},
|
|
setBackingPreservePitch(value) {
|
|
backingCalls.push(['setBackingPreservePitch', value]);
|
|
return Promise.resolve();
|
|
},
|
|
},
|
|
},
|
|
},
|
|
document: {
|
|
getElementById(id) {
|
|
if (!elements.has(id)) elements.set(id, makeElement(id));
|
|
return elements.get(id);
|
|
},
|
|
querySelector(selector) {
|
|
if (selector === '.screen.active') return { id: 'home' };
|
|
return null;
|
|
},
|
|
},
|
|
location: {
|
|
protocol: 'http:',
|
|
host: 'localhost:9999',
|
|
},
|
|
URLSearchParams,
|
|
setTimeout(fn) { fn(); return 0; },
|
|
clearTimeout() {},
|
|
Promise,
|
|
decodeURIComponent,
|
|
__elements: elements,
|
|
__backingCalls: backingCalls,
|
|
__sliderInputs: sliderInputs,
|
|
};
|
|
sandbox.window.jucePlayer = jucePlayer;
|
|
sandbox.handleSliderInput = (el) => {
|
|
if (el) sliderInputs.push(el.id);
|
|
};
|
|
vm.createContext(sandbox);
|
|
return sandbox;
|
|
}
|
|
|
|
function extractConstLine(src, name) {
|
|
const match = src.match(new RegExp(`const ${name} = [^;]+;`));
|
|
if (!match) throw new Error(`extractConstLine: '${name}' not found in app.js`);
|
|
return match[0];
|
|
}
|
|
|
|
function loadPlaySong(sandbox) {
|
|
const src = fs.readFileSync(APP_JS, 'utf8');
|
|
const resetHelper = src.includes('function _resetPlaybackSpeedForNewSong')
|
|
? extractFunction(src, 'function _resetPlaybackSpeedForNewSong')
|
|
: '';
|
|
const speedPresetHelpers = src.includes('function _updateSpeedPresetButtons')
|
|
? `
|
|
${extractConstLine(src, 'SPEED_PRESET_PCTS')}
|
|
${extractConstLine(src, 'SPEED_SNAP_THRESHOLD')}
|
|
${extractFunction(src, 'function _speedPresetPctFromActive')}
|
|
${extractFunction(src, 'function _updateSpeedPresetButtons')}
|
|
`
|
|
: '';
|
|
const code = `
|
|
var artAbortController = null;
|
|
var isPlaying = true;
|
|
var currentFilename = null;
|
|
var _playerOriginScreen = null;
|
|
var _pendingAutostart = false;
|
|
function _clearAutoExit() {}
|
|
function _resolvePlayerOrigin() { return 'home'; }
|
|
function _recordPlaybackBridge() {}
|
|
function _cancelCountIn() {}
|
|
function _resetJuceAudioShimChain() {}
|
|
function _resetAudioSeekState() {}
|
|
function setPlayButtonState() {}
|
|
function clearLoop() {}
|
|
function _resetSectionPracticeLog() {}
|
|
function _hideSectionPracticeBar() {}
|
|
function showScreen() {}
|
|
function _getArrangementNamingMode() { return 'default'; }
|
|
function _scheduleSectionPracticeRetries() {}
|
|
function loadSavedLoops() {}
|
|
function _songEventPayload() { return { time: 7, audioT: 7, chartT: 7, perfNow: 7 }; }
|
|
${extractFunction(src, 'function setSpeed')}
|
|
${speedPresetHelpers}
|
|
${resetHelper}
|
|
${extractFunction(src, 'async function playSong')}
|
|
globalThis.__playSong = playSong;
|
|
`;
|
|
vm.runInContext(code, sandbox);
|
|
}
|
|
|
|
test('new song load resets the HTML audio rate, not only the visible speed controls', async () => {
|
|
const sandbox = buildSandbox();
|
|
loadPlaySong(sandbox);
|
|
|
|
await sandbox.__playSong('next-song.archive');
|
|
|
|
assert.equal(sandbox.__elements.get('speed-slider').value, 100);
|
|
assert.match(sandbox.__elements.get('speed-label').textContent, /^1\.0{1,2}x$/);
|
|
assert.equal(sandbox.audio.playbackRate, 1);
|
|
assert.deepEqual(sandbox.__sliderInputs, ['speed-slider']);
|
|
});
|
|
|
|
test('new song load resets the desktop backing rate when the API is available', async () => {
|
|
const sandbox = buildSandbox({ juceMode: true });
|
|
loadPlaySong(sandbox);
|
|
|
|
await sandbox.__playSong('next-song.archive');
|
|
await new Promise((resolve) => setImmediate(resolve));
|
|
|
|
assert.equal(sandbox.jucePlayer._speed, 1);
|
|
assert.deepEqual(sandbox.__backingCalls, [
|
|
['setBackingSpeed', 1],
|
|
['setBackingPreservePitch', true],
|
|
]);
|
|
});
|