mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-21 12:21:49 +00:00
196008a98e
Problem:
The editor strips drum arrangements from the sloppak manifest, converting
them to a drum_tab sidecar. This left two visible bugs:
1. "Drums (0)" — drum-only packs showed zero notes in the arrangement
picker even though the drum highway displayed thousands of hits. The
sloppak loader synthesized a placeholder Arrangement(name="Drums")
with no notes whenever the arrangements list was empty, and the
WebSocket highway always reported that placeholder's note count (0).
2. Drums disappear alongside other arrangements — when a drum+bass or
drum+guitar pack was loaded, the placeholder was never created because
the arrangements list was not empty (the other instrument was present).
The drum arrangement had been removed by the editor during drum_tab
conversion, so drums vanished entirely from the arrangement picker.
Fix (sloppak.py):
Replaced the "arrangements list is empty" trigger with "no drum
arrangement exists". The loader now checks whether any arrangement name
contains 'drum' or 'percussion' (case-insensitive substring match using
_DRUM_KEYWORDS) and synthesizes the placeholder when a drum_tab is
present but no matching arrangement is found. This ensures drums appear
in the picker even alongside bass, guitar, or other pitched instruments.
Fix (ws_highway.py):
When building the arrangement list for the song_info WebSocket message,
the highway now reads the drum_tab hit count from the loaded sloppak and
substitutes it for any empty arrangement whose name matches the drum
keywords. The placeholder has no notes of its own (it exists only to
carry the drum_tab through to the drum highway), so the real hit count
from drum_tab is surfaced instead — e.g. "Drums (1922)" instead of
"Drums (0)".
Guard against false positives:
The hit-count override is scoped to drum/percussion arrangements only.
Without this guard, an empty "Vocals" or "Keys" track in the same
pack would incorrectly inherit the drum hit count. The same keyword set
_DRUM_KEYWORDS = ('drum', 'percussion') is used in both sloppak.py and
ws_highway.py to keep the detection consistent.
Signed-off-by: =Scr4tch= <305609711+0-Scr4tch-0@users.noreply.github.com>
|
||
|---|---|---|
| .claude/skills | ||
| .github | ||
| .specify | ||
| content/starter | ||
| data/progression | ||
| docs | ||
| lib | ||
| plugins | ||
| scripts | ||
| specs | ||
| static | ||
| tests | ||
| tools | ||
| .dockerignore | ||
| .gitattributes | ||
| .gitignore | ||
| build-proxmox-ct.sh | ||
| CHANGELOG.md | ||
| CLAUDE.md | ||
| CONTRIBUTING.md | ||
| docker-compose.nas.yml | ||
| docker-compose.yml | ||
| Dockerfile | ||
| eslint.config.js | ||
| feedpak-spec-exceptions.yml | ||
| LICENSE | ||
| main.py | ||
| package-lock.json | ||
| package.json | ||
| playwright.config.ts | ||
| pyproject.toml | ||
| requirements-test.txt | ||
| requirements.txt | ||
| server.py | ||
| SUPPORTERS.md | ||
| tailwind.config.js | ||
| TODO.md | ||
| uv.lock | ||
| VERSION | ||