mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-26 06:42:32 +00:00
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
116 lines
4.8 KiB
JavaScript
116 lines
4.8 KiB
JavaScript
'use strict';
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const vm = require('node:vm');
|
|
|
|
const APP_JS = path.join(__dirname, '..', '..', 'static', 'app.js');
|
|
const HIGHWAY_JS = path.join(__dirname, '..', '..', 'static', 'highway.js');
|
|
const V3_HTML = path.join(__dirname, '..', '..', 'static', 'v3', 'index.html');
|
|
const V2_HTML = path.join(__dirname, '..', '..', 'static', 'index.html');
|
|
|
|
function extractBlock(src, startMarker) {
|
|
const start = src.indexOf(startMarker);
|
|
if (start === -1) throw new Error(`extractBlock: '${startMarker}' not found`);
|
|
const openBrace = src.indexOf('{', start);
|
|
let depth = 1;
|
|
let i = openBrace + 1;
|
|
while (i < src.length && depth > 0) {
|
|
const ch = src[i];
|
|
if (ch === '{') depth++;
|
|
else if (ch === '}') depth--;
|
|
i++;
|
|
}
|
|
if (depth !== 0) throw new Error(`extractBlock: unbalanced braces after '${startMarker}'`);
|
|
return src.slice(start, i);
|
|
}
|
|
|
|
function loadTuningDisplayHelpers() {
|
|
const src = fs.readFileSync(APP_JS, 'utf8');
|
|
const block = [
|
|
extractBlock(src, 'function _looksLikeRawTuningOffsets('),
|
|
extractBlock(src, 'function _tuningNameFromOffsets('),
|
|
extractBlock(src, 'function parseRawTuningOffsets('),
|
|
extractBlock(src, 'function displayTuningName('),
|
|
].join('\n');
|
|
const sandbox = { window: { feedBack: {} }, exports: {} };
|
|
vm.createContext(sandbox);
|
|
vm.runInContext(block + '\nexports.displayTuningName = displayTuningName;', sandbox);
|
|
return sandbox.exports;
|
|
}
|
|
|
|
const TUNER_UI_JS = path.join(__dirname, '..', '..', 'plugins', 'tuner', 'utils', 'ui.js');
|
|
|
|
const { displayTuningName } = loadTuningDisplayHelpers();
|
|
|
|
test('displayTuningName passes through known labels', () => {
|
|
assert.equal(displayTuningName('E Standard'), 'E Standard');
|
|
assert.equal(displayTuningName('Drop D'), 'Drop D');
|
|
assert.equal(displayTuningName('Eb Standard'), 'Eb Standard');
|
|
});
|
|
|
|
test('displayTuningName sanitizes raw offset strings to Custom Tuning', () => {
|
|
assert.equal(displayTuningName('-2000-2'), 'Custom Tuning');
|
|
assert.equal(displayTuningName('-2 0 0 0 -2'), 'Custom Tuning');
|
|
assert.equal(displayTuningName('-3,-1,0,1,2,3'), 'Custom Tuning');
|
|
});
|
|
|
|
test('displayTuningName names a known raw offset string (feedBack#867)', () => {
|
|
// Now that the API serves raw offsets, a known tuning passed as a raw
|
|
// string must resolve to its real name, not collapse to Custom Tuning.
|
|
assert.equal(displayTuningName('-1 -1 -1 -1 -1 -1'), 'Eb Standard');
|
|
assert.equal(displayTuningName('-2 0 0 0 0 0'), 'Drop D');
|
|
assert.equal(displayTuningName('-2,0,0,0,-2,0'), 'DADGAD');
|
|
// Genuinely custom offsets still read Custom Tuning.
|
|
assert.equal(displayTuningName('-2 0 0 0 -2 1'), 'Custom Tuning');
|
|
});
|
|
|
|
test('displayTuningName recognizes 4/5-string uniform standard (feedBack#867)', () => {
|
|
// A normal 4-string bass [0,0,0,0] must not fall through to Custom Tuning.
|
|
assert.equal(displayTuningName(null, [0, 0, 0, 0]), 'E Standard');
|
|
assert.equal(displayTuningName(null, [-2, -2, -2, -2]), 'D Standard');
|
|
assert.equal(displayTuningName('0 0 0 0'), 'E Standard');
|
|
});
|
|
|
|
test('displayTuningName derives readable names from offsets when value missing', () => {
|
|
assert.equal(displayTuningName(null, [0, 0, 0, 0, 0, 0]), 'E Standard');
|
|
assert.equal(displayTuningName('', [0, 0, 0, 0, 0, 0]), 'E Standard');
|
|
assert.equal(displayTuningName(undefined, [-2, 0, 0, 0, 0, 0]), 'Drop D');
|
|
});
|
|
|
|
test('displayTuningName returns Custom Tuning for unknown offsets', () => {
|
|
assert.equal(displayTuningName(null, [-2, 0, 0, 0, -2]), 'Custom Tuning');
|
|
assert.equal(displayTuningName('-2 0 0 0 -2', [-2, 0, 0, 0, -2]), 'Custom Tuning');
|
|
});
|
|
|
|
test('displayTuningName returns empty when nothing usable', () => {
|
|
assert.equal(displayTuningName(''), '');
|
|
assert.equal(displayTuningName(null), '');
|
|
assert.equal(displayTuningName('Unknown'), '');
|
|
assert.equal(displayTuningName(null, []), '');
|
|
});
|
|
|
|
test('V3 index.html defines hud-tuning', () => {
|
|
const html = fs.readFileSync(V3_HTML, 'utf8');
|
|
assert.match(html, /id="hud-tuning"/);
|
|
});
|
|
|
|
test('V2 index.html defines hud-tuning', () => {
|
|
const html = fs.readFileSync(V2_HTML, 'utf8');
|
|
assert.match(html, /id="hud-tuning"/);
|
|
});
|
|
|
|
test('highway.js updates hud-tuning from song_info tuning offsets', () => {
|
|
const src = fs.readFileSync(HIGHWAY_JS, 'utf8');
|
|
assert.match(src, /getElementById\('hud-tuning'\)/);
|
|
assert.match(src, /displayTuningName\(null, msg\.tuning\)/);
|
|
assert.match(src, /Tuning: /);
|
|
});
|
|
|
|
test('V3 index.html defines hud-tuning-targets', () => {
|
|
const html = fs.readFileSync(V3_HTML, 'utf8');
|
|
assert.match(html, /id="hud-tuning-targets"/);
|
|
});
|