feedBack/tests/js/tuning_targets.test.js
Bret Mogilefsky af2949677a
rename: slopsmith → feedBack, byron → got-feedBack (#537)
* Update GitHub repo references from feedback* to feedBack*

* rename: slopsmith -> feedBack, byron -> got-feedBack

Renames across the entire codebase:
- slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack
- byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack
- /home/byron/ -> /opt/got-feedBack/
- byron@ougsoft.com -> hi@got-feedBack.org
- github.com/byrongamatos/ -> github.com/got-feedback/
- com.byron. -> com.got-feedback.
- SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback
- Protocol/storage strings migrated with read-old/write-new pattern
- window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias

Refs: #rename-slopsmith

* rename: complete regen against current main + fix backward-compat alias

Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of
current main (3 commits had landed since the branch: #572/#554/#574),
resolving the four content conflicts in favour of main's newer content
(autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge).

Completion fixes on top of the mechanical rename:
- Re-apply rename to post-branch content the original rename never saw:
  window.slopsmith(.Tour) consumers in lessons.js / notifications.js /
  onboarding-tour.js, and the matching JS + python tests (autoplay_exit,
  progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env
  vars now match server.py (which reads FEEDBACK_SYNC_STARTUP /
  FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real
  path again.
- Restore the window.slopsmith backward-compat alias dropped during conflict
  resolution, and move the bus aliases to AFTER the _feedBackExisting merge
  block so they reference the fully-assembled object (also fixes the
  loop_api.test.js API-surface regex, which the original PR latently broke).
- Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR)
  and gitignore it.
- Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped
  source labels.

Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669
passed / 1683 collected with 0 import errors; zero residual slopsmith/byron
except the two intentional window.slopsmith aliases.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* rename: implement advertised backward-compat + prune dead community plugins

Address gaps where PR #537's "Backward compatibility" section was advertised
but not implemented, and clean up the community plugin list.

Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured):
- New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py
  (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and
  tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI /
  SLOPSMITH_PLUGINS_DIR / etc. deployments keep working.
- Fix the rename collapsing plugins/__init__.py and minigames/routes.py from
  `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant
  `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost).

Storage (app.js update-channel):
- Read feedBack-update-channel, fall back to legacy slopsmith-update-channel,
  and clear the legacy key on write — so a user's update-channel preference
  survives the rename instead of resetting to "stable".

Community plugin list (README): the rename rewrote third-party repo URLs we
don't own. Probed every one; their owners never renamed, so:
- Restore the 13 live community plugins to their real slopsmith-* names.
- Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex
  tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle).
- Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory).

Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors,
rename-sensitive + startup suites green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: byrongamatos <xasiklas@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 11:03:01 +02:00

147 lines
6.2 KiB
JavaScript

'use strict';
const { test } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const path = require('node:path');
const vm = require('node:vm');
const APP_JS = path.join(__dirname, '..', '..', 'static', 'app.js');
const HIGHWAY_JS = path.join(__dirname, '..', '..', 'static', 'highway.js');
const TUNER_UI_JS = path.join(__dirname, '..', '..', 'plugins', 'tuner', 'utils', 'ui.js');
const TUNER_SCREEN_JS = path.join(__dirname, '..', '..', 'plugins', 'tuner', 'screen.js');
const V3_HTML = path.join(__dirname, '..', '..', 'static', 'v3', 'index.html');
const V2_HTML = path.join(__dirname, '..', '..', 'static', 'index.html');
function loadTuningHelpers() {
const src = fs.readFileSync(APP_JS, 'utf8');
const start = src.indexOf('function isBassArrangement(');
const endMarker = 'window.feedBack.parseRawTuningOffsets = parseRawTuningOffsets;';
const end = src.indexOf(endMarker);
if (start === -1 || end === -1) throw new Error('tuning helper block not found in app.js');
const sandbox = { window: { feedBack: {} }, exports: {} };
vm.createContext(sandbox);
vm.runInContext(
src.slice(start, end + endMarker.length) + '\n'
+ 'exports.displayTuningTargets = displayTuningTargets;\n'
+ 'exports.displayTuningTargetDetails = displayTuningTargetDetails;\n'
+ 'exports.isBassArrangement = isBassArrangement;\n'
+ 'exports.effectiveStringCount = effectiveStringCount;',
sandbox
);
return sandbox.exports;
}
const { displayTuningTargets, displayTuningTargetDetails, isBassArrangement, effectiveStringCount } = loadTuningHelpers();
const LEAD_CTX = { arrangement: 'Lead', stringCount: 4, tuningName: 'Custom Tuning' };
const BASS_CTX = { arrangement: 'Bass', stringCount: 4, isBass: true, tuningName: 'Custom Tuning' };
test('effectiveStringCount: Lead with bad stringCount=4 uses six guitar strings', () => {
assert.equal(effectiveStringCount([-2, 0, 0, 0, -2, 0], LEAD_CTX), 6);
});
test('isBassArrangement: Lead is not bass', () => {
assert.equal(isBassArrangement({ arrangement: 'Lead' }), false);
assert.equal(isBassArrangement({ arrangement: 'Bass' }), true);
});
test('displayTuningTargets: custom guitar uses low-to-high note names only', () => {
const targets = displayTuningTargets([-2, 0, 0, 0, -2, -2], LEAD_CTX);
assert.equal(targets, 'D A D G A D');
assert.doesNotMatch(targets, /6:|5:|D2|A2|D3/);
});
test('displayTuningTargets: E Standard guitar is low-to-high notes', () => {
const targets = displayTuningTargets([0, 0, 0, 0, 0, 0], { stringCount: 6, arrangement: 'Lead' });
assert.equal(targets, 'E A D G B E');
});
test('displayTuningTargets: bass 4-string is low-to-high notes', () => {
const targets = displayTuningTargets([0, 0, 0, 0], BASS_CTX);
assert.equal(targets, 'E A D G');
});
test('displayTuningTargetDetails: includes string number and octave in titles', () => {
const details = displayTuningTargetDetails([-2, 0, 0, 0, -2, -2], LEAD_CTX);
assert.equal(details.length, 6);
assert.equal(details[0].note, 'D');
assert.equal(details[0].octaveNote, 'D2');
assert.equal(details[0].title, '6th string: D2');
assert.equal(details[5].title, '1st string: D4');
});
test('displayTuningTargets: missing offsets returns empty string', () => {
assert.equal(displayTuningTargets(null), '');
assert.equal(displayTuningTargets([]), '');
});
test('highway.js shows targets only for Custom Tuning', () => {
const src = fs.readFileSync(HIGHWAY_JS, 'utf8');
assert.match(src, /getElementById\('hud-tuning-targets'\)/);
assert.match(src, /displayTuningTargets/);
assert.match(src, /tuningLabel === 'Custom Tuning'/);
assert.match(src, /Targets: /);
});
test('tuner string buttons show note-only labels for Current Song', () => {
const src = fs.readFileSync(TUNER_UI_JS, 'utf8');
assert.match(src, /function _stringButtonLabel/);
assert.match(src, /selectedTuningName === '_current'/);
assert.match(src, /text: note/);
assert.match(src, /title: _stringOrdinal/);
assert.doesNotMatch(src, /text: stringNum \+ ' ' \+ note/);
});
test('tuner panel shows visible low-to-high string order helper for Current Song', () => {
const src = fs.readFileSync(TUNER_UI_JS, 'utf8');
const helpBlock = src.slice(
src.indexOf('function _syncStringOrderHelp'),
src.indexOf('function renderStringNotes')
);
assert.match(src, /function _syncStringOrderHelp/);
assert.match(src, /stringOrderHelpContainer/);
assert.match(src, /Tune low-to-high:/);
assert.match(src, /string → 1st string/);
assert.match(helpBlock, /selectedTuningName === '_current'/);
assert.doesNotMatch(helpBlock, /!state\.freeTune/);
});
test('player-active tuner placement shifts left of LIVE HUD', () => {
const src = fs.readFileSync(TUNER_UI_JS, 'utf8');
const playerBranch = src.slice(
src.indexOf('if (isPlayer && playerEl)'),
src.indexOf('if (!wrap)')
);
assert.match(playerBranch, /top:5rem;right:11rem/);
assert.doesNotMatch(playerBranch, /top:5rem;right:1\.25rem/);
});
test('non-player tuner placement remains bottom-right', () => {
const src = fs.readFileSync(TUNER_UI_JS, 'utf8');
assert.match(src, /bottom:5rem;right:1\.25rem/);
});
test('bass Current Song helper uses 4th string to 1st string label', () => {
const details = displayTuningTargetDetails([0, 0, 0, 0], BASS_CTX);
assert.equal(details.length, 4);
assert.equal(details[0].title, '4th string: E1');
assert.equal(details[3].title, '1st string: G2');
});
test('Current Song helper hidden when no tuning targets exist', () => {
const src = fs.readFileSync(TUNER_UI_JS, 'utf8');
const helpBlock = src.slice(
src.indexOf('function _syncStringOrderHelp'),
src.indexOf('function renderStringNotes')
);
assert.match(helpBlock, /selectedTuning\.length > 0/);
assert.match(helpBlock, /classList\.add\('hidden'\)/);
});
test('tuner player button calls window.tuner.toggle', () => {
const src = fs.readFileSync(TUNER_UI_JS, 'utf8');
assert.match(src, /btn\.id = 'btn-tuner-player'/);
assert.match(src, /btn\.onclick = window\.tuner\.toggle/);
});