mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-25 14:21:21 +00:00
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
102 lines
3.9 KiB
JavaScript
102 lines
3.9 KiB
JavaScript
// Verify closeCurrentSong() exits via origin-aware showScreen without
|
|
// restart, seek, playSong reload, or direct audio mutation.
|
|
//
|
|
// Same isolation strategy as song_restart.test.js — extract the function
|
|
// from app.js by brace-matching and run it in a vm sandbox.
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const vm = require('node:vm');
|
|
|
|
const { extractFunction } = require('./test_utils');
|
|
|
|
const APP_JS = path.join(__dirname, '..', '..', 'static', 'app.js');
|
|
|
|
function buildSandbox({ playerOriginScreen = 'home' } = {}) {
|
|
const sandbox = {
|
|
_playerOriginScreen: playerOriginScreen,
|
|
__showScreenCalls: [],
|
|
__restartCalls: 0,
|
|
__seekCalls: 0,
|
|
__playSongCalls: 0,
|
|
__clearLoopCalls: 0,
|
|
__audioCurrentTimeSets: [],
|
|
audio: {
|
|
_t: 42,
|
|
get currentTime() { return sandbox.audio._t; },
|
|
set currentTime(v) { sandbox.__audioCurrentTimeSets.push(v); sandbox.audio._t = v; },
|
|
},
|
|
};
|
|
vm.createContext(sandbox);
|
|
return sandbox;
|
|
}
|
|
|
|
function loadClose(sandbox, src) {
|
|
const closeSrc = extractFunction(src, 'function closeCurrentSong(');
|
|
const code = `
|
|
var _playerOriginScreen = ${JSON.stringify(sandbox._playerOriginScreen)};
|
|
globalThis.__showScreenCalls = [];
|
|
globalThis.__restartCalls = 0;
|
|
globalThis.__seekCalls = 0;
|
|
globalThis.__playSongCalls = 0;
|
|
globalThis.__clearLoopCalls = 0;
|
|
globalThis.__audioCurrentTimeSets = [];
|
|
var audio = {
|
|
_t: 42,
|
|
get currentTime() { return this._t; },
|
|
set currentTime(v) { globalThis.__audioCurrentTimeSets.push(v); this._t = v; }
|
|
};
|
|
function showScreen(id) {
|
|
globalThis.__showScreenCalls.push(id);
|
|
return Promise.resolve();
|
|
}
|
|
function restartCurrentSong() { globalThis.__restartCalls++; }
|
|
async function _audioSeek() { globalThis.__seekCalls++; }
|
|
function playSong() { globalThis.__playSongCalls++; }
|
|
function clearLoop() { globalThis.__clearLoopCalls++; }
|
|
${closeSrc}
|
|
globalThis.__closeCurrentSong = closeCurrentSong;
|
|
`;
|
|
vm.runInContext(code, sandbox);
|
|
}
|
|
|
|
test('closeCurrentSong is exported on window and window.feedBack', () => {
|
|
const src = fs.readFileSync(APP_JS, 'utf8');
|
|
assert.match(src, /window\.closeCurrentSong\s*=\s*closeCurrentSong/);
|
|
assert.match(src, /window\.feedBack\.closeCurrentSong\s*=\s*closeCurrentSong/);
|
|
});
|
|
|
|
test('closeCurrentSong uses _playerOriginScreen when set', async () => {
|
|
const src = fs.readFileSync(APP_JS, 'utf8');
|
|
const sandbox = buildSandbox({ playerOriginScreen: 'favorites' });
|
|
loadClose(sandbox, src);
|
|
await sandbox.__closeCurrentSong();
|
|
assert.equal(sandbox.__showScreenCalls.length, 1);
|
|
assert.equal(sandbox.__showScreenCalls[0], 'favorites');
|
|
assert.equal(sandbox.__restartCalls, 0);
|
|
assert.equal(sandbox.__seekCalls, 0);
|
|
assert.equal(sandbox.__playSongCalls, 0);
|
|
assert.equal(sandbox.__clearLoopCalls, 0);
|
|
assert.equal(sandbox.__audioCurrentTimeSets.length, 0);
|
|
});
|
|
|
|
test('closeCurrentSong falls back to home when origin missing', async () => {
|
|
const src = fs.readFileSync(APP_JS, 'utf8');
|
|
const sandbox = buildSandbox({ playerOriginScreen: null });
|
|
loadClose(sandbox, src);
|
|
await sandbox.__closeCurrentSong();
|
|
assert.equal(sandbox.__showScreenCalls.length, 1);
|
|
assert.equal(sandbox.__showScreenCalls[0], 'home');
|
|
});
|
|
|
|
test('closeCurrentSong falls back to home when origin is empty string', async () => {
|
|
const src = fs.readFileSync(APP_JS, 'utf8');
|
|
const sandbox = buildSandbox({ playerOriginScreen: '' });
|
|
loadClose(sandbox, src);
|
|
await sandbox.__closeCurrentSong();
|
|
assert.equal(sandbox.__showScreenCalls.length, 1);
|
|
assert.equal(sandbox.__showScreenCalls[0], 'home');
|
|
});
|