mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-25 14:21:21 +00:00
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
80 lines
3.4 KiB
JavaScript
80 lines
3.4 KiB
JavaScript
// Verify static/highway.js emits `beats:loaded` exactly once when the
|
|
// WebSocket delivers the song's beats array, with `{ count }` payload.
|
|
// Plugins that need to know when beats are available (metronome, beat-
|
|
// snapping editors, sync visualizers) consume this contract.
|
|
//
|
|
// Same isolation strategy as the other tests/js/ files — extract just
|
|
// the relevant case-block source by string matching and exercise it in
|
|
// a vm sandbox with stubbed deps.
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
const HIGHWAY_JS = path.join(__dirname, '..', '..', 'static', 'highway.js');
|
|
|
|
// Extract a single switch case body so assertions can match against just
|
|
// that block rather than a fixed-length slice (more robust to harmless
|
|
// edits adjacent to the case).
|
|
function getCaseBlock(src, label) {
|
|
const start = src.indexOf(`case '${label}'`);
|
|
assert.ok(start !== -1, `case '${label}' not found in highway.js`);
|
|
const tail = src.slice(start);
|
|
const nextCase = tail.search(/\n\s*case\s+['"]/);
|
|
const nextDefault = tail.search(/\n\s*default\s*:/);
|
|
let end = tail.length;
|
|
if (nextCase > 0) end = Math.min(end, nextCase);
|
|
if (nextDefault > 0) end = Math.min(end, nextDefault);
|
|
return tail.slice(0, end);
|
|
}
|
|
|
|
test('beats:loaded emit is wired into the WS beats case', () => {
|
|
// Source-level guard: catch a future contributor removing the emit
|
|
// (regression) or replacing window.feedBack.emit with something
|
|
// else (intentional refactor — this test then needs updating).
|
|
const src = fs.readFileSync(HIGHWAY_JS, 'utf8');
|
|
const block = getCaseBlock(src, 'beats');
|
|
assert.match(
|
|
block,
|
|
/window\.feedBack\.emit\(\s*['"]beats:loaded['"]/,
|
|
'beats case must emit beats:loaded',
|
|
);
|
|
assert.match(
|
|
block,
|
|
/count:\s*beats\.length/,
|
|
'beats:loaded payload must include count = beats.length',
|
|
);
|
|
});
|
|
|
|
test('beats:loaded emit is guarded against missing window.feedBack', () => {
|
|
// The WS handler can fire before the feedBack namespace is defined
|
|
// (early in app boot). The emit must be guarded so a missing
|
|
// namespace doesn't throw inside the WS message dispatcher.
|
|
// Looser pattern accepts any guard that reads window.feedBack
|
|
// (including typeof checks and combined conditions) rather than
|
|
// mandating the exact `if (window.feedBack)` form.
|
|
const src = fs.readFileSync(HIGHWAY_JS, 'utf8');
|
|
const block = getCaseBlock(src, 'beats');
|
|
assert.match(
|
|
block,
|
|
/if\s*\(\s*[^)]*window\.feedBack\b[^)]*\)/,
|
|
'beats:loaded emit must be guarded against a missing window.feedBack',
|
|
);
|
|
});
|
|
|
|
test('beats:loaded guard verifies emit is callable (typeof check)', () => {
|
|
// A partially-attached namespace (window.feedBack exists but emit
|
|
// isn't a function yet during early boot) would throw without this
|
|
// extra check. A truthy check (`window.feedBack.emit && ...`) lets
|
|
// non-callable values pass; require an explicit typeof === 'function'
|
|
// check so the guard catches that real edge.
|
|
const src = fs.readFileSync(HIGHWAY_JS, 'utf8');
|
|
const block = getCaseBlock(src, 'beats');
|
|
assert.match(
|
|
block,
|
|
/typeof\s+window\.feedBack\.emit\s*===\s*['"]function['"]/,
|
|
'guard must use typeof === \'function\' (not just truthy) to confirm emit is callable',
|
|
);
|
|
});
|