mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-25 22:31:48 +00:00
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
187 lines
7.4 KiB
JavaScript
187 lines
7.4 KiB
JavaScript
// Verify the autoplay & auto-exit option's pure decision helpers in app.js:
|
|
// - _autoplayExitEnabled() (localStorage; absence = enabled)
|
|
// - _resolvePlayerOrigin() (one-shot override → launch screen → 'home')
|
|
//
|
|
// Same isolation strategy as song_close.test.js — extract the function from
|
|
// app.js by brace-matching and run it in a vm sandbox with stubbed deps.
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const vm = require('node:vm');
|
|
|
|
const { extractFunction } = require('./test_utils');
|
|
|
|
const APP_JS = path.join(__dirname, '..', '..', 'static', 'app.js');
|
|
const SRC = fs.readFileSync(APP_JS, 'utf8');
|
|
|
|
function runEnabled(stored) {
|
|
const fnSrc = extractFunction(SRC, 'function _autoplayExitEnabled(');
|
|
const sandbox = {
|
|
localStorage: {
|
|
getItem: () => {
|
|
if (stored === '__throw__') throw new Error('private mode');
|
|
return stored;
|
|
},
|
|
},
|
|
};
|
|
vm.createContext(sandbox);
|
|
vm.runInContext(fnSrc + '\nglobalThis.__r = _autoplayExitEnabled();', sandbox);
|
|
return sandbox.__r;
|
|
}
|
|
|
|
// Fake element honoring the bits _resultsOverlayVisible() inspects.
|
|
function el({ id = '', hidden = false, visible = true } = {}) {
|
|
return {
|
|
id,
|
|
classList: { contains: (c) => c === 'hidden' && hidden },
|
|
getClientRects: () => (visible ? [{}] : []),
|
|
};
|
|
}
|
|
|
|
function runOverlay(nodes) {
|
|
const fnSrc = extractFunction(SRC, 'function _resultsOverlayVisible(');
|
|
const sandbox = { document: { querySelectorAll: () => nodes } };
|
|
vm.createContext(sandbox);
|
|
vm.runInContext(fnSrc + '\nglobalThis.__r = _resultsOverlayVisible();', sandbox);
|
|
return sandbox.__r;
|
|
}
|
|
|
|
function runResolve({ override = null, screens = [], active = null } = {}) {
|
|
const fnSrc = extractFunction(SRC, 'function _resolvePlayerOrigin(');
|
|
const sandbox = {
|
|
window: { feedBack: { _nextReturnScreen: override } },
|
|
document: {
|
|
getElementById: (id) => (screens.includes(id) ? { id } : null),
|
|
querySelector: () => (active ? { id: active } : null),
|
|
},
|
|
};
|
|
vm.createContext(sandbox);
|
|
vm.runInContext(fnSrc + '\nglobalThis.__r = _resolvePlayerOrigin();', sandbox);
|
|
return { result: sandbox.__r, override: sandbox.window.feedBack._nextReturnScreen };
|
|
}
|
|
|
|
// holdAutoExit() + _clearAutoExit() share module state; assemble them in one
|
|
// sandbox to exercise the generation guard on the returned release handle.
|
|
function buildHoldSandbox() {
|
|
const clearSrc = extractFunction(SRC, 'function _clearAutoExit(');
|
|
const holdSrc = extractFunction(SRC, 'window.feedBack.holdAutoExit = function ()');
|
|
const sandbox = { __closeCount: 0 };
|
|
sandbox.window = { feedBack: {}, closeCurrentSong: () => { sandbox.__closeCount++; } };
|
|
vm.createContext(sandbox);
|
|
vm.runInContext(`
|
|
var _autoExitTimer = null;
|
|
var _autoExitHeld = false;
|
|
var _autoExitGen = 0;
|
|
function clearTimeout() {}
|
|
${clearSrc}
|
|
${holdSrc}
|
|
globalThis.__clearAutoExit = _clearAutoExit;
|
|
globalThis.__hold = window.feedBack.holdAutoExit;
|
|
`, sandbox);
|
|
return sandbox;
|
|
}
|
|
|
|
test('hold release navigates once while the generation is current', () => {
|
|
const sb = buildHoldSandbox();
|
|
const release = sb.__hold();
|
|
release();
|
|
assert.equal(sb.__closeCount, 1);
|
|
release(); // idempotent
|
|
assert.equal(sb.__closeCount, 1);
|
|
});
|
|
|
|
test('a stale hold release no-ops after the session moves on', () => {
|
|
const sb = buildHoldSandbox();
|
|
const release = sb.__hold();
|
|
sb.__clearAutoExit(); // new playSong / song:ended bumps the generation
|
|
release();
|
|
assert.equal(sb.__closeCount, 0, 'stale release must not navigate');
|
|
});
|
|
|
|
// ── _autoplayExitEnabled ──────────────────────────────────────────────
|
|
test('autoplayExit defaults ON when the key is absent', () => {
|
|
assert.equal(runEnabled(null), true);
|
|
});
|
|
|
|
test('autoplayExit is OFF only for the explicit "0"', () => {
|
|
assert.equal(runEnabled('0'), false);
|
|
assert.equal(runEnabled('1'), true);
|
|
assert.equal(runEnabled('anything'), true);
|
|
});
|
|
|
|
test('autoplayExit falls back to ON when localStorage throws', () => {
|
|
assert.equal(runEnabled('__throw__'), true);
|
|
});
|
|
|
|
// ── _resultsOverlayVisible ────────────────────────────────────────────
|
|
test('no overlays → not visible', () => {
|
|
assert.equal(runOverlay([]), false);
|
|
});
|
|
|
|
test('a visible modal overlay defers auto-exit', () => {
|
|
assert.equal(runOverlay([el({ id: 'mg-summary' })]), true);
|
|
});
|
|
|
|
test('a hidden (.hidden) overlay does not defer', () => {
|
|
assert.equal(runOverlay([el({ id: 'mg-summary', hidden: true })]), false);
|
|
});
|
|
|
|
test('a display:none overlay (no client rects) does not defer', () => {
|
|
assert.equal(runOverlay([el({ id: 'mg-summary', visible: false })]), false);
|
|
});
|
|
|
|
test('the player screen itself never counts as a results overlay', () => {
|
|
assert.equal(runOverlay([el({ id: 'player' })]), false);
|
|
});
|
|
|
|
test('mixed: ignores player + hidden, honors a visible results overlay', () => {
|
|
assert.equal(runOverlay([
|
|
el({ id: 'player' }),
|
|
el({ id: 'stale', hidden: true }),
|
|
el({ id: 'score-card' }),
|
|
]), true);
|
|
});
|
|
|
|
// ── _resolvePlayerOrigin ──────────────────────────────────────────────
|
|
test('one-shot override wins and is consumed when its screen exists', () => {
|
|
const { result, override } = runResolve({
|
|
override: 'v3-lessons', screens: ['v3-lessons', 'plugin-tutorials'], active: 'plugin-tutorials',
|
|
});
|
|
assert.equal(result, 'v3-lessons');
|
|
assert.equal(override, null); // consumed, even though it won
|
|
});
|
|
|
|
test('override is ignored (and still consumed) when its screen is missing', () => {
|
|
const { result, override } = runResolve({
|
|
override: 'ghost-screen', screens: ['favorites'], active: 'favorites',
|
|
});
|
|
assert.equal(result, 'favorites');
|
|
assert.equal(override, null);
|
|
});
|
|
|
|
test('remembers the real launch screen', () => {
|
|
assert.equal(runResolve({ screens: ['v3-lessons'], active: 'v3-lessons' }).result, 'v3-lessons');
|
|
assert.equal(runResolve({ screens: ['favorites'], active: 'favorites' }).result, 'favorites');
|
|
});
|
|
|
|
test('dashboard launches (classic home + v3-home) return to the Songs list', () => {
|
|
assert.equal(runResolve({ screens: ['home', 'v3-songs'], active: 'home' }).result, 'v3-songs');
|
|
assert.equal(runResolve({ screens: ['v3-home', 'v3-songs'], active: 'v3-home' }).result, 'v3-songs');
|
|
});
|
|
|
|
test('v3-home falls back to itself when there is no Songs list (defensive)', () => {
|
|
assert.equal(runResolve({ screens: ['v3-home'], active: 'v3-home' }).result, 'v3-home');
|
|
});
|
|
|
|
test('classic v2 (no #v3-songs) keeps home', () => {
|
|
assert.equal(runResolve({ screens: ['home'], active: 'home' }).result, 'home');
|
|
});
|
|
|
|
test('player / unknown / no active screen fall back to home', () => {
|
|
assert.equal(runResolve({ screens: ['player'], active: 'player' }).result, 'home');
|
|
assert.equal(runResolve({ screens: [], active: 'plugin-x' }).result, 'home');
|
|
assert.equal(runResolve({ screens: [], active: null }).result, 'home');
|
|
});
|