feedBack/static/v3/live-performance-hud.js
Byron Gamatos 8f0625e1f7
fix(v3): reset live performance HUD on backward seek / restart (#607)
The v3 live performance HUD (the visible top-right score tracker) keeps
its own hits/misses/streak counters from note:hit / note:miss events and
only reset them on song load / stop / ended — not on a seek. So pressing
Restart (or scrubbing back), which only repositions the playhead and
emits song:seek, left the tracker showing the stale cumulative score
(tester report).

Mirror the notedetect HUD fix: keep a per-note {t,hit} ledger (note:hit/
note:miss carry the judgment incl. noteTime) and, on a BACKWARD song:seek,
rebuild the tally to reflect only the notes up to the new playhead
(Restart -> "Waiting for notes" / 0). Forward seeks keep earlier notes;
loop-wrap (drill mode) is skipped so a practiced A-B loop still
accumulates, matching the notedetect HUD.

Tests: +3 in tests/js/live_performance_hud.test.js (backward rebuild,
restart-to-0, forward no-op, loop-wrap ignored). Existing 10 still pass.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-27 00:47:43 +02:00

313 lines
11 KiB
JavaScript

/*
* fee[dB]ack v0.3.0 — live performance HUD (read-only overlay).
*
* Mirrors stats-recorder tallies from note:hit / note:miss events without
* writing back to scoring. Visual state thresholds are UI-only.
*/
(function (root) {
'use strict';
const STATE_CLASSES = ['is-idle', 'is-fire', 'is-strong', 'is-steady', 'is-recovery', 'is-smoke'];
const STATE_META = Object.freeze({
idle: { label: 'Waiting for notes', icon: '' },
fire: { label: 'Hot streak', icon: '\uD83D\uDD25' },
strong: { label: 'Locked in', icon: '\u2728' },
steady: { label: 'Solid run', icon: '\uD83D\uDC4D' },
recovery: { label: 'Recovering', icon: '\uD83D\uDCAA' },
smoke: { label: 'Shake it off', icon: '\uD83D\uDCA8' },
});
function accuracyPct(hits, misses) {
const judged = hits + misses;
if (judged <= 0) return null;
return Math.round((hits / Math.max(1, judged)) * 100);
}
function calculateLivePerformanceState({ hits = 0, misses = 0, streak = 0, bestStreak = 0 } = {}) {
const h = Math.max(0, Number(hits) || 0);
const m = Math.max(0, Number(misses) || 0);
const s = Math.max(0, Number(streak) || 0);
const best = Math.max(0, Number(bestStreak) || 0);
const judged = h + m;
const pct = accuracyPct(h, m);
let state = 'idle';
if (judged === 0) {
state = 'idle';
} else if (pct >= 90 && s >= 10) {
state = 'fire';
} else if (pct >= 85) {
state = 'strong';
} else if (pct >= 70) {
state = 'steady';
} else if (pct >= 50) {
state = 'recovery';
} else {
state = 'smoke';
}
const meta = STATE_META[state] || STATE_META.idle;
return {
hits: h,
misses: m,
streak: s,
bestStreak: best,
judged,
accuracyPct: pct,
state,
stateLabel: meta.label,
stateIcon: meta.icon,
};
}
function formatPercentText(stats) {
if (!stats || stats.judged === 0 || stats.accuracyPct == null) return '\u2014';
return String(stats.accuracyPct) + '%';
}
function formatHitsText(stats) {
if (!stats || stats.judged === 0) return 'Waiting for notes';
return 'Hits ' + stats.hits + ' / ' + stats.judged;
}
function formatStreakText(stats) {
if (!stats) return 'Streak 0';
return 'Streak ' + stats.streak;
}
function formatStateText(stats) {
if (!stats || stats.judged === 0) return '';
const icon = stats.stateIcon ? stats.stateIcon + ' ' : '';
return icon + stats.stateLabel;
}
function applyHudClasses(el, state) {
if (!el || !el.classList) return;
STATE_CLASSES.forEach((cls) => el.classList.remove(cls));
if (state) el.classList.add('is-' + state);
}
function renderHudDom(els, stats) {
if (!els) return stats;
const s = stats || calculateLivePerformanceState();
if (els.root) applyHudClasses(els.root, s.state);
if (els.percent) els.percent.textContent = formatPercentText(s);
if (els.hits) els.hits.textContent = formatHitsText(s);
if (els.streak) els.streak.textContent = formatStreakText(s);
if (els.state) {
els.state.textContent = formatStateText(s);
if (els.state.setAttribute) {
els.state.setAttribute('aria-hidden', s.judged === 0 ? 'true' : 'false');
}
}
return s;
}
function createCounters() {
return { hits: 0, misses: 0, streak: 0, bestStreak: 0 };
}
function bindRuntime(sm, domEls) {
if (!sm || typeof sm.on !== 'function') return null;
let active = false;
// Stay hidden until the first judged note actually arrives. note:hit /
// note:miss are emitted only by the notedetect plugin, so users without
// detection (or with it off) would otherwise see a permanent
// "Waiting for notes" overlay for the whole song.
let revealed = false;
let counters = createCounters();
// Position-aware ledger: { t: chart-note time, hit } per judged note,
// so a BACKWARD reposition (Restart button / scrub-back) can rebuild the
// visible tally to reflect only the notes up to the new playhead instead
// of keeping the stale cumulative total. Mirrors the notedetect HUD's own
// ledger (note:hit/note:miss carry the judgment, incl. noteTime). The
// running `counters` stay incremental for the live path; the ledger is
// only replayed on a seek.
let ledger = [];
const els = domEls || {
root: typeof document !== 'undefined' ? document.getElementById('v3-live-performance-hud') : null,
percent: typeof document !== 'undefined' ? document.getElementById('v3-live-performance-percent') : null,
hits: typeof document !== 'undefined' ? document.getElementById('v3-live-performance-hits') : null,
streak: typeof document !== 'undefined' ? document.getElementById('v3-live-performance-streak') : null,
state: typeof document !== 'undefined' ? document.getElementById('v3-live-performance-state') : null,
};
function setVisible(show) {
if (!els.root) return;
if (show) els.root.classList.remove('hidden');
else els.root.classList.add('hidden');
}
function resetCounters() {
counters = createCounters();
ledger = [];
}
// Chart-note time for a judgment event, or null when unknown (argless
// test calls, or a judgment without timing). note:hit/note:miss carry
// the notedetect judgment object as `detail`.
function judgmentTime(e) {
const d = e && e.detail;
if (!d) return null;
if (Number.isFinite(d.noteTime)) return d.noteTime;
if (d.chartNote && Number.isFinite(d.chartNote.t)) return d.chartNote.t;
return null;
}
// Rebuild counters from the ledger up to (excluding) chart time `t`.
// Drop judgments at/after `t` so replaying forward re-counts them, then
// replay survivors in time order through the same hit/streak rules.
function rebuildToPosition(t) {
if (!Number.isFinite(t)) return;
ledger = ledger.filter((e) => !(Number.isFinite(e.t) && e.t >= t));
const sorted = ledger.slice().sort((a, b) => (a.t == null ? -Infinity : a.t) - (b.t == null ? -Infinity : b.t));
counters = createCounters();
for (const e of sorted) {
if (e.hit) {
counters.hits++;
counters.streak++;
if (counters.streak > counters.bestStreak) counters.bestStreak = counters.streak;
} else {
counters.misses++;
counters.streak = 0;
}
}
paint();
}
function currentStats() {
return calculateLivePerformanceState(counters);
}
function paint() {
const stats = renderHudDom(els, currentStats());
try {
if (sm && typeof sm.emit === 'function') {
sm.emit('v3:live-performance-state', {
hits: stats.hits,
misses: stats.misses,
judged: stats.judged,
streak: stats.streak,
bestStreak: stats.bestStreak,
accuracyPct: stats.accuracyPct,
state: stats.state,
});
}
} catch (_) { /* venue mood and other observers must never break HUD */ }
}
function reveal() {
if (!active || revealed) return;
revealed = true;
setVisible(true);
}
function showSession() {
active = true;
revealed = false;
resetCounters();
// Primed but hidden — reveal() on the first note:hit/note:miss.
setVisible(false);
paint();
}
function hideSession() {
active = false;
revealed = false;
resetCounters();
setVisible(false);
paint();
}
function onHit(e) {
if (!active) return;
reveal();
ledger.push({ t: judgmentTime(e), hit: true });
counters.hits++;
counters.streak++;
if (counters.streak > counters.bestStreak) counters.bestStreak = counters.streak;
paint();
}
function onMiss(e) {
if (!active) return;
reveal();
ledger.push({ t: judgmentTime(e), hit: false });
counters.misses++;
counters.streak = 0;
paint();
}
sm.on('song:loading', () => { showSession(); });
sm.on('song:arrangement-changed', () => {
if (!active) return;
resetCounters();
paint();
});
sm.on('song:stop', () => { hideSession(); });
sm.on('song:ended', () => { hideSession(); });
sm.on('note:hit', onHit);
sm.on('note:miss', onMiss);
// Restart / scrub-back: rebuild the tally to the new playhead. song:seek
// is core's single repositioning funnel ({ from, to, reason }). Only a
// BACKWARD jump recomputes; a forward seek leaves earlier notes counted.
// Skip loop-wrap (drill mode) so a practiced A-B loop keeps accumulating,
// matching the notedetect HUD.
sm.on('song:seek', (e) => {
if (!active) return;
const d = (e && e.detail) || {};
if (d.reason === 'loop-wrap') return;
const to = Number(d.to);
if (!Number.isFinite(to)) return;
const from = Number(d.from);
const movedBack = Number.isFinite(from) ? (to < from - 0.05) : true;
if (!movedBack) return;
rebuildToPosition(to);
});
return {
getCounters: () => ({ ...counters }),
getStats: currentStats,
isActive: () => active,
showSession,
hideSession,
onHit,
onMiss,
rebuildToPosition,
paint,
els,
};
}
const api = {
STATE_CLASSES,
STATE_META,
accuracyPct,
calculateLivePerformanceState,
formatPercentText,
formatHitsText,
formatStreakText,
formatStateText,
applyHudClasses,
renderHudDom,
bindRuntime,
};
if (root) root.v3LivePerformanceHud = api;
if (typeof module !== 'undefined' && module.exports) module.exports = api;
if (typeof document !== 'undefined') {
const boot = () => {
const sm = root && root.feedBack;
if (sm) bindRuntime(sm);
};
if (document.readyState === 'loading') {
document.addEventListener('DOMContentLoaded', boot);
} else {
boot();
}
}
}(typeof window !== 'undefined' ? window : null));