5 Commits

Include renames

Author	SHA1	Message	Date
3 people	ebbfc8da6f	refactor(app): carve the highway string-colours out of app.js (R3a) (#883) ... static/js/highway-colors.js (601 lines) — bodies VERBATIM. app.js 10,415 → 9,837. Under 10k. DECOMPOSED, not sliced. The "settings" blob measured 47 fns / 19 inbound and was not carvable as-is. Seeding the closure from a FUNCTION (initHighwayColors) found only 18 fns and left 4 HWC_* constants used outside it — i.e. the seed was wrong, not the cluster. Re-seeding from the STATE (every function touching HWC_*/`_hwc*`) found the true cluster: 45 top-level nodes, lines 2751-3331, CONTIGUOUS, with ZERO foreign nodes inside the span. INBOUND: 0. EXPORTS: 2 (initHighwayColors, hwcInitSettingsUI). The other 43 symbols — the HWC_* tables, the 12 presets, the theme store, the share codec, the picker handlers, the window.feedBack.highwayColors facade — are used nowhere else in core and stay private. No inline on*= handlers here (the Settings buttons are wired by addEventListener inside hwcInitSettingsUI), so nothing needed re-exposing on window. The three bus listeners register inside initHighwayColors, which app.js calls — not at module top level — so no ordering change. THE no-undef GATE EARNED ITS KEEP. My closure said INBOUND=0; the module actually uses `uiPrompt` (the "name this theme" prompt). It was missed because uiPrompt is no longer an app.js DECLARATION — it's an IMPORT BINDING (from #882's dom.js), and I was collecting declarations only. `no-undef` with typeof:true caught it. => Lesson for the next carve: seed `tops` from ImportDeclaration bindings too. => And it VALIDATES carving dom.js early: this module just imports uiPrompt from it. Had dom.js still been stranded in app.js, this carve would have needed a host seam. app.js -> { plugin-loader, viz, diagnostics-export, dom, highway-colors } plugin-loader -> viz highway-colors -> dom viz, diagnostics-export, dom -> (leaves) VERIFIED BY DRIVING THE FACADE. A/B against origin/main in two browsers: window.feedBack.highwayColors installed, identical method surface, 12 presets, identical default slot colours, and a share-code encode→decode round-trip returning #112233 — IDENTICAL on both, zero console/page errors either side. Harnesses: highway_colors_facade + highway_string_colors retargeted (both brace-extract blocks out of the source by signature). pytest 2396, node 1038/1038, ESLint 0, tailwind-fresh clean, Codex 0. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-11 19:22:14 +02:00
3 people	14b4058bc6	refactor(app): carve the DOM/modal primitives out of app.js (R3a) (#882) ... static/js/dom.js (203 lines) — esc, _escAttr, _isElementVisible, _trapFocusInModal, _confirmDialog, uiPrompt. Bodies VERBATIM. app.js 10,593 → 10,414. A GATHER, not a slice — the six lived in six different places (108, 635, 659, 2617, 2623, 8892). They belong together because they are the BOTTOM of the UI stack: `esc` alone has 25 call sites and `_escAttr` 23, and every later carve that renders HTML will need them. That is the actual point of doing this one now. Give them a home and the next carve imports them; leave them in app.js and the next carve that renders HTML has to invent a host seam to reach back into app.js — exactly the trap the plugin-loader carve had to work around until the viz layer became a module. This is the cheapest possible way to stop that recurring. app.js -> { plugin-loader, viz, diagnostics-export, dom } plugin-loader -> viz viz, diagnostics-export, dom -> (nothing) Zero imports. Six exports (every one is used outside the cluster). VERIFIED BY DRIVING THE MODALS, not just booting — they are interactive, so a green suite says little. A/B against origin/main in two browsers: * window.uiPrompt / _confirmDialog / _trapFocusInModal all resolve * uiPrompt() mounts its modal, accepts typed input, and resolves with the typed value ('typed') — IDENTICAL on both * _confirmDialog() mounts and resolves true on confirm — IDENTICAL * zero console/page errors either side pytest 2396, node 1038/1038, ESLint 0, tailwind-fresh clean, Codex 0. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-11 18:59:44 +02:00
3 people	bfb31a8b89	refactor(app): carve the diagnostics-bundle export out of app.js (R3a) (#881) ... static/js/diagnostics-export.js (280 lines) — bodies VERBATIM. app.js 10,858 → 10,592. Chosen BY MEASUREMENT, not by eye. Ran the transitive closure over four candidate clusters and took the one with the smallest interface: diagnostics 7 fns 235 lines span 4110-4378 imports 1 exports 2 shortcuts-modal 5 fns 235 lines span 104-9897 imports 4 exports 5 settings+updates 47 fns 1012 lines span 1409-7636 imports 19 exports 30 library-render 220 fns 4064 lines span 20-10536 imports 126 exports 117 diagnostics is contiguous and nearly closed; its one inbound symbol (_DIAG_FILE_LABELS) lives inside the region and is read only by _renderDiagPreview, so it moves in and the module ends up a LEAF — imports nothing. app.js -> { plugin-loader, viz, diagnostics-export } plugin-loader -> viz viz, diagnostics-export -> (nothing) Exports exactly 2: previewDiagnostics + exportDiagnostics, both already in app.js's window contract (they're inline handlers in the Settings screen) — so app.js keeps re-exposing them, now as imported bindings. The preview renderer, the file-label table, and the byte/HTML formatters are used NOWHERE else in core and stay private. VERIFIED BY DRIVING IT, not just booting. Zero harnesses broke — because the diagnostics export flow had NO source-level test at all, which is exactly why a green suite proves nothing here. So the flow was exercised for real: A/B against origin/main in two browsers, window.previewDiagnostics() invoked, the preview container rendered identical content on both, both entry points resolve on window, zero console/page errors either side. pytest 2396, node 1038/1038, ESLint 0, tailwind-fresh clean, Codex 0. NOTE for the next carve: library-render is NOT a cluster — 220 functions and 126 inbound symbols is most of app.js entangled together. It cannot be carved as a unit; it needs decomposing from the inside first. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-11 18:52:47 +02:00
3 people	a222b45c02	refactor(app): carve the viz layer out of app.js — and delete the loader seam (R3a) (#880) ... static/js/viz.js (770 lines) — the viz picker, renderer selection, Auto-match, the WebGL2 probe, the 3D-promotion nag, the notation hints. Bodies VERBATIM. app.js 11,603 → 10,857. THE SEAM IS GONE. #878's plugin-loader needed configurePluginLoader({ populateVizPicker }) purely because _populateVizPicker lived in app.js and importing app.js would have closed a cycle. viz.js is a LEAF — it imports NOTHING — so plugin-loader now imports _populateVizPicker straight from it. The _host object, the configure function, its loud-default guard, and the wiring line in app.js are all deleted. The second carve simplifies the first. app.js -> { plugin-loader, viz } plugin-loader -> viz viz -> (nothing) NOT A PURE MOVE — one listener block had to be SPLIT. app.js had a single top-level `if (window.feedBack) { … }` registering four handlers, and only two were viz. song:loaded / arrangement:changed / song:ready (the mastery slider) stay in app.js and now call the imported _autoMatchViz / _maybeShowNotationViewHint. The viz:reverted handler MOVES, because it REASSIGNS _cancelPendingAutoLabel and an imported binding is read-only — `_cancelPendingAutoLabel = null` would throw if the listener stayed behind while the state moved. ORDER CHECKED, NOT ASSUMED: viz.js's song:ready listener now registers BEFORE app.js's own (imports evaluate first). Safe — _pendingPromotionNag is only ever set inside _populateVizPicker, which runs at boot/plugin-refresh, never from inside the other song:ready handler, so the two are independent. VERIFIED — the listeners are the risk here, so they were DRIVEN, not just booted. A/B against origin/main in two browsers: * viz picker: 6 options (auto|default|venue|drum_highway_3d|keys_highway_3d| highway_3d), selected highway_3d, Auto label — IDENTICAL. This alone proves plugin-loader's direct import of viz.js works. * emit('viz:reverted') -> picker resets to default, localStorage resets to default, the warning logs — IDENTICAL. The MOVED listener fires. * emit('song:ready') -> mastery slider enables, no throw — IDENTICAL. The SPLIT listener still does both halves. * plugin screens, module injections, 37 capability participants — IDENTICAL. * zero console/page errors on both. pytest 2396, node 1038/1038, ESLint 0, tailwind-fresh clean. no-cycle re-bitten on the 3-module graph (viz -> plugin-loader fails). Codex preflight raised a [P2] claiming viz.js's top-level bus guards would be false because "app.js only creates the event bus later" — FALSE POSITIVE. app.js does not create the bus; capabilities.js does, from its own <script type="module"> at index.html:122, and module scripts execute in document order, so the bus exists long before app.js's import graph evaluates. Instrumented the setter: by viz.js's turn `window.feedBack.on` is already a function, and the viz:reverted listener is provably attached (firing it resets the picker). The ordering is also enforced by test_app_shell_loads_capability_registry_before_app_runtime. Harnesses: 5 tests retargeted to viz.js across legacy_shim_hits, venue_scene_3d, venue_viz (each SPLIT — their non-viz tests still read app.js). Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-11 18:41:52 +02:00
3 people	38772f604a	refactor(app): carve the plugin loader out of app.js into static/js/ (R3a) (#878) ... The first carve, and deliberately the riskiest: app.js IS the plugin loader (the R0 host rails), so it goes first while the module graph is still one edge deep. static/js/plugin-loader.js (829 lines) — bodies VERBATIM. app.js 12,217 → 11,439. Core's first `static/js/` module, exactly as constitution II anticipates. CLOSURE (measured with acorn, not regex — brace-matching stripped source drifted): the block at app.js:11246-12031 is contiguous and self-contained. It needs only TWO things from the rest of app.js, and exports only TWO: exports: loadPlugins (the window contract), bootstrapPluginsAndUi (boot) inbound: window.showScreen — already the public host contract (constitution II), so it is called through `window`, not re-coupled as an import _populateVizPicker — injected via configurePluginLoader() WHY A SEAM, NOT AN IMPORT. plugin-loader must not import app.js: app.js imports it, so that would close a cycle. I checked whether _populateVizPicker could just move into the module instead (which would delete the seam entirely) — it drags 9 further symbols (_canRun3D, _autoMatchViz, _showPromotionNag, …), i.e. a whole viz cluster. That is its own carve, so the seam stays. THE SEAM'S DEFAULT IS LOUD, ON PURPOSE. A no-op stub is the classic silent failure for this pattern (see the editor's setHostHooks trap, hit twice): drop the wiring call and the loader keeps working while the viz picker quietly stops refreshing — no test, no boot check says a word. The default now console.errors, so the smoke harness catches it. VERIFIED BY BITE TEST: removing configurePluginLoader() from app.js surfaces "[plugin-loader] host seam not configured" at boot. The seam IS exercised on the plugin-startup path, so an unwired hook cannot pass silently. no-cycle is now LIVE on core's own graph for the first time. eslint.config.js gains `static/app.js` + `static/js/**` to the module block — app.js now `import`s, so parsing it as a script would be a syntax error. VERIFIED BY BITE TEST: making plugin-loader import app.js back fails with "Dependency cycle detected". HARNESSES (the R3a note said budget one conversion per carve — it was five): retargeted capability_inspector_nav, plugin_hydration_wipe, plugin_loader_script_type, plugin_style_injection, legacy_shim_hits (SPLIT — one test needs the loader, one still needs app.js) + test_plugin_runtime_idempotence. legacy_shim_hits was missed by a symbol-name grep because it greps for a code STRING; only the failing run found it. test_capability_events' NEGATIVE asserts now span app.js + the loader — carving code out of app.js would otherwise make them vacuous instead of failing. VERIFIED: A/B against origin/main in two browsers — mounted plugin screens, 14 loaded plugin scripts, the 3 module plugins injected as <script type="module">, 37 capability participants, 14 shims, window.loadPlugins: IDENTICAL, zero console/page errors on both. /static/js/plugin-loader.js serves 200; R0 rails intact (src/main.js 200, conditional GET 304, script_type passthrough). pytest 2396, node 1032/1032, ESLint 0, Codex 0. Codex preflight caught a REAL [P1] first pass: static/js/plugin-loader.js was untracked, so a checkout would have served an app.js importing a nonexistent module — a failed static import kills the whole module and every window handler with it. Now tracked. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-11 18:18:00 +02:00