2 Commits

Include renames

Author	SHA1	Message	Date
3 people	d9fa6d3f55	refactor(highway): make the highway global explicit before the module flip (R3c) (#912) ... 73 bare `highway.x` references -> `window.highway.x`, across app.js and 10 other files. Provably a NO-OP today. It is the precondition for flipping highway.js to a module. ━━━ WHY THIS HAS TO LAND FIRST ━━━ highway.js is a CLASSIC script. Its top-level `const highway = createHighway()` therefore creates a GLOBAL LEXICAL BINDING — visible as a bare name to every other classic script AND to every ES module. 73 call sites quietly rely on that. The moment highway.js becomes a module, that binding is gone. `const` in a module is module-scoped, not global. Every one of those 73 sites becomes a ReferenceError, and the flip is impossible until they say what they mean. `window.highway = highway` is already set, to the same object, on the same line. So this is an identity rewrite — verified in the browser below. ━━━ THE REWRITE BIT ME THREE TIMES. REGEX IS NOT ENOUGH FOR THIS. ━━━ 1. A SHADOWED LOCAL. capabilities/note-detection.js does `const highway = window.highway`. Its 9 bare uses are LOCAL and already correct; a blind rewrite would have emitted `const window.highway = window.highway`. Excluded. 2. HALF-CONVERTED GUARDS — the dangerous one. Six sites read `typeof highway !== 'undefined' && highway && typeof highway.setTime === 'function'`. The regex converted the CONSEQUENT and left the TEST, which is WORSE than not touching them: after the flip `typeof highway` is 'undefined', so each guard is PERMANENTLY FALSE and the code behind it silently never runs. transport.js's was the seek->setTime sync: the chart clock would have quietly desynced after every seek, with nothing failing. All six now test window.highway. 3. TWO MORE BARE REFERENCES, found by Codex [P2] and confirmed by an AST scan: app.js:3114 and :3176 use `highway && typeof window.highway.getSections === 'function'`. My grep searched for `typeof highway`, not `highway &&`. After the flip these throw, the catch swallows it, and the editor silently falls back to a ±4s edit window and arrangement 0. Regex missed a shadow, a half-conversion, and two bare reads. The final check is an AST pass that resolves scopes and reports every `highway` identifier not bound locally. It now reports ZERO. VERIFIED. A/B against origin/main in two browsers, 15 probes, IDENTICAL, zero page errors: window.highway is the same object as the bare global, the whole API surface resolves, a real song plays, the chart clock advances, getPerf().drawMs > 0 — and `seek syncs chart` passes, which is the exact guard I nearly broke in (2). node 1045, pytest 2416, ESLint 0, Codex 0. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-12 11:56:07 +02:00
3 people	8d0e270345	refactor(app): carve the JUCE/desktop audio shims out of app.js (R3a) (#893) ... * refactor(app): carve resume-session out of app.js (R3a) static/js/resume-session.js (157) — the snapshot taken when you leave a song and the pill that offers it back. Bodies VERBATIM. app.js 7,727 → 7,601. Fifth slice out of the strongly-connected core. ONE hook (playSong) + a currentFilename getter. S.pendingResume JOINS THE CONTAINER — on demand, exactly as intended. app.js WRITES it (playSong({ resume }) arms it; the song:ready listener consumes it) while this module reads it, so it cannot be a plain export: an imported binding is read-only. Same reason isPlaying is there. The container grows one field per carve that needs it, never speculatively. THE CONTRACT TEST CAUGHT THE MISSING HOOK, again on a path nothing executes: "playSong is read by a module but never wired by app.js — it would throw at runtime". Second time it has caught a real wiring gap the moment it appeared. A REAL TRAP, worth remembering: I first did the S.pendingResume rewrite by feeding acorn's identifier RANGES from node into python, and it corrupted the file (`_pS.pendingResume null;`). **Acorn's offsets are UTF-16 code units; Python's string indices are code points.** static/app.js contains emoji, so every offset past one drifts. Do an AST-driven rewrite in the SAME language that produced the offsets. `node --check` caught it; a silent version of that bug is very easy to imagine. VERIFIED. A/B against origin/main in two browsers, real song: the window API (resumeLastSession / _snapshotResumeSession / _readResumeSession / _clearResumeSession), snapshot, read-back, and clear — IDENTICAL, zero page errors. HONEST LIMIT: my probe never got the snapshot to actually PERSIST (there is a guard beyond the 3s minimum position that a scripted playSong does not satisfy), so that path is verified only as identical-to-main, not as observed-working. The real coverage is tests/browser/resume-session.spec.ts, which drives the flow properly. Zero harnesses broke. pytest 2396, node 1040/1040, ESLint 0 (no-cycle clean), tailwind clean, Codex 0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(app): carve the JUCE/desktop audio shims out of app.js (R3a) static/js/juce-audio.js (994) — bodies VERBATIM. app.js 7,603 → 6,643. THE LARGEST SINGLE SLICE of the whole carve phase: 960 lines, ~13% of what was left. Three self-installing IIFEs: _installJuceEngineRoutingWatcher (444) routes a song to the JUCE engine or HTML5 as the desktop output enters/leaves exclusive/ASIO _installRendererBusFeeder (337) feeds the highway renderer bus from whichever transport is actually running _installJuceAudioElementShim (156) patches audio.play/pause so the rest of the app keeps talking to the <audio> element while JUCE owns the transport They EXPORT NOTHING — all three publish through `window.*` (_juceMode, _reevaluateJuceRouting, _reevaluateRendererBus, …). So app.js needs only a side-effect import plus the one binding it actually uses (_resetJuceAudioShimChain, which the shim IIFE assigns). THE ORDERING QUESTION, CHECKED RATHER THAN ASSUMED. Importing this module runs the IIFEs EARLIER than before: imports evaluate ahead of app.js's body, and therefore ahead of configureHost(). A hook read at IIFE-execution time would THROW. So I walked the AST at IIFE-body depth to see what they actually touch when they run: nothing but listener registration, and `audio.play`/`audio.pause` patching — and `audio` is itself an imported module now. Verified in the browser: both are patched on the carved build exactly as on main, which proves the shim installs correctly at its new, earlier point. (Had I got this wrong, host.js throws loudly rather than silently misbehaving — which is the whole reason it has no no-op defaults.) VERIFIED. A/B against origin/main in two browsers: the entire window.* surface the IIFEs publish (_juceMode, _juceOutputIsExclusive, _reevaluateJuceRouting, _reevaluateRendererBus, _clearJuceRerouteMemo), audio.play/pause patched, a real song loading and togglePlay driving the public mirror — IDENTICAL, zero page errors. Harnesses: juce_engine_reroute (19 tests) + renderer_bus_feeder (13) slice the IIFEs by signature — retargeted, and each sandbox gains a `host` object routed at its EXISTING stubs so every assertion holds unchanged. test_plugin_runtime_idempotence is SPLIT: 3 of its 4 source-asserts stayed in app.js, the sm.emit('song:resume') one moved. pytest 2396, node 1040/1040, ESLint 0 (no-cycle clean), tailwind clean, Codex 0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-11 22:44:03 +02:00