2 Commits

Include renames

Author	SHA1	Message	Date
3 people	8d0e270345	refactor(app): carve the JUCE/desktop audio shims out of app.js (R3a) (#893) ... * refactor(app): carve resume-session out of app.js (R3a) static/js/resume-session.js (157) — the snapshot taken when you leave a song and the pill that offers it back. Bodies VERBATIM. app.js 7,727 → 7,601. Fifth slice out of the strongly-connected core. ONE hook (playSong) + a currentFilename getter. S.pendingResume JOINS THE CONTAINER — on demand, exactly as intended. app.js WRITES it (playSong({ resume }) arms it; the song:ready listener consumes it) while this module reads it, so it cannot be a plain export: an imported binding is read-only. Same reason isPlaying is there. The container grows one field per carve that needs it, never speculatively. THE CONTRACT TEST CAUGHT THE MISSING HOOK, again on a path nothing executes: "playSong is read by a module but never wired by app.js — it would throw at runtime". Second time it has caught a real wiring gap the moment it appeared. A REAL TRAP, worth remembering: I first did the S.pendingResume rewrite by feeding acorn's identifier RANGES from node into python, and it corrupted the file (`_pS.pendingResume null;`). **Acorn's offsets are UTF-16 code units; Python's string indices are code points.** static/app.js contains emoji, so every offset past one drifts. Do an AST-driven rewrite in the SAME language that produced the offsets. `node --check` caught it; a silent version of that bug is very easy to imagine. VERIFIED. A/B against origin/main in two browsers, real song: the window API (resumeLastSession / _snapshotResumeSession / _readResumeSession / _clearResumeSession), snapshot, read-back, and clear — IDENTICAL, zero page errors. HONEST LIMIT: my probe never got the snapshot to actually PERSIST (there is a guard beyond the 3s minimum position that a scripted playSong does not satisfy), so that path is verified only as identical-to-main, not as observed-working. The real coverage is tests/browser/resume-session.spec.ts, which drives the flow properly. Zero harnesses broke. pytest 2396, node 1040/1040, ESLint 0 (no-cycle clean), tailwind clean, Codex 0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(app): carve the JUCE/desktop audio shims out of app.js (R3a) static/js/juce-audio.js (994) — bodies VERBATIM. app.js 7,603 → 6,643. THE LARGEST SINGLE SLICE of the whole carve phase: 960 lines, ~13% of what was left. Three self-installing IIFEs: _installJuceEngineRoutingWatcher (444) routes a song to the JUCE engine or HTML5 as the desktop output enters/leaves exclusive/ASIO _installRendererBusFeeder (337) feeds the highway renderer bus from whichever transport is actually running _installJuceAudioElementShim (156) patches audio.play/pause so the rest of the app keeps talking to the <audio> element while JUCE owns the transport They EXPORT NOTHING — all three publish through `window.*` (_juceMode, _reevaluateJuceRouting, _reevaluateRendererBus, …). So app.js needs only a side-effect import plus the one binding it actually uses (_resetJuceAudioShimChain, which the shim IIFE assigns). THE ORDERING QUESTION, CHECKED RATHER THAN ASSUMED. Importing this module runs the IIFEs EARLIER than before: imports evaluate ahead of app.js's body, and therefore ahead of configureHost(). A hook read at IIFE-execution time would THROW. So I walked the AST at IIFE-body depth to see what they actually touch when they run: nothing but listener registration, and `audio.play`/`audio.pause` patching — and `audio` is itself an imported module now. Verified in the browser: both are patched on the carved build exactly as on main, which proves the shim installs correctly at its new, earlier point. (Had I got this wrong, host.js throws loudly rather than silently misbehaving — which is the whole reason it has no no-op defaults.) VERIFIED. A/B against origin/main in two browsers: the entire window.* surface the IIFEs publish (_juceMode, _juceOutputIsExclusive, _reevaluateJuceRouting, _reevaluateRendererBus, _clearJuceRerouteMemo), audio.play/pause patched, a real song loading and togglePlay driving the public mirror — IDENTICAL, zero page errors. Harnesses: juce_engine_reroute (19 tests) + renderer_bus_feeder (13) slice the IIFEs by signature — retargeted, and each sandbox gains a `host` object routed at its EXISTING stubs so every assertion holds unchanged. test_plugin_runtime_idempotence is SPLIT: 3 of its 4 source-asserts stayed in app.js, the sm.emit('song:resume') one moved. pytest 2396, node 1040/1040, ESLint 0 (no-cycle clean), tailwind clean, Codex 0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-11 22:44:03 +02:00
3 people	5fb28d5c5a	refactor(app): lift the shared player state onto a container (R3a) (#889) ... static/js/player-state.js — one exported object, two fields. app.js's 70 reference sites rewritten. Provably a no-op; nothing shrinks. WHY NOW. Every slice carved out of app.js so far only ever READ the state it shared (loopA/loopB, _audioSeekGen, currentFilename), so a read-only getter hook was enough and no container was needed — twice I checked and twice I got away with it. That runs out at count-in: it genuinely WRITES `isPlaying` (it starts and stops playback, 4 sites) and `lastAudioTime` (2). `import { isPlaying }` then `isPlaying = true` THROWS — an imported binding cannot be assigned to. So the state has to live on an object: `S.isPlaying = true` is a property write, and works from any module holding the same S. Same shape stems, studio, and editor all converged on. DELIBERATELY SMALL. app.js has ~104 top-level `let` scalars; lifting all of them is a ~977-site rewrite for no benefit, because most are private to one cluster and travel with it. Only what a carved module must WRITE goes here. Add on demand. THE REWRITE IS AST-DRIVEN, NOT TEXTUAL — and that is not fussiness. Of 100 textual occurrences of these two names, only 70 resolve to the module binding: * 22 are member accesses (`someObj.isPlaying`, `window.feedBack.isPlaying`) * 4 are the LOCAL PARAMETER of `function setPlayButtonState(isPlaying)` — a blind replace yields `function setPlayButtonState(S.isPlaying)` * 1 is an object key * 2 are shorthand properties `{ isPlaying }`, which must become `{ isPlaying: S.isPlaying }` — and acorn gives a shorthand's key and value the SAME range, so rewriting both produced `isPlaying: S.isPlaying: S.isPlaying` until I deduped by range A find-and-replace corrupts all 29. The rewrite walks the AST, skips shadows, member properties and keys, and replaces identifier RANGES. `window.feedBack.isPlaying` — the PUBLIC mirror — is a different thing and is untouched. Two test sandboxes stub it; those were left alone deliberately. VERIFIED WITH REAL PLAYBACK. A/B against origin/main in two browsers, real song: togglePlay -> the public mirror goes true -> false -> true across two toggles, the audio element's paused state follows, seekBy works — IDENTICAL, zero page errors. Harnesses: 8 vm-sandbox suites slice playback code out of app.js and now see S.isPlaying — juce_engine_reroute, loop_restart, play_button_reroute_guard, playback_app_adapter, song_restart, song_seek, speed_reset, and the python idempotence source-assert. Each gets the same container in its sandbox; every assertion is unchanged. pytest 2396, node 1040/1040, ESLint 0, tailwind clean, Codex 0. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-11 21:52:51 +02:00