fix(gp8): confine registry asset matching to the declared directory (#1011)

`<EmbeddedFilePath>` is matched on filename stem so a format variant of the
same recording can win — an `.ogg` beside the declared `.mp3` is copied out
losslessly rather than transcoded. But the search spanned every directory in
the archive, so an unrelated file that merely shared the stem could stand in
for the declared asset: exactly the substitution the registry lookup added in
#1007 exists to prevent.

Candidates are now confined to the registry path's own directory. A genuinely
absent asset still falls through to the legacy stem match and then the first
audio asset, as documented.

Found by an adversarial pass over #1007 rather than a report — no known file
triggers it, since GP8 writes embedded audio to Content/Assets/ and that is
the only directory scanned. It needs a hand-edited archive to reach.

Both tests fail on main and pass here; their ZIP ordering is deliberate, so
the fall-through target differs from the decoy (otherwise fixed and unfixed
code return the same file and the tests prove nothing).


Claude-Session: https://claude.ai/code/session_01SFDokqh2H6mEjk1Kgbi6JW

Signed-off-by: ChrisBeWithYou <christian.a.cowan@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

lib/gp8_audio_sync.py

@@ -165,12 +165,20 @@ def _resolve_audio_asset(zf, root=None) -> tuple[str, str | None]:
         #    stale/edited entry must fall through, not resolve to nothing.
         registry_path = _asset_path_from_registry(root, declared)
         if registry_path:
+            # Matched on STEM, not the whole path, so a format variant of the
+            # same recording can win (see _prefer_ogg) — but constrained to the
+            # directory the registry actually named. Without that constraint an
+            # unrelated file that merely shares the stem could stand in for the
+            # declared asset, which is the failure the registry lookup exists
+            # to prevent.
+            declared_path = Path(registry_path)
             same_stem = [
                 n for n in audio_files
-                if Path(n).stem == Path(registry_path).stem
+                if Path(n).stem == declared_path.stem
+                and Path(n).parent == declared_path.parent
             ]
             if same_stem:
-                return Path(registry_path).stem, _prefer_ogg(same_stem)
+                return declared_path.stem, _prefer_ogg(same_stem)
             _log.warning(
                 'gp8_audio_sync: AssetId %r maps to %r, which is not an audio '
                 'asset in the archive; falling back',