got-feedBack/feedBack
1
0
Fork 0
mirror of https://github.com/got-feedBack/feedBack.git synced 2026-08-11 19:29:33 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Improve wording in terminology cleanup

Browse Source 
Replace the placeholder noun left by the previous pass with context-fit
phrasing (arrangement XML, chart, custom songs, etc.).
This commit is contained in:
Sin
2026-06-16 19:43:45 +01:00
parent 4148b0e72e
commit c1870a0597
11 changed files with 38 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/gp2rs.py
+13 -13
View File
@@ -1,4 +1,4 @@
"""Convert Guitar Pro files (.gp5/.gp4/.gp3) to the source game arrangement XML."""
"""Convert Guitar Pro files (.gp5/.gp4/.gp3) to arrangement XML."""
import logging
import re
@@ -544,7 +544,7 @@ def convert_track(
*,
expand_repeats: bool = True,
) -> str:
"""Convert a GP track to the source game arrangement XML string.
"""Convert a GP track to arrangement XML string.
Args:
song: Parsed Guitar Pro song
@@ -558,7 +558,7 @@ def convert_track(
once in authored order — equivalent to the pre-expansion behavior.
Returns:
XML string of the the source game arrangement
XML string of the chart arrangement
"""
track = song.tracks[track_index]
num_strings = len(track.strings)
@@ -1149,7 +1149,7 @@ def list_tracks(gp_path: str) -> list[dict]:
def auto_select_tracks(gp_path: str) -> tuple[list[int], dict[int, str]]:
"""Auto-select guitar/bass/keys tracks and assign the source game arrangement names.
"""Auto-select guitar/bass/keys tracks and assign the standard arrangement names.
Includes piano/keyboard tracks as "Keys" arrangements alongside
guitar and bass tracks.
@@ -1205,7 +1205,7 @@ def auto_select_tracks(gp_path: str) -> tuple[list[int], dict[int, str]]:
role = "bass" if t["is_bass"] else "guitar"
selected.append((t["index"], role))
# Assign the source game names: Lead, Rhythm, Combo, Bass, Keys, Drums
# Assign the standard arrangement names: Lead, Rhythm, Combo, Bass, Keys, Drums
track_indices = []
name_map = {}
lead_count = 0
@@ -1243,14 +1243,14 @@ def convert_piano_track(
*,
expand_repeats: bool = True,
) -> str:
"""Convert a GP piano/keyboard track to the source game XML using MIDI encoding.
"""Convert a GP piano/keyboard track to arrangement XML using MIDI encoding.
Encodes MIDI notes into the source game's string+fret format:
Encodes MIDI notes into the string+fret format:
string = midi_note // 24
fret = midi_note % 24
This gives a range of 0-143, covering the full piano range within
the source game's 6-string x 24-fret structure. The piano highway plugin
the 6-string x 24-fret structure. The piano highway plugin
decodes back via: midi = string * 24 + fret.
Honors GP repeat brackets and D.S./D.C./Coda/Fine jumps when
@@ -1342,7 +1342,7 @@ def convert_piano_track(
base_midi = 60 # fallback to middle C
midi_note = base_midi + note.value
# Encode into the source game string+fret
# Encode into the string+fret
rs_string = midi_note // 24
rs_fret = midi_note % 24
@@ -1449,9 +1449,9 @@ def convert_drum_track(
*,
expand_repeats: bool = True,
) -> str:
"""Convert a GP drum/percussion track to the source game XML using MIDI encoding.
"""Convert a GP drum/percussion track to arrangement XML using MIDI encoding.
Encodes MIDI drum note numbers into the source game's string+fret format:
Encodes MIDI drum note numbers into the string+fret format:
string = midi_note // 24
fret = midi_note % 24
@@ -1534,7 +1534,7 @@ def convert_drum_track(
if midi_note not in GM_DRUM_MAP:
continue # Skip unknown percussion sounds
# Encode into the source game string+fret
# Encode into the string+fret
rs_string = midi_note // 24
rs_fret = midi_note % 24
@@ -1778,7 +1778,7 @@ def convert_file(
*,
expand_repeats: bool = True,
) -> list[str]:
"""Convert a GP file to the source game XMLs.
"""Convert a GP file to arrangement XMLs.
Args:
gp_path: Path to .gp5/.gp4/.gp3 file