refactor(server): extract the song routes into routers/song.py (R3) (#864)

mirror of https://github.com/got-feedBack/feedBack.git synced 2026-08-11 03:09:57 +00:00

Upload/delete, the catalog-metadata write-back, user-meta, overrides, gap-fill,
and the per-song info payload (11 routes) move to lib/routers/song.py with their
exclusive helpers (the atomic upload commit + the song-IO lock, the upload caps,
the gap-fill proposal builders). Bodies verbatim except @app->@router and the
seam reads: meta_db->appstate.meta_db, art_override_paths->appstate.art_override_paths,
and the scan/ingest helpers that stay in server.py (the scan lifecycle owns them)
-> new appstate seam callables: kick_scan, invalidate_song_caches, stat_for_cache,
and scan_status() (a getter — the underlying dict is reassigned). The gap-fill
MBID/ISRC regexes are reached as enrichment.X; _MULTIPART_OVERHEAD_SLACK (shared
with the staying AcoustID-identify route) moves to lib/enrichment.py beside
_ACOUSTID_MAX_UPLOAD_BYTES.

ROUTE ORDER: song_router mounts AFTER art_router — get_song_info's catch-all
`/api/song/{filename:path}` would otherwise shadow `/api/song/{path}/art*`
(Starlette matches first-registered; the :path converter is greedy).

server.py: 4,478 -> 3,692 (-786).

Verified: pyflakes clean; ORDERED route table preserves the specific-before-catch-all
invariant; full pytest 2397 passed (incl the art/cover 304 + CAA-fetch tests that
caught the shadowing before it was fixed). eslint 0.

BEHAVIORAL — needs an on-device pass (upload a sloppak, edit metadata write-back,
delete a song) before merge.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

This commit is contained in:

Byron Gamatos

2026-07-11 13:14:52 +02:00

committed by

GitHub

co-authored by

Claude Opus 4.8

parent 7258e1066a

commit bbdff4e10f

6 changed files with 901 additions and 807 deletions

									
										lib/enrichment.py
									
		+4
		
												View File
												
				@@ -233,6 +233,10 @@ def _mb_search_release_groups(query: str, limit: int = 8) -> list[dict]:

				_ACOUSTID_MAX_UPLOAD_BYTES = 256 * 1024 * 1024  # 256 MB — an uncompressed master

				# Slack for the multipart envelope on the Content-Length pre-parse guard, shared

				# by the AcoustID-identify route (server.py) and the song-upload route

				# (routers/song.py). The real per-file cap is the streaming check downstream.

				_MULTIPART_OVERHEAD_SLACK = 1024 * 1024  # 1 MiB

				def _fpcalc_bin() -> str | None: