got-feedBack/feedBack
1
0
Fork 0
mirror of https://github.com/got-feedBack/feedBack.git synced 2026-09-12 21:38:31 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(audio-input): open-source returns the actually-bound device (read-back)

Browse Source 
openInputSource() surfaces the provider's bound device on the command return
(payload.bound = { type, name }) for the trusted in-process caller, so a silent
wrong-device substitution can be detected. Kept out of the redacted source-opened
event + diagnostics snapshot (raw device names are PII). Purely additive.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
byrongamatos
2026-06-29 23:31:26 +02:00
co-authored by Claude Opus 4.8
parent a732e1f9d2
commit b5d5339afd
3 changed files with 41 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/js/audio_session_input.test.js
+29
View File
@@ -281,6 +281,35 @@ test('open-source and close-source record outcomes events and no live handles',
assert.equal(encoded.includes('token=abc'), false);
});
test('open-source returns the actually-bound device for read-back without leaking it into diagnostics', async () => {
const window = loadAudioSession();
const api = window.feedBack.capabilities;
const openedEvents = captureEvents(window, 'audio-input:source-opened');
await registerSource(api, {
sourceId: 'readback-source',
logicalSourceKey: 'test:readback',
operationHandlers: {
'source.open': () => ({ outcome: 'handled', status: 'open', payload: { boundType: 'CoreAudio', boundName: 'BlackHole 16ch', requestedName: 'BlackHole 16ch' } }),
'source.close': () => ({ outcome: 'handled', status: 'closed' }),
},
});
await api.dispatch({ capability: 'audio-input', command: 'select-source', source: 'user', payload: { logicalSourceKey: 'test:readback' } });
const open = await api.dispatch({ capability: 'audio-input', command: 'open-source', source: 'note_detect', payload: { requesterId: 'note_detect', purpose: 'note-detection' } });
// The trusted in-process caller (input_setup's confirmation gate) gets the real bound device,
// so it can show "Now listening to: <device>" and catch a silent wrong-mic substitution.
assert.equal(open.outcome, 'handled');
assert.equal(open.payload.bound.type, 'CoreAudio');
assert.equal(open.payload.bound.name, 'BlackHole 16ch');
// ...but a raw device name is PII: it must NOT reach the emitted event or the diagnostics snapshot.
assert.equal(openedEvents.length, 1);
assert.equal('bound' in openedEvents[0], false);
const encoded = JSON.stringify(window.feedBack.audioSession.snapshot());
assert.equal(encoded.includes('BlackHole'), false);
});
test('open-source reports no-owner no-handler unsupported failed and malformed provider data distinctly', async () => {
const window = loadAudioSession();
const api = window.feedBack.capabilities;