From af611770aa3372e78bb51b1f711f57c5d301b9e4 Mon Sep 17 00:00:00 2001 From: Byron Gamatos Date: Tue, 14 Jul 2026 14:07:24 +0200 Subject: [PATCH] test(career): assert exact arena manifest mappings (#962) CodeRabbit follow-up on #961: presence checks alone would pass with swapped loop filenames; assert the full loops/stingers/sfx objects. Co-authored-by: Claude Fable 5 --- tests/js/career_plugin.test.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/js/career_plugin.test.js b/tests/js/career_plugin.test.js index 46d8e54..d2b9d9b 100644 --- a/tests/js/career_plugin.test.js +++ b/tests/js/career_plugin.test.js @@ -55,8 +55,12 @@ test('arena venue pack ships with full media in the plugin checkout', () => { const packDir = path.join(PLUGIN_DIR, 'venue-packs', 'arena'); const manifest = JSON.parse(fs.readFileSync(path.join(packDir, 'manifest.json'), 'utf8')); assert.equal(manifest.venue, 'arena'); - assert.deepEqual(Object.keys(manifest.loops).sort(), - ['bored', 'ecstatic', 'engaged', 'neutral']); + assert.deepEqual(manifest.loops, { + bored: 'bored.mp4', neutral: 'neutral.mp4', + engaged: 'engaged.mp4', ecstatic: 'ecstatic.mp4', + }); + assert.deepEqual(manifest.stingers, { clap: 'clap.mp4', cheer: 'cheer.mp4' }); + assert.deepEqual(manifest.sfx, { up: 'sfx-up.mp3', down: 'sfx-down.mp3' }); assert.equal(manifest.intro.video, 'intro.mp4'); assert.equal(manifest.intro.audio, 'arena-ambience.mp3'); for (const f of [