got-feedBack/feedBack
1
0
Fork 0
mirror of https://github.com/got-feedBack/feedBack.git synced 2026-08-11 19:29:33 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

rename: slopsmith → feedBack, byron → got-feedBack (#537)

Browse Source 
* Update GitHub repo references from feedback* to feedBack*

* rename: slopsmith -> feedBack, byron -> got-feedBack

Renames across the entire codebase:
- slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack
- byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack
- /home/byron/ -> /opt/got-feedBack/
- byron@ougsoft.com -> hi@got-feedBack.org
- github.com/byrongamatos/ -> github.com/got-feedback/
- com.byron. -> com.got-feedback.
- SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback
- Protocol/storage strings migrated with read-old/write-new pattern
- window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias

Refs: #rename-slopsmith

* rename: complete regen against current main + fix backward-compat alias

Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of
current main (3 commits had landed since the branch: #572/#554/#574),
resolving the four content conflicts in favour of main's newer content
(autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge).

Completion fixes on top of the mechanical rename:
- Re-apply rename to post-branch content the original rename never saw:
  window.slopsmith(.Tour) consumers in lessons.js / notifications.js /
  onboarding-tour.js, and the matching JS + python tests (autoplay_exit,
  progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env
  vars now match server.py (which reads FEEDBACK_SYNC_STARTUP /
  FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real
  path again.
- Restore the window.slopsmith backward-compat alias dropped during conflict
  resolution, and move the bus aliases to AFTER the _feedBackExisting merge
  block so they reference the fully-assembled object (also fixes the
  loop_api.test.js API-surface regex, which the original PR latently broke).
- Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR)
  and gitignore it.
- Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped
  source labels.

Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669
passed / 1683 collected with 0 import errors; zero residual slopsmith/byron
except the two intentional window.slopsmith aliases.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* rename: implement advertised backward-compat + prune dead community plugins

Address gaps where PR #537's "Backward compatibility" section was advertised
but not implemented, and clean up the community plugin list.

Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured):
- New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py
  (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and
  tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI /
  SLOPSMITH_PLUGINS_DIR / etc. deployments keep working.
- Fix the rename collapsing plugins/__init__.py and minigames/routes.py from
  `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant
  `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost).

Storage (app.js update-channel):
- Read feedBack-update-channel, fall back to legacy slopsmith-update-channel,
  and clear the legacy key on write — so a user's update-channel preference
  survives the rename instead of resetting to "stable".

Community plugin list (README): the rename rewrote third-party repo URLs we
don't own. Probed every one; their owners never renamed, so:
- Restore the 13 live community plugins to their real slopsmith-* names.
- Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex
  tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle).
- Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory).

Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors,
rename-sensitive + startup suites green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: byrongamatos <xasiklas@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bret Mogilefsky
2026-06-23 11:03:01 +02:00
committed by GitHub
co-authored by Claude Opus 4.8 byrongamatos
parent a8ad02739a
commit af2949677a
257 changed files with 2389 additions and 2293 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_startup_status.py
+18 -18
View File
@@ -1,6 +1,6 @@
"""Tests for GET /api/startup-status — shape, field types, and the
_set_startup_status / _get_startup_status state helpers introduced in
the async plugin-loading PR (slopsmith#115).
the async plugin-loading PR (feedBack#115).
"""
import importlib
@@ -51,14 +51,14 @@ _FAKE_PLUGIN_ERROR_EVENTS = [
def client(tmp_path, monkeypatch, isolate_logging):
"""TestClient with CONFIG_DIR isolated in a per-test tmp_path.
SLOPSMITH_SYNC_STARTUP=1 makes the plugin-loader run synchronously
FEEDBACK_SYNC_STARTUP=1 makes the plugin-loader run synchronously
inside startup_events() so startup is complete before TestClient.__enter__
returns — no threading races, no polling. load_plugins is still stubbed
to a no-op so the "load" takes microseconds and startup_scan is also
suppressed to avoid unrelated background I/O during tests.
"""
monkeypatch.setenv("CONFIG_DIR", str(tmp_path))
monkeypatch.setenv("SLOPSMITH_SYNC_STARTUP", "1")
monkeypatch.setenv("FEEDBACK_SYNC_STARTUP", "1")
sys.modules.pop("server", None)
server = importlib.import_module("server")
# Stub out the two background callables that call _set_startup_status.
@@ -67,7 +67,7 @@ def client(tmp_path, monkeypatch, isolate_logging):
monkeypatch.setattr(server, "load_plugins", lambda *a, **kw: None)
monkeypatch.setattr(server, "startup_scan", lambda: None)
with TestClient(server.app) as test_client:
# With SLOPSMITH_SYNC_STARTUP the loader ran inline during startup, so
# With FEEDBACK_SYNC_STARTUP the loader ran inline during startup, so
# the status must already be complete. Poll briefly as a safety net in
# case something unexpected deferred the update.
deadline = time.monotonic() + 5.0
@@ -102,8 +102,8 @@ def startup_harness(tmp_path, monkeypatch, isolate_logging):
closes the meta_db connection.
"""
monkeypatch.setenv("CONFIG_DIR", str(tmp_path))
monkeypatch.setenv("SLOPSMITH_SYNC_STARTUP", "1")
monkeypatch.delenv("SLOPSMITH_DEMO_MODE", raising=False)
monkeypatch.setenv("FEEDBACK_SYNC_STARTUP", "1")
monkeypatch.delenv("FEEDBACK_DEMO_MODE", raising=False)
sys.modules.pop("server", None)
server = importlib.import_module("server")
monkeypatch.setattr(server, "startup_scan", lambda: None)
@@ -590,7 +590,7 @@ def test_startup_status_e2e_real_plugin_loader(tmp_path, monkeypatch, isolate_lo
Unlike the fake-load_plugins test, a regression in the plugin loader's
emitted phase order or a missing phase will cause this test to fail.
Unlike the sync-mode transition tests, this omits SLOPSMITH_SYNC_STARTUP so
Unlike the sync-mode transition tests, this omits FEEDBACK_SYNC_STARTUP so
the background thread runs and route registration is marshalled back onto the
event loop via call_soon_threadsafe — the path the production server uses.
"""
@@ -617,7 +617,7 @@ def test_startup_status_e2e_real_plugin_loader(tmp_path, monkeypatch, isolate_lo
# Override the plugin loader's built-in directory to our isolated test
# plugins root so real installed plugins don't affect the phase sequence.
monkeypatch.setattr(plugins_mod, "PLUGINS_DIR", plugins_root)
monkeypatch.delenv("SLOPSMITH_PLUGINS_DIR", raising=False)
monkeypatch.delenv("FEEDBACK_PLUGINS_DIR", raising=False)
# _PIP_TARGET is computed from CONFIG_DIR at plugins import time, so it
# may point at a previous test's tmp dir or the system /config path.
@@ -625,12 +625,12 @@ def test_startup_status_e2e_real_plugin_loader(tmp_path, monkeypatch, isolate_lo
# for our test plugin) stay fully isolated.
monkeypatch.setattr(plugins_mod, "_PIP_TARGET", tmp_path / "pip_packages")
# Set up server WITHOUT SLOPSMITH_SYNC_STARTUP so startup_events() spawns
# Set up server WITHOUT FEEDBACK_SYNC_STARTUP so startup_events() spawns
# the real background thread and route registration is marshalled back onto
# the event loop via call_soon_threadsafe (the production path).
monkeypatch.setenv("CONFIG_DIR", str(tmp_path))
monkeypatch.delenv("SLOPSMITH_SYNC_STARTUP", raising=False)
monkeypatch.delenv("SLOPSMITH_DEMO_MODE", raising=False)
monkeypatch.delenv("FEEDBACK_SYNC_STARTUP", raising=False)
monkeypatch.delenv("FEEDBACK_DEMO_MODE", raising=False)
sys.modules.pop("server", None)
server = importlib.import_module("server")
monkeypatch.setattr(server, "startup_scan", lambda: None)
@@ -716,21 +716,21 @@ def test_startup_status_e2e_real_plugin_loader(tmp_path, monkeypatch, isolate_lo
def test_startup_status_endpoint_background_thread_path(tmp_path, monkeypatch, isolate_logging):
"""Verify /api/startup-status reflects the correct terminal state when the
background-thread code path is used (SLOPSMITH_SYNC_STARTUP not set).
background-thread code path is used (FEEDBACK_SYNC_STARTUP not set).
All other transition tests force SLOPSMITH_SYNC_STARTUP=1, which exercises
All other transition tests force FEEDBACK_SYNC_STARTUP=1, which exercises
only the inline branch of startup_events(). In production the loader runs
in a background thread; thread handoff bugs (missed progress events, route
marshalling failures, races while the UI polls /api/startup-status) would
go undetected by the sync-only tests.
This test omits SLOPSMITH_SYNC_STARTUP so startup_events() spawns the real
This test omits FEEDBACK_SYNC_STARTUP so startup_events() spawns the real
background thread, then polls the HTTP endpoint until running=False and
asserts the terminal contract.
"""
monkeypatch.setenv("CONFIG_DIR", str(tmp_path))
monkeypatch.delenv("SLOPSMITH_SYNC_STARTUP", raising=False)
monkeypatch.delenv("SLOPSMITH_DEMO_MODE", raising=False)
monkeypatch.delenv("FEEDBACK_SYNC_STARTUP", raising=False)
monkeypatch.delenv("FEEDBACK_DEMO_MODE", raising=False)
sys.modules.pop("server", None)
server = importlib.import_module("server")
@@ -794,8 +794,8 @@ def test_startup_status_endpoint_background_thread_failure(tmp_path, monkeypatch
the async thread never publishes running=False or phase='error' is caught.
"""
monkeypatch.setenv("CONFIG_DIR", str(tmp_path))
monkeypatch.delenv("SLOPSMITH_SYNC_STARTUP", raising=False)
monkeypatch.delenv("SLOPSMITH_DEMO_MODE", raising=False)
monkeypatch.delenv("FEEDBACK_SYNC_STARTUP", raising=False)
monkeypatch.delenv("FEEDBACK_DEMO_MODE", raising=False)
sys.modules.pop("server", None)
server = importlib.import_module("server")