mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-11 03:09:57 +00:00
rename: slopsmith → feedBack, byron → got-feedBack (#537)
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bret Mogilefsky
co-authored by
Claude Opus 4.8
byrongamatos
Claude Opus 4.8
byrongamatos
parent
a8ad02739a
commit
af2949677a
+25
-25
@@ -39,7 +39,7 @@ def _isolate_logging(isolate_logging):
|
||||
def _setup(monkeypatch, *, fmt: str = "json", level: str = "DEBUG") -> tuple:
|
||||
"""Configure logging with the given env vars and return (logger, capture_buf).
|
||||
|
||||
Returns a stdlib logger under the slopsmith hierarchy and a StringIO buffer
|
||||
Returns a stdlib logger under the feedBack hierarchy and a StringIO buffer
|
||||
wired to the console handler's stream.
|
||||
"""
|
||||
monkeypatch.setenv("LOG_FORMAT", fmt)
|
||||
@@ -51,7 +51,7 @@ def _setup(monkeypatch, *, fmt: str = "json", level: str = "DEBUG") -> tuple:
|
||||
logging_setup.configure_logging()
|
||||
|
||||
buf = io.StringIO()
|
||||
root = logging.getLogger("slopsmith")
|
||||
root = logging.getLogger("feedBack")
|
||||
for h in root.handlers:
|
||||
# Replace stream on the console StreamHandler (not file handlers).
|
||||
if isinstance(h, logging.StreamHandler) and not isinstance(
|
||||
@@ -59,7 +59,7 @@ def _setup(monkeypatch, *, fmt: str = "json", level: str = "DEBUG") -> tuple:
|
||||
):
|
||||
h.stream = buf
|
||||
|
||||
return logging.getLogger("slopsmith.test"), buf
|
||||
return logging.getLogger("feedBack.test"), buf
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
@@ -182,13 +182,13 @@ def test_reconfigure_picks_up_new_level(monkeypatch):
|
||||
logging_setup.configure_logging()
|
||||
|
||||
buf = io.StringIO()
|
||||
for h in logging.getLogger("slopsmith").handlers:
|
||||
for h in logging.getLogger("feedBack").handlers:
|
||||
if isinstance(h, logging.StreamHandler) and not isinstance(
|
||||
h, logging.FileHandler
|
||||
):
|
||||
h.stream = buf
|
||||
|
||||
test_log = logging.getLogger("slopsmith.reconfig")
|
||||
test_log = logging.getLogger("feedBack.reconfig")
|
||||
test_log.info("should_not_appear")
|
||||
assert buf.getvalue() == "", "INFO should be suppressed after reconfigure to WARNING"
|
||||
|
||||
@@ -205,16 +205,16 @@ def test_log_file_creates_rotating_handler(monkeypatch, tmp_path):
|
||||
"""LOG_FILE wires up a RotatingFileHandler that writes log records."""
|
||||
import logging_setup
|
||||
|
||||
log_path = tmp_path / "slopsmith.log"
|
||||
log_path = tmp_path / "feedBack.log"
|
||||
monkeypatch.setenv("LOG_FORMAT", "json")
|
||||
monkeypatch.setenv("LOG_LEVEL", "DEBUG")
|
||||
monkeypatch.setenv("LOG_FILE", str(log_path))
|
||||
logging_setup.configure_logging()
|
||||
|
||||
logging.getLogger("slopsmith.filelog").info("written_to_file")
|
||||
logging.getLogger("feedBack.filelog").info("written_to_file")
|
||||
|
||||
# Flush all file handlers so the write is committed.
|
||||
for h in logging.getLogger("slopsmith").handlers:
|
||||
for h in logging.getLogger("feedBack").handlers:
|
||||
h.flush()
|
||||
|
||||
assert log_path.exists(), "log file was not created"
|
||||
@@ -228,15 +228,15 @@ def test_log_file_creates_parent_dirs(monkeypatch, tmp_path):
|
||||
"""LOG_FILE auto-creates missing parent directories instead of raising."""
|
||||
import logging_setup
|
||||
|
||||
log_path = tmp_path / "nested" / "deeper" / "slopsmith.log"
|
||||
log_path = tmp_path / "nested" / "deeper" / "feedBack.log"
|
||||
monkeypatch.setenv("LOG_FORMAT", "json")
|
||||
monkeypatch.setenv("LOG_LEVEL", "DEBUG")
|
||||
monkeypatch.setenv("LOG_FILE", str(log_path))
|
||||
logging_setup.configure_logging()
|
||||
|
||||
logging.getLogger("slopsmith.nested").info("nested_dir_event")
|
||||
logging.getLogger("feedBack.nested").info("nested_dir_event")
|
||||
|
||||
for h in logging.getLogger("slopsmith").handlers:
|
||||
for h in logging.getLogger("feedBack").handlers:
|
||||
h.flush()
|
||||
|
||||
assert log_path.exists(), "log file was not created in nested directories"
|
||||
@@ -251,7 +251,7 @@ def test_log_file_bad_path_falls_back_gracefully(monkeypatch, tmp_path, capsys):
|
||||
# parent is a file, not a directory).
|
||||
blocker = tmp_path / "blocker"
|
||||
blocker.write_text("I am a file, not a directory")
|
||||
bad_path = str(blocker / "slopsmith.log")
|
||||
bad_path = str(blocker / "feedBack.log")
|
||||
|
||||
monkeypatch.setenv("LOG_FORMAT", "json")
|
||||
monkeypatch.setenv("LOG_LEVEL", "DEBUG")
|
||||
@@ -265,7 +265,7 @@ def test_log_file_bad_path_falls_back_gracefully(monkeypatch, tmp_path, capsys):
|
||||
assert "LOG_FILE" in captured.err
|
||||
|
||||
# Console logging still works.
|
||||
root = logging.getLogger("slopsmith")
|
||||
root = logging.getLogger("feedBack")
|
||||
file_handlers = [h for h in root.handlers if isinstance(h, logging.FileHandler)]
|
||||
assert not file_handlers, "no FileHandler should have been added after open failure"
|
||||
|
||||
@@ -274,15 +274,15 @@ def test_log_file_text_mode_no_ansi(monkeypatch, tmp_path):
|
||||
"""LOG_FILE with LOG_FORMAT=text must not write ANSI escape sequences."""
|
||||
import logging_setup
|
||||
|
||||
log_path = tmp_path / "slopsmith.log"
|
||||
log_path = tmp_path / "feedBack.log"
|
||||
monkeypatch.setenv("LOG_FORMAT", "text")
|
||||
monkeypatch.setenv("LOG_LEVEL", "DEBUG")
|
||||
monkeypatch.setenv("LOG_FILE", str(log_path))
|
||||
logging_setup.configure_logging()
|
||||
|
||||
logging.getLogger("slopsmith.plain").info("plain_text_event")
|
||||
logging.getLogger("feedBack.plain").info("plain_text_event")
|
||||
|
||||
for h in logging.getLogger("slopsmith").handlers:
|
||||
for h in logging.getLogger("feedBack").handlers:
|
||||
h.flush()
|
||||
|
||||
content = log_path.read_text(encoding="utf-8")
|
||||
@@ -295,15 +295,15 @@ def test_log_file_json_mode_is_valid_json(monkeypatch, tmp_path):
|
||||
"""LOG_FILE with LOG_FORMAT=json writes one valid JSON object per line."""
|
||||
import logging_setup
|
||||
|
||||
log_path = tmp_path / "slopsmith.log"
|
||||
log_path = tmp_path / "feedBack.log"
|
||||
monkeypatch.setenv("LOG_FORMAT", "json")
|
||||
monkeypatch.setenv("LOG_LEVEL", "DEBUG")
|
||||
monkeypatch.setenv("LOG_FILE", str(log_path))
|
||||
logging_setup.configure_logging()
|
||||
|
||||
logging.getLogger("slopsmith.jsonfile").warning("json_file_event")
|
||||
logging.getLogger("feedBack.jsonfile").warning("json_file_event")
|
||||
|
||||
for h in logging.getLogger("slopsmith").handlers:
|
||||
for h in logging.getLogger("feedBack").handlers:
|
||||
h.flush()
|
||||
|
||||
lines = [l for l in log_path.read_text(encoding="utf-8").splitlines() if l.strip()]
|
||||
@@ -333,13 +333,13 @@ def test_bad_log_level_falls_back_to_info_with_warning(monkeypatch, capsys):
|
||||
|
||||
# Fallback to INFO: INFO records pass through, DEBUG does not.
|
||||
buf = io.StringIO()
|
||||
for h in logging.getLogger("slopsmith").handlers:
|
||||
for h in logging.getLogger("feedBack").handlers:
|
||||
if isinstance(h, logging.StreamHandler) and not isinstance(
|
||||
h, logging.FileHandler
|
||||
):
|
||||
h.stream = buf
|
||||
|
||||
log = logging.getLogger("slopsmith.typo_level")
|
||||
log = logging.getLogger("feedBack.typo_level")
|
||||
log.debug("should_be_filtered")
|
||||
assert buf.getvalue() == "", "DEBUG should be suppressed when level is INFO"
|
||||
log.info("should_pass")
|
||||
@@ -368,13 +368,13 @@ def test_non_integer_log_level_attribute_falls_back_to_info(monkeypatch, capsys)
|
||||
|
||||
# Verify INFO-level fallback: DEBUG suppressed, INFO passes.
|
||||
buf = io.StringIO()
|
||||
for h in logging.getLogger("slopsmith").handlers:
|
||||
for h in logging.getLogger("feedBack").handlers:
|
||||
if isinstance(h, logging.StreamHandler) and not isinstance(
|
||||
h, logging.FileHandler
|
||||
):
|
||||
h.stream = buf
|
||||
|
||||
log = logging.getLogger("slopsmith.basic_format_level")
|
||||
log = logging.getLogger("feedBack.basic_format_level")
|
||||
log.debug("should_be_filtered")
|
||||
assert buf.getvalue() == "", "DEBUG should be suppressed when level fell back to INFO"
|
||||
log.info("should_pass")
|
||||
@@ -396,13 +396,13 @@ def test_bad_log_format_falls_back_to_text_with_warning(monkeypatch, capsys):
|
||||
|
||||
# Text fallback: output should not be JSON.
|
||||
buf = io.StringIO()
|
||||
for h in logging.getLogger("slopsmith").handlers:
|
||||
for h in logging.getLogger("feedBack").handlers:
|
||||
if isinstance(h, logging.StreamHandler) and not isinstance(
|
||||
h, logging.FileHandler
|
||||
):
|
||||
h.stream = buf
|
||||
|
||||
logging.getLogger("slopsmith.typo_fmt").info("text_fallback_event")
|
||||
logging.getLogger("feedBack.typo_fmt").info("text_fallback_event")
|
||||
line = buf.getvalue().strip()
|
||||
assert line, "no output captured"
|
||||
with pytest.raises((json.JSONDecodeError, ValueError)):
|
||||
|
||||
Reference in New Issue
Block a user