mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-12 03:41:40 +00:00
rename: slopsmith → feedBack, byron → got-feedBack (#537)
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.8
byrongamatos
parent
a8ad02739a
commit
af2949677a
+16
-16
@@ -21,7 +21,7 @@ import gp2midi
|
||||
def test_find_soundfont_honours_env_var(tmp_path, monkeypatch):
|
||||
sf = tmp_path / "custom.sf2"
|
||||
sf.write_bytes(b"riff") # content unchecked; only os.path.isfile matters
|
||||
monkeypatch.setenv("SLOPSMITH_SOUNDFONT", str(sf))
|
||||
monkeypatch.setenv("FEEDBACK_SOUNDFONT", str(sf))
|
||||
monkeypatch.delenv("RESOURCESPATH", raising=False)
|
||||
|
||||
assert gp2midi._find_soundfont() == str(sf)
|
||||
@@ -31,7 +31,7 @@ def test_find_soundfont_env_var_skipped_when_file_missing(tmp_path, monkeypatch)
|
||||
# Env var set but path doesn't exist — fall through to later candidates.
|
||||
# Clear RESOURCESPATH too so the fall-through lands on system paths
|
||||
# (which will themselves be empty on the test runner → None).
|
||||
monkeypatch.setenv("SLOPSMITH_SOUNDFONT", str(tmp_path / "nonexistent.sf2"))
|
||||
monkeypatch.setenv("FEEDBACK_SOUNDFONT", str(tmp_path / "nonexistent.sf2"))
|
||||
monkeypatch.delenv("RESOURCESPATH", raising=False)
|
||||
# Override sys.platform to something unrecognised so no system paths apply.
|
||||
monkeypatch.setattr(gp2midi.sys, "platform", "unknown-os")
|
||||
@@ -44,7 +44,7 @@ def test_find_soundfont_picks_from_resourcespath(tmp_path, monkeypatch):
|
||||
sf_dir.mkdir()
|
||||
(sf_dir / "GeneralUser-GS.sf2").write_bytes(b"riff")
|
||||
|
||||
monkeypatch.delenv("SLOPSMITH_SOUNDFONT", raising=False)
|
||||
monkeypatch.delenv("FEEDBACK_SOUNDFONT", raising=False)
|
||||
monkeypatch.setenv("RESOURCESPATH", str(tmp_path))
|
||||
|
||||
assert gp2midi._find_soundfont() == str(sf_dir / "GeneralUser-GS.sf2")
|
||||
@@ -59,14 +59,14 @@ def test_find_soundfont_env_var_wins_over_resourcespath(tmp_path, monkeypatch):
|
||||
override = tmp_path / "override.sf2"
|
||||
override.write_bytes(b"riff")
|
||||
|
||||
monkeypatch.setenv("SLOPSMITH_SOUNDFONT", str(override))
|
||||
monkeypatch.setenv("FEEDBACK_SOUNDFONT", str(override))
|
||||
monkeypatch.setenv("RESOURCESPATH", str(tmp_path))
|
||||
|
||||
assert gp2midi._find_soundfont() == str(override)
|
||||
|
||||
|
||||
def test_find_soundfont_returns_none_when_nothing_exists(tmp_path, monkeypatch):
|
||||
monkeypatch.delenv("SLOPSMITH_SOUNDFONT", raising=False)
|
||||
monkeypatch.delenv("FEEDBACK_SOUNDFONT", raising=False)
|
||||
monkeypatch.setenv("RESOURCESPATH", str(tmp_path)) # empty dir, no sf2
|
||||
monkeypatch.setattr(gp2midi.sys, "platform", "unknown-os")
|
||||
|
||||
@@ -77,18 +77,18 @@ def test_find_soundfont_warns_on_invalid_env_var(tmp_path, monkeypatch, caplog):
|
||||
import logging
|
||||
# Env var set to a non-existent path: warning is emitted via the logger so
|
||||
# it is captured by log aggregators and shows up in structured output.
|
||||
monkeypatch.setenv("SLOPSMITH_SOUNDFONT", str(tmp_path / "nope.sf2"))
|
||||
monkeypatch.setenv("FEEDBACK_SOUNDFONT", str(tmp_path / "nope.sf2"))
|
||||
monkeypatch.delenv("RESOURCESPATH", raising=False)
|
||||
monkeypatch.setattr(gp2midi.sys, "platform", "unknown-os")
|
||||
|
||||
# Add caplog's handler directly to the slopsmith.lib.gp2midi logger so it
|
||||
# captures records regardless of the slopsmith root logger's propagate flag
|
||||
# Add caplog's handler directly to the feedBack.lib.gp2midi logger so it
|
||||
# captures records regardless of the feedBack root logger's propagate flag
|
||||
# (configure_logging() sets propagate=False, which prevents records from
|
||||
# reaching the root logger where caplog normally listens).
|
||||
# Also disable propagation temporarily to prevent double-capture when the
|
||||
# slopsmith hierarchy has not been configured (records would otherwise
|
||||
# feedBack hierarchy has not been configured (records would otherwise
|
||||
# propagate to the root logger where caplog already listens).
|
||||
gp2midi_log = logging.getLogger("slopsmith.lib.gp2midi")
|
||||
gp2midi_log = logging.getLogger("feedBack.lib.gp2midi")
|
||||
orig_level = gp2midi_log.level
|
||||
orig_propagate = gp2midi_log.propagate
|
||||
gp2midi_log.addHandler(caplog.handler)
|
||||
@@ -102,7 +102,7 @@ def test_find_soundfont_warns_on_invalid_env_var(tmp_path, monkeypatch, caplog):
|
||||
gp2midi_log.propagate = orig_propagate
|
||||
|
||||
assert result is None
|
||||
assert "SLOPSMITH_SOUNDFONT" in caplog.text
|
||||
assert "FEEDBACK_SOUNDFONT" in caplog.text
|
||||
assert "does not exist" in caplog.text
|
||||
|
||||
|
||||
@@ -116,7 +116,7 @@ def test_find_soundfont_picks_up_system_paths_per_platform(platform, target, mon
|
||||
# Simulate "only the target file exists" on a given platform. The fake
|
||||
# isfile must return False for the env var and resourcepath fall-throughs
|
||||
# as well, so we guard with an exact match.
|
||||
monkeypatch.delenv("SLOPSMITH_SOUNDFONT", raising=False)
|
||||
monkeypatch.delenv("FEEDBACK_SOUNDFONT", raising=False)
|
||||
monkeypatch.delenv("RESOURCESPATH", raising=False)
|
||||
monkeypatch.setattr(gp2midi.sys, "platform", platform)
|
||||
monkeypatch.setattr(gp2midi.os.path, "isfile", lambda p: p == target)
|
||||
@@ -131,7 +131,7 @@ def test_render_midi_to_audio_surfaces_fluidsynth_not_found(tmp_path, monkeypatc
|
||||
# error up to the caller.
|
||||
sf = tmp_path / "stub.sf2"
|
||||
sf.write_bytes(b"riff")
|
||||
monkeypatch.setenv("SLOPSMITH_SOUNDFONT", str(sf))
|
||||
monkeypatch.setenv("FEEDBACK_SOUNDFONT", str(sf))
|
||||
|
||||
def fake_run(*args, **kwargs):
|
||||
raise FileNotFoundError("[Errno 2] No such file or directory: 'fluidsynth'")
|
||||
@@ -150,8 +150,8 @@ def test_render_midi_to_audio_surfaces_fluidsynth_not_found(tmp_path, monkeypatc
|
||||
@pytest.mark.parametrize("platform,must_contain,must_not_contain", [
|
||||
("linux", ["pacman", "apt", "dnf"], ["homebrew", "FluidSynth.exe"]),
|
||||
("linux2", ["pacman", "apt", "dnf"], ["homebrew"]),
|
||||
("darwin", ["homebrew", "SLOPSMITH_SOUNDFONT"], ["pacman", "apt"]),
|
||||
("win32", ["SLOPSMITH_SOUNDFONT", "APPDATA", "Slopsmith"], ["pacman", "homebrew", "apt"]),
|
||||
("darwin", ["homebrew", "FEEDBACK_SOUNDFONT"], ["pacman", "apt"]),
|
||||
("win32", ["FEEDBACK_SOUNDFONT", "APPDATA", "FeedBack"], ["pacman", "homebrew", "apt"]),
|
||||
])
|
||||
def test_soundfont_install_hint_is_platform_aware(platform, must_contain, must_not_contain, monkeypatch):
|
||||
monkeypatch.setattr(gp2midi.sys, "platform", platform)
|
||||
@@ -165,7 +165,7 @@ def test_soundfont_install_hint_is_platform_aware(platform, must_contain, must_n
|
||||
def test_soundfont_install_hint_unknown_platform_falls_back_to_env_var_instruction(monkeypatch):
|
||||
monkeypatch.setattr(gp2midi.sys, "platform", "freebsd14")
|
||||
hint = gp2midi._soundfont_install_hint()
|
||||
assert "SLOPSMITH_SOUNDFONT" in hint
|
||||
assert "FEEDBACK_SOUNDFONT" in hint
|
||||
|
||||
|
||||
# ── _fluidsynth_install_hint ─────────────────────────────────────────────────
|
||||
|
||||
Reference in New Issue
Block a user