rename: slopsmith → feedBack, byron → got-feedBack (#537)

* Update GitHub repo references from feedback* to feedBack*

* rename: slopsmith -> feedBack, byron -> got-feedBack

Renames across the entire codebase:
- slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack
- byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack
- /home/byron/ -> /opt/got-feedBack/
- byron@ougsoft.com -> hi@got-feedBack.org
- github.com/byrongamatos/ -> github.com/got-feedback/
- com.byron. -> com.got-feedback.
- SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback
- Protocol/storage strings migrated with read-old/write-new pattern
- window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias

Refs: #rename-slopsmith

* rename: complete regen against current main + fix backward-compat alias

Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of
current main (3 commits had landed since the branch: #572/#554/#574),
resolving the four content conflicts in favour of main's newer content
(autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge).

Completion fixes on top of the mechanical rename:
- Re-apply rename to post-branch content the original rename never saw:
  window.slopsmith(.Tour) consumers in lessons.js / notifications.js /
  onboarding-tour.js, and the matching JS + python tests (autoplay_exit,
  progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env
  vars now match server.py (which reads FEEDBACK_SYNC_STARTUP /
  FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real
  path again.
- Restore the window.slopsmith backward-compat alias dropped during conflict
  resolution, and move the bus aliases to AFTER the _feedBackExisting merge
  block so they reference the fully-assembled object (also fixes the
  loop_api.test.js API-surface regex, which the original PR latently broke).
- Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR)
  and gitignore it.
- Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped
  source labels.

Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669
passed / 1683 collected with 0 import errors; zero residual slopsmith/byron
except the two intentional window.slopsmith aliases.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* rename: implement advertised backward-compat + prune dead community plugins

Address gaps where PR #537's "Backward compatibility" section was advertised
but not implemented, and clean up the community plugin list.

Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured):
- New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py
  (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and
  tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI /
  SLOPSMITH_PLUGINS_DIR / etc. deployments keep working.
- Fix the rename collapsing plugins/__init__.py and minigames/routes.py from
  `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant
  `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost).

Storage (app.js update-channel):
- Read feedBack-update-channel, fall back to legacy slopsmith-update-channel,
  and clear the legacy key on write — so a user's update-channel preference
  survives the rename instead of resetting to "stable".

Community plugin list (README): the rename rewrote third-party repo URLs we
don't own. Probed every one; their owners never renamed, so:
- Restore the 13 live community plugins to their real slopsmith-* names.
- Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex
  tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle).
- Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory).

Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors,
rename-sensitive + startup suites green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: byrongamatos <xasiklas@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bret Mogilefsky
2026-06-23 11:03:01 +02:00
committed by GitHub
co-authored by Claude Opus 4.8 byrongamatos
parent a8ad02739a
commit af2949677a
257 changed files with 2389 additions and 2293 deletions
+13 -13
View File
@@ -12,7 +12,7 @@ LOG = logging.getLogger("test")
def _basic_kwargs(tmp_path):
return dict(
slopsmith_version="0.0.0-test",
feedBack_version="0.0.0-test",
config_dir=tmp_path,
dlc_dir=None,
log_file=None,
@@ -33,7 +33,7 @@ def _open_zip(payload: bytes) -> zipfile.ZipFile:
def test_minimal_bundle_has_manifest_and_readme(tmp_path):
zip_bytes, filename, manifest = db.build_bundle(**_basic_kwargs(tmp_path))
assert filename.startswith("slopsmith-diag-0.0.0-test-")
assert filename.startswith("feedBack-diag-0.0.0-test-")
assert filename.endswith(".zip")
with _open_zip(zip_bytes) as zf:
names = zf.namelist()
@@ -42,7 +42,7 @@ def test_minimal_bundle_has_manifest_and_readme(tmp_path):
assert "system/version.json" in names
m = json.loads(zf.read("manifest.json"))
assert m["schema"] == 1
assert m["slopsmith_version"] == "0.0.0-test"
assert m["feedBack_version"] == "0.0.0-test"
assert any(f["path"] == "system/version.json" for f in m["files"])
@@ -203,7 +203,7 @@ def test_client_audio_session_contribution_redacts_paths(tmp_path):
kw["include"]["plugins"] = True
kw["client_contributions"] = {
"note_detect": {
"schema": "slopsmith.audio_session.diagnostics.v1",
"schema": "feedBack.audio_session.diagnostics.v1",
"session": {"sessionId": str(home_path / "DLC" / "private-song.archive")},
"domains": {"audio-input": {"sources": [{"label": str(home_path / "devices" / "raw-id")}]}},
}
@@ -213,7 +213,7 @@ def test_client_audio_session_contribution_redacts_paths(tmp_path):
data = json.loads(zf.read("plugins/note_detect/client.json"))
encoded = json.dumps(data)
assert str(home_path) not in encoded
assert "slopsmith.audio_session.diagnostics.v1" in encoded
assert "feedBack.audio_session.diagnostics.v1" in encoded
def test_system_plugins_exports_capability_metadata_and_shims(tmp_path):
@@ -246,7 +246,7 @@ def test_system_plugins_exports_capability_metadata_and_shims(tmp_path):
def test_preview_returns_manifest_shape(tmp_path):
out = db.preview_bundle(
slopsmith_version="0.0.0-test",
feedBack_version="0.0.0-test",
config_dir=tmp_path,
dlc_dir=None,
log_file=None,
@@ -344,7 +344,7 @@ def test_callable_failure_recorded_in_manifest_notes(tmp_path):
def test_client_contributions_written_to_bundle(tmp_path):
"""window.slopsmith.diagnostics.contribute() payloads land in plugins/<id>/client.json."""
"""window.feedBack.diagnostics.contribute() payloads land in plugins/<id>/client.json."""
kw = _basic_kwargs(tmp_path)
kw["include"]["plugins"] = True # contributions are gated on the plugins toggle
# Must also include the plugin in loaded_plugins so the ID is recognised.
@@ -419,7 +419,7 @@ def test_ua_url_not_redacted_when_redact_false(tmp_path):
def test_runtime_kind_set_without_hardware_section(tmp_path, monkeypatch):
"""manifest.runtime must reflect actual runtime even when include.hardware=False."""
monkeypatch.setenv("SLOPSMITH_RUNTIME", "electron")
monkeypatch.setenv("FEEDBACK_RUNTIME", "electron")
kw = _basic_kwargs(tmp_path)
kw["include"]["hardware"] = False
_zip, _name, manifest = db.build_bundle(**kw)
@@ -443,7 +443,7 @@ def test_preview_does_not_execute_callables(tmp_path):
"_diagnostics_callable": side_effect,
}
db.preview_bundle(
slopsmith_version="0.0.0-test",
feedBack_version="0.0.0-test",
config_dir=tmp_path,
dlc_dir=None,
log_file=None,
@@ -560,7 +560,7 @@ def test_preview_suppresses_callable_spec(tmp_path):
"_load_sibling": fake_load_sibling,
}
db.preview_bundle(
slopsmith_version="0.0.0-test",
feedBack_version="0.0.0-test",
config_dir=tmp_path,
dlc_dir=None,
log_file=None,
@@ -665,7 +665,7 @@ def test_system_plugins_orphan_path_redacted_when_redactor_provided(tmp_path):
"""Orphan `path` must pass through the redactor when one is provided.
The full resolved path of an evicted copy (e.g.
``/home/user/.config/slopsmith/plugins/highway_3d``) contains the user's
``/home/user/.config/feedBack/plugins/highway_3d``) contains the user's
home directory. Without redaction that leaks in a supposedly-sanitised
bundle. When a Redactor is passed to _system_plugins, home-dir prefixes
in `path` must be replaced with the ``<HOME>`` placeholder.
@@ -794,7 +794,7 @@ def test_manifest_notes_missing_log_file_path_redacted(tmp_path, monkeypatch):
home = tmp_path / "home"
home.mkdir()
monkeypatch.setenv("HOME", str(home))
log_file = home / "slopsmith" / "server.log" # under HOME — sensitive
log_file = home / "feedBack" / "server.log" # under HOME — sensitive
kw = _basic_kwargs(tmp_path)
kw["include"]["logs"] = True
kw["log_file"] = log_file # file does not exist
@@ -964,7 +964,7 @@ def test_callable_bounded_execution_model(tmp_path):
def _preview_kwargs(tmp_path):
return dict(
slopsmith_version="0.0.0-test",
feedBack_version="0.0.0-test",
config_dir=tmp_path,
dlc_dir=None,
log_file=None,