got-feedBack/feedBack
1
0
Fork 0
mirror of https://github.com/got-feedBack/feedBack.git synced 2026-08-14 04:31:21 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

rename: slopsmith → feedBack, byron → got-feedBack (#537)

Browse Source 
* Update GitHub repo references from feedback* to feedBack*

* rename: slopsmith -> feedBack, byron -> got-feedBack

Renames across the entire codebase:
- slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack
- byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack
- /home/byron/ -> /opt/got-feedBack/
- byron@ougsoft.com -> hi@got-feedBack.org
- github.com/byrongamatos/ -> github.com/got-feedback/
- com.byron. -> com.got-feedback.
- SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback
- Protocol/storage strings migrated with read-old/write-new pattern
- window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias

Refs: #rename-slopsmith

* rename: complete regen against current main + fix backward-compat alias

Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of
current main (3 commits had landed since the branch: #572/#554/#574),
resolving the four content conflicts in favour of main's newer content
(autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge).

Completion fixes on top of the mechanical rename:
- Re-apply rename to post-branch content the original rename never saw:
  window.slopsmith(.Tour) consumers in lessons.js / notifications.js /
  onboarding-tour.js, and the matching JS + python tests (autoplay_exit,
  progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env
  vars now match server.py (which reads FEEDBACK_SYNC_STARTUP /
  FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real
  path again.
- Restore the window.slopsmith backward-compat alias dropped during conflict
  resolution, and move the bus aliases to AFTER the _feedBackExisting merge
  block so they reference the fully-assembled object (also fixes the
  loop_api.test.js API-surface regex, which the original PR latently broke).
- Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR)
  and gitignore it.
- Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped
  source labels.

Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669
passed / 1683 collected with 0 import errors; zero residual slopsmith/byron
except the two intentional window.slopsmith aliases.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* rename: implement advertised backward-compat + prune dead community plugins

Address gaps where PR #537's "Backward compatibility" section was advertised
but not implemented, and clean up the community plugin list.

Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured):
- New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py
  (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and
  tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI /
  SLOPSMITH_PLUGINS_DIR / etc. deployments keep working.
- Fix the rename collapsing plugins/__init__.py and minigames/routes.py from
  `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant
  `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost).

Storage (app.js update-channel):
- Read feedBack-update-channel, fall back to legacy slopsmith-update-channel,
  and clear the legacy key on write — so a user's update-channel preference
  survives the rename instead of resetting to "stable".

Community plugin list (README): the rename rewrote third-party repo URLs we
don't own. Probed every one; their owners never renamed, so:
- Restore the 13 live community plugins to their real slopsmith-* names.
- Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex
  tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle).
- Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory).

Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors,
rename-sensitive + startup suites green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: byrongamatos <xasiklas@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bret Mogilefsky
2026-06-23 11:03:01 +02:00
committed by GitHub
co-authored by Claude Opus 4.8 byrongamatos
parent a8ad02739a
commit af2949677a
257 changed files with 2389 additions and 2293 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_demo_mode.py
+17 -17
View File
@@ -1,9 +1,9 @@
"""Tests for SLOPSMITH_DEMO_MODE middleware.
"""Tests for FEEDBACK_DEMO_MODE middleware.
Covers:
- Demo mode off: write routes pass through (middleware is a no-op).
- Demo mode on: selected entries from _DEMO_BLOCKED return 403 {"error": "demo mode: read-only"}.
- Demo mode on: first GET / sets the slopsmith_demo_session cookie.
- Demo mode on: first GET / sets the feedBack_demo_session cookie.
- Demo mode on: subsequent GET / (cookie already present) does not re-set it.
- Cookie secure flag: set when X-Forwarded-Proto indicates https, including comma-separated values.
- register_demo_janitor_hook: registered hooks are called by the janitor sweep.
@@ -26,17 +26,17 @@ def _make_client(tmp_path, monkeypatch, *, demo: bool = False):
The TestClient is returned open; caller is responsible for closing it.
raise_server_exceptions defaults to True so unexpected server errors
surface as test failures rather than silently passing status checks.
SLOPSMITH_SYNC_STARTUP=1 makes the plugin-loader run inline (no background
FEEDBACK_SYNC_STARTUP=1 makes the plugin-loader run inline (no background
thread spawned), consistent with tests/test_startup_status.py. startup_scan
and load_plugins are also stubbed to no-ops so background file-scan and
plugin I/O are suppressed.
"""
monkeypatch.setenv("CONFIG_DIR", str(tmp_path))
monkeypatch.setenv("SLOPSMITH_SYNC_STARTUP", "1")
monkeypatch.setenv("FEEDBACK_SYNC_STARTUP", "1")
if demo:
monkeypatch.setenv("SLOPSMITH_DEMO_MODE", "1")
monkeypatch.setenv("FEEDBACK_DEMO_MODE", "1")
else:
monkeypatch.delenv("SLOPSMITH_DEMO_MODE", raising=False)
monkeypatch.delenv("FEEDBACK_DEMO_MODE", raising=False)
sys.modules.pop("server", None)
server = importlib.import_module("server")
# Stub out background threads to keep tests fast and non-flaky.
@@ -118,7 +118,7 @@ def test_demo_cookie_set_on_first_get_root(tmp_path, monkeypatch):
server, client = _make_client(tmp_path, monkeypatch, demo=True)
try:
r = client.get("/")
assert "slopsmith_demo_session" in r.cookies
assert "feedBack_demo_session" in r.cookies
finally:
_cleanup(server, client)
@@ -128,14 +128,14 @@ def test_demo_cookie_not_reset_when_already_present(tmp_path, monkeypatch):
try:
# First request sets the cookie.
r1 = client.get("/")
session_id = r1.cookies.get("slopsmith_demo_session")
session_id = r1.cookies.get("feedBack_demo_session")
assert session_id is not None
# Second request (cookie already in jar) must not overwrite it.
r2 = client.get("/", cookies={"slopsmith_demo_session": session_id})
r2 = client.get("/", cookies={"feedBack_demo_session": session_id})
# The Set-Cookie header for our cookie must be absent.
set_cookie = r2.headers.get("set-cookie", "")
assert "slopsmith_demo_session" not in set_cookie
assert "feedBack_demo_session" not in set_cookie
finally:
_cleanup(server, client)
@@ -144,7 +144,7 @@ def test_demo_cookie_not_set_in_non_demo_mode(tmp_path, monkeypatch):
server, client = _make_client(tmp_path, monkeypatch, demo=False)
try:
r = client.get("/")
assert "slopsmith_demo_session" not in r.cookies
assert "feedBack_demo_session" not in r.cookies
finally:
_cleanup(server, client)
@@ -157,7 +157,7 @@ def test_demo_cookie_not_secure_over_http(tmp_path, monkeypatch):
r = client.get("/")
set_cookie = r.headers.get("set-cookie", "")
# The cookie must be present but without the Secure attribute.
assert "slopsmith_demo_session" in set_cookie
assert "feedBack_demo_session" in set_cookie
assert "secure" not in set_cookie.lower()
finally:
_cleanup(server, client)
@@ -168,7 +168,7 @@ def test_demo_cookie_secure_over_https_via_forwarded_proto(tmp_path, monkeypatch
try:
r = client.get("/", headers={"x-forwarded-proto": "https"})
set_cookie = r.headers.get("set-cookie", "")
assert "slopsmith_demo_session" in set_cookie
assert "feedBack_demo_session" in set_cookie
assert "secure" in set_cookie.lower()
finally:
_cleanup(server, client)
@@ -180,7 +180,7 @@ def test_demo_cookie_secure_with_comma_separated_forwarded_proto(tmp_path, monke
try:
r = client.get("/", headers={"x-forwarded-proto": "https,http"})
set_cookie = r.headers.get("set-cookie", "")
assert "slopsmith_demo_session" in set_cookie
assert "feedBack_demo_session" in set_cookie
assert "secure" in set_cookie.lower()
finally:
_cleanup(server, client)
@@ -192,7 +192,7 @@ def test_demo_cookie_not_secure_when_forwarded_proto_is_http(tmp_path, monkeypat
try:
r = client.get("/", headers={"x-forwarded-proto": "http"})
set_cookie = r.headers.get("set-cookie", "")
assert "slopsmith_demo_session" in set_cookie
assert "feedBack_demo_session" in set_cookie
assert "secure" not in set_cookie.lower()
finally:
_cleanup(server, client)
@@ -271,8 +271,8 @@ def test_register_demo_janitor_hook_in_plugin_context(tmp_path, monkeypatch):
"""register_demo_janitor_hook must be surfaced in the plugin context dict
passed to load_plugins(), not just on the server module."""
monkeypatch.setenv("CONFIG_DIR", str(tmp_path))
monkeypatch.setenv("SLOPSMITH_DEMO_MODE", "1")
monkeypatch.setenv("SLOPSMITH_SYNC_STARTUP", "1")
monkeypatch.setenv("FEEDBACK_DEMO_MODE", "1")
monkeypatch.setenv("FEEDBACK_SYNC_STARTUP", "1")
sys.modules.pop("server", None)
server = importlib.import_module("server")