rename: slopsmith → feedBack, byron → got-feedBack (#537)

* Update GitHub repo references from feedback* to feedBack*

* rename: slopsmith -> feedBack, byron -> got-feedBack

Renames across the entire codebase:
- slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack
- byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack
- /home/byron/ -> /opt/got-feedBack/
- byron@ougsoft.com -> hi@got-feedBack.org
- github.com/byrongamatos/ -> github.com/got-feedback/
- com.byron. -> com.got-feedback.
- SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback
- Protocol/storage strings migrated with read-old/write-new pattern
- window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias

Refs: #rename-slopsmith

* rename: complete regen against current main + fix backward-compat alias

Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of
current main (3 commits had landed since the branch: #572/#554/#574),
resolving the four content conflicts in favour of main's newer content
(autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge).

Completion fixes on top of the mechanical rename:
- Re-apply rename to post-branch content the original rename never saw:
  window.slopsmith(.Tour) consumers in lessons.js / notifications.js /
  onboarding-tour.js, and the matching JS + python tests (autoplay_exit,
  progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env
  vars now match server.py (which reads FEEDBACK_SYNC_STARTUP /
  FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real
  path again.
- Restore the window.slopsmith backward-compat alias dropped during conflict
  resolution, and move the bus aliases to AFTER the _feedBackExisting merge
  block so they reference the fully-assembled object (also fixes the
  loop_api.test.js API-surface regex, which the original PR latently broke).
- Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR)
  and gitignore it.
- Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped
  source labels.

Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669
passed / 1683 collected with 0 import errors; zero residual slopsmith/byron
except the two intentional window.slopsmith aliases.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* rename: implement advertised backward-compat + prune dead community plugins

Address gaps where PR #537's "Backward compatibility" section was advertised
but not implemented, and clean up the community plugin list.

Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured):
- New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py
  (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and
  tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI /
  SLOPSMITH_PLUGINS_DIR / etc. deployments keep working.
- Fix the rename collapsing plugins/__init__.py and minigames/routes.py from
  `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant
  `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost).

Storage (app.js update-channel):
- Read feedBack-update-channel, fall back to legacy slopsmith-update-channel,
  and clear the legacy key on write — so a user's update-channel preference
  survives the rename instead of resetting to "stable".

Community plugin list (README): the rename rewrote third-party repo URLs we
don't own. Probed every one; their owners never renamed, so:
- Restore the 13 live community plugins to their real slopsmith-* names.
- Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex
  tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle).
- Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory).

Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors,
rename-sensitive + startup suites green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: byrongamatos <xasiklas@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bret Mogilefsky
2026-06-23 11:03:01 +02:00
committed by GitHub
co-authored by Claude Opus 4.8 byrongamatos
parent a8ad02739a
commit af2949677a
257 changed files with 2389 additions and 2293 deletions
+8 -8
View File
@@ -1,7 +1,7 @@
"""Integration test for CorrelationIdMiddleware wiring in server.py.
Verifies that every HTTP response carries the X-Request-ID header that was
introduced alongside the structured logging bootstrap (slopsmith#155).
introduced alongside the structured logging bootstrap (feedBack#155).
Requests that include an X-Request-ID should echo it; requests without it
should receive a server-generated ID. A cross-cutting end-to-end test
additionally asserts that the ID propagates into log output.
@@ -25,7 +25,7 @@ from asgi_correlation_id import CorrelationIdMiddleware
def client(tmp_path, monkeypatch):
"""Minimal server client with background I/O suppressed."""
monkeypatch.setenv("CONFIG_DIR", str(tmp_path))
monkeypatch.setenv("SLOPSMITH_SYNC_STARTUP", "1")
monkeypatch.setenv("FEEDBACK_SYNC_STARTUP", "1")
sys.modules.pop("server", None)
server = importlib.import_module("server")
monkeypatch.setattr(server, "load_plugins", lambda *a, **kw: None)
@@ -96,7 +96,7 @@ def test_request_id_appears_in_log_line(monkeypatch):
logging_setup.configure_logging()
buf = io.StringIO()
for h in logging.getLogger("slopsmith").handlers:
for h in logging.getLogger("feedBack").handlers:
if isinstance(h, logging.StreamHandler) and not isinstance(
h, logging.FileHandler
):
@@ -108,7 +108,7 @@ def test_request_id_appears_in_log_line(monkeypatch):
@mini_app.get("/probe")
def probe():
logging.getLogger("slopsmith.probe").info("probe_event")
logging.getLogger("feedBack.probe").info("probe_event")
return {"ok": True}
known_id = str(uuid.uuid4())
@@ -135,7 +135,7 @@ def test_server_app_request_id_propagated_to_logs(monkeypatch, tmp_path):
monkeypatch.setenv("LOG_LEVEL", "DEBUG")
monkeypatch.delenv("LOG_FILE", raising=False)
monkeypatch.setenv("CONFIG_DIR", str(tmp_path))
monkeypatch.setenv("SLOPSMITH_SYNC_STARTUP", "1")
monkeypatch.setenv("FEEDBACK_SYNC_STARTUP", "1")
sys.modules.pop("server", None)
server_mod = importlib.import_module("server")
@@ -145,7 +145,7 @@ def test_server_app_request_id_propagated_to_logs(monkeypatch, tmp_path):
# Add a probe route to server.app so the test can trigger a log write.
@server_mod.app.get("/_test_log_probe")
def _probe():
logging.getLogger("slopsmith.server").info("server_probe_event")
logging.getLogger("feedBack.server").info("server_probe_event")
return {"ok": True}
known_id = str(uuid.uuid4())
@@ -153,9 +153,9 @@ def test_server_app_request_id_propagated_to_logs(monkeypatch, tmp_path):
try:
with TestClient(server_mod.app) as tc:
# startup_events() has now run (including its configure_logging() call),
# so the slopsmith handlers are freshly created. Redirect their stream
# so the feedBack handlers are freshly created. Redirect their stream
# to buf NOW, after startup, so we capture the probe request's output.
for h in logging.getLogger("slopsmith").handlers:
for h in logging.getLogger("feedBack").handlers:
if isinstance(h, logging.StreamHandler) and not isinstance(
h, logging.FileHandler
):