mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-11 03:09:57 +00:00
rename: slopsmith → feedBack, byron → got-feedBack (#537)
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bret Mogilefsky
co-authored by
Claude Opus 4.8
byrongamatos
Claude Opus 4.8
byrongamatos
parent
a8ad02739a
commit
af2949677a
@@ -26,7 +26,7 @@ function captureEvents(api, eventNames) {
|
||||
|
||||
test('visualization domain registers an active provider-coordinator owner', () => {
|
||||
const window = loadVisualization();
|
||||
const api = window.slopsmith.capabilities;
|
||||
const api = window.feedBack.capabilities;
|
||||
const pipeline = api.inspect('visualization');
|
||||
assert.ok(pipeline, 'visualization pipeline exists');
|
||||
const owner = (pipeline.participants || []).find(p => p.pluginId === 'core.visualization');
|
||||
@@ -36,12 +36,12 @@ test('visualization domain registers an active provider-coordinator owner', () =
|
||||
[...owner.commands].sort(),
|
||||
['clear-renderer', 'inspect', 'list-providers', 'select-renderer'],
|
||||
);
|
||||
assert.equal(window.slopsmith.vizDomain.version, 1);
|
||||
assert.equal(window.feedBack.vizDomain.version, 1);
|
||||
});
|
||||
|
||||
test('visualization is no longer a reserved future domain', async () => {
|
||||
const window = loadVisualization();
|
||||
const api = window.slopsmith.capabilities;
|
||||
const api = window.feedBack.capabilities;
|
||||
const result = await api.dispatch({ capability: 'visualization', command: 'inspect', source: 'test' });
|
||||
assert.equal(result.outcome, 'handled');
|
||||
assert.equal(result.payload.current, 'default');
|
||||
@@ -49,14 +49,14 @@ test('visualization is no longer a reserved future domain', async () => {
|
||||
|
||||
test('refreshProviders registers participants with factory metadata', () => {
|
||||
const window = loadVisualization();
|
||||
const api = window.slopsmith.capabilities;
|
||||
const api = window.feedBack.capabilities;
|
||||
const highway3d = () => ({});
|
||||
highway3d.contextType = 'webgl2';
|
||||
highway3d.matchesArrangement = () => true;
|
||||
window.slopsmithViz_highway_3d = highway3d;
|
||||
window.slopsmithViz_piano = () => ({});
|
||||
window.feedBackViz_highway_3d = highway3d;
|
||||
window.feedBackViz_piano = () => ({});
|
||||
|
||||
window.slopsmith.vizDomain.refreshProviders([
|
||||
window.feedBack.vizDomain.refreshProviders([
|
||||
{ id: 'highway_3d', label: '3D Highway' },
|
||||
{ id: 'piano', label: 'Piano' },
|
||||
{ id: 'auto', label: 'Auto' }, // built-ins are skipped
|
||||
@@ -68,7 +68,7 @@ test('refreshProviders registers participants with factory metadata', () => {
|
||||
assert.ok(ids.includes('highway_3d') && ids.includes('piano'));
|
||||
assert.ok(!ids.includes('auto') && !ids.includes('default'));
|
||||
|
||||
const snapshot = window.slopsmith.vizDomain.snapshot();
|
||||
const snapshot = window.feedBack.vizDomain.snapshot();
|
||||
const h3d = snapshot.providers.find(p => p.id === 'highway_3d');
|
||||
assert.equal(h3d.contextType, 'webgl2');
|
||||
assert.equal(h3d.claims, true);
|
||||
@@ -79,9 +79,9 @@ test('refreshProviders registers participants with factory metadata', () => {
|
||||
|
||||
test('refreshProviders surfaces declared per-instance settings in the snapshot', () => {
|
||||
const window = loadVisualization();
|
||||
const caps = window.slopsmith.capabilities;
|
||||
window.slopsmithViz_highway_3d = () => ({});
|
||||
window.slopsmithViz_piano = () => ({});
|
||||
const caps = window.feedBack.capabilities;
|
||||
window.feedBackViz_highway_3d = () => ({});
|
||||
window.feedBackViz_piano = () => ({});
|
||||
|
||||
const settings = [
|
||||
{ key: 'palette', label: 'Palette', type: 'select', default: 'default',
|
||||
@@ -95,7 +95,7 @@ test('refreshProviders surfaces declared per-instance settings in the snapshot',
|
||||
// normalizes them, and the host reads them back from the participant.
|
||||
caps.registerParticipant('highway_3d', { visualization: { roles: ['provider'], settings } });
|
||||
|
||||
window.slopsmith.vizDomain.refreshProviders([
|
||||
window.feedBack.vizDomain.refreshProviders([
|
||||
{ id: 'highway_3d', label: '3D Highway' },
|
||||
{ id: 'piano', label: 'Piano' }, // no settings declared
|
||||
]);
|
||||
@@ -115,7 +115,7 @@ test('refreshProviders surfaces declared per-instance settings in the snapshot',
|
||||
|
||||
// list-providers carries the descriptors for consuming hosts; providers
|
||||
// without a declared settings list omit the field entirely.
|
||||
const snapshot = window.slopsmith.vizDomain.snapshot();
|
||||
const snapshot = window.feedBack.vizDomain.snapshot();
|
||||
const h3d = snapshot.providers.find(p => p.id === 'highway_3d');
|
||||
// Value-equal (the host deep-clones, so compare plain values, not refs).
|
||||
assert.deepEqual(JSON.parse(JSON.stringify(h3d.settings)), settings);
|
||||
@@ -142,17 +142,17 @@ test('refreshProviders surfaces declared per-instance settings in the snapshot',
|
||||
|
||||
test('refreshProviders unregisters providers that disappeared', () => {
|
||||
const window = loadVisualization();
|
||||
const api = window.slopsmith.capabilities;
|
||||
window.slopsmithViz_gone = () => ({});
|
||||
window.slopsmith.vizDomain.refreshProviders([{ id: 'gone', label: 'Gone' }]);
|
||||
const api = window.feedBack.capabilities;
|
||||
window.feedBackViz_gone = () => ({});
|
||||
window.feedBack.vizDomain.refreshProviders([{ id: 'gone', label: 'Gone' }]);
|
||||
assert.ok(api.inspect('visualization').participants.some(p => p.pluginId === 'gone'));
|
||||
window.slopsmith.vizDomain.refreshProviders([]);
|
||||
window.feedBack.vizDomain.refreshProviders([]);
|
||||
assert.ok(!api.inspect('visualization').participants.some(p => p.pluginId === 'gone'));
|
||||
});
|
||||
|
||||
test('select-renderer degrades on unknown provider and missing picker surface', async () => {
|
||||
const window = loadVisualization();
|
||||
const api = window.slopsmith.capabilities;
|
||||
const api = window.feedBack.capabilities;
|
||||
const unknown = await api.dispatch({
|
||||
capability: 'visualization', command: 'select-renderer',
|
||||
source: 'test', payload: { providerId: 'nope' },
|
||||
@@ -160,8 +160,8 @@ test('select-renderer degrades on unknown provider and missing picker surface',
|
||||
assert.equal(unknown.outcome, 'degraded');
|
||||
assert.match(unknown.reason, /Unknown visualization provider/);
|
||||
|
||||
window.slopsmithViz_piano = () => ({});
|
||||
window.slopsmith.vizDomain.refreshProviders([{ id: 'piano', label: 'Piano' }]);
|
||||
window.feedBackViz_piano = () => ({});
|
||||
window.feedBack.vizDomain.refreshProviders([{ id: 'piano', label: 'Piano' }]);
|
||||
const noSurface = await api.dispatch({
|
||||
capability: 'visualization', command: 'select-renderer',
|
||||
source: 'test', payload: { providerId: 'piano' },
|
||||
@@ -172,11 +172,11 @@ test('select-renderer degrades on unknown provider and missing picker surface',
|
||||
|
||||
test('select-renderer and clear-renderer delegate to the app picker', async () => {
|
||||
const window = loadVisualization();
|
||||
const api = window.slopsmith.capabilities;
|
||||
const api = window.feedBack.capabilities;
|
||||
const calls = [];
|
||||
window.setViz = (id) => calls.push(id);
|
||||
window.slopsmithViz_piano = () => ({});
|
||||
window.slopsmith.vizDomain.refreshProviders([{ id: 'piano', label: 'Piano' }]);
|
||||
window.feedBackViz_piano = () => ({});
|
||||
window.feedBack.vizDomain.refreshProviders([{ id: 'piano', label: 'Piano' }]);
|
||||
|
||||
const select = await api.dispatch({
|
||||
capability: 'visualization', command: 'select-renderer',
|
||||
@@ -192,15 +192,15 @@ test('select-renderer and clear-renderer delegate to the app picker', async () =
|
||||
|
||||
test('renderer change and failure are emitted as domain events', () => {
|
||||
const window = loadVisualization();
|
||||
const api = window.slopsmith.capabilities;
|
||||
const api = window.feedBack.capabilities;
|
||||
const events = captureEvents(api, [
|
||||
'visualization:renderer-changed',
|
||||
'visualization:renderer-failed',
|
||||
]);
|
||||
|
||||
window.slopsmith.vizDomain.notifyRendererChanged('highway_3d', 'auto-match');
|
||||
window.slopsmith.vizDomain.notifyRendererChanged('highway_3d', 'auto-match'); // same id — no event
|
||||
window.slopsmith.vizDomain.notifyRendererFailed('highway_3d', 'init threw');
|
||||
window.feedBack.vizDomain.notifyRendererChanged('highway_3d', 'auto-match');
|
||||
window.feedBack.vizDomain.notifyRendererChanged('highway_3d', 'auto-match'); // same id — no event
|
||||
window.feedBack.vizDomain.notifyRendererFailed('highway_3d', 'init threw');
|
||||
|
||||
const changed = events.filter(e => e.event === 'renderer-changed');
|
||||
assert.equal(changed.length, 1);
|
||||
@@ -215,9 +215,9 @@ test('renderer change and failure are emitted as domain events', () => {
|
||||
|
||||
test('legacy shim accounting appears in the diagnostics snapshot', () => {
|
||||
const window = loadVisualization();
|
||||
const api = window.slopsmith.capabilities;
|
||||
window.slopsmithViz_piano = () => ({});
|
||||
window.slopsmith.vizDomain.refreshProviders([{ id: 'piano', label: 'Piano' }]);
|
||||
const api = window.feedBack.capabilities;
|
||||
window.feedBackViz_piano = () => ({});
|
||||
window.feedBack.vizDomain.refreshProviders([{ id: 'piano', label: 'Piano' }]);
|
||||
|
||||
const snapshot = api.snapshotDiagnostics();
|
||||
const shims = (snapshot.compatibilityShims || []).filter(s => s.capability === 'visualization');
|
||||
@@ -226,19 +226,19 @@ test('legacy shim accounting appears in the diagnostics snapshot', () => {
|
||||
const ids = JSON.parse(JSON.stringify(shims.map(s => s.shimId).sort()));
|
||||
assert.deepEqual(ids, [
|
||||
'visualization:type-visualization-manifest',
|
||||
'visualization:window.slopsmithViz_*',
|
||||
'visualization:window.feedBackViz_*',
|
||||
]);
|
||||
const windowShim = shims.find(s => s.shimId === 'visualization:window.slopsmithViz_*');
|
||||
const windowShim = shims.find(s => s.shimId === 'visualization:window.feedBackViz_*');
|
||||
assert.equal(windowShim.status, 'used');
|
||||
assert.ok(windowShim.hitCount >= 1);
|
||||
});
|
||||
|
||||
test('diagnostics contribution is redaction-safe (no song identity)', () => {
|
||||
const window = loadVisualization();
|
||||
window.slopsmith.vizDomain.noteAutoMatch('piano', true);
|
||||
window.slopsmith.vizDomain.notifyRendererFailed('piano', 'draw threw');
|
||||
window.feedBack.vizDomain.noteAutoMatch('piano', true);
|
||||
window.feedBack.vizDomain.notifyRendererFailed('piano', 'draw threw');
|
||||
const contribution = window.__diagnosticsContributions.get('visualization-capability');
|
||||
assert.equal(contribution.schema, 'slopsmith.visualization_capability.v1');
|
||||
assert.equal(contribution.schema, 'feedBack.visualization_capability.v1');
|
||||
const serialized = JSON.stringify(contribution);
|
||||
assert.ok(!/filename|title|artist|\.sloppak|\.archive/i.test(serialized), serialized);
|
||||
assert.deepEqual(
|
||||
@@ -251,7 +251,7 @@ test('a still-reserved future domain rejects dispatch', async () => {
|
||||
// note-detection was promoted by the spec-009 slice; backend.routes is
|
||||
// the canary that the reserved list still guards unpromoted domains.
|
||||
const window = loadVisualization();
|
||||
const api = window.slopsmith.capabilities;
|
||||
const api = window.feedBack.capabilities;
|
||||
const result = await api.dispatch({ capability: 'backend.routes', command: 'inspect', source: 'test' });
|
||||
assert.notEqual(result.outcome, 'handled');
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user