mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-17 14:08:22 +00:00
rename: slopsmith → feedBack, byron → got-feedBack (#537)
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bret Mogilefsky
co-authored by
Claude Opus 4.8
byrongamatos
Claude Opus 4.8
byrongamatos
parent
a8ad02739a
commit
af2949677a
@@ -119,7 +119,7 @@ test('venue-scene-3d syncs instrument POV from arrangement signal', () => {
|
||||
global.highway = { getSongInfo: () => ({ arrangement: 'Bass' }) };
|
||||
global.v3VenueViz = venueViz;
|
||||
global.v3VenueInstrumentPov = pov;
|
||||
global.slopsmith = { on() {} };
|
||||
global.feedBack = { on() {} };
|
||||
try {
|
||||
venueScene.activate();
|
||||
assert.equal(global._venuePovInput, 'Bass');
|
||||
@@ -140,7 +140,7 @@ test('venue-scene-3d syncs instrument POV from arrangement signal', () => {
|
||||
delete global.highway;
|
||||
delete global.v3VenueViz;
|
||||
delete global.v3VenueInstrumentPov;
|
||||
delete global.slopsmith;
|
||||
delete global.feedBack;
|
||||
delete global._venuePovInput;
|
||||
}
|
||||
});
|
||||
@@ -156,7 +156,7 @@ test('lyrics visibility during guitar practice does not force vocals POV', () =>
|
||||
};
|
||||
global.v3VenueViz = venueViz;
|
||||
global.v3VenueInstrumentPov = pov;
|
||||
global.slopsmith = { on() {} };
|
||||
global.feedBack = { on() {} };
|
||||
try {
|
||||
venueScene.activate();
|
||||
assert.equal(global._venuePovInput, 'Lead');
|
||||
@@ -174,7 +174,7 @@ test('lyrics visibility during guitar practice does not force vocals POV', () =>
|
||||
delete global.highway;
|
||||
delete global.v3VenueViz;
|
||||
delete global.v3VenueInstrumentPov;
|
||||
delete global.slopsmith;
|
||||
delete global.feedBack;
|
||||
delete global._venuePovInput;
|
||||
}
|
||||
});
|
||||
@@ -212,7 +212,7 @@ test('syncViz activates only for venue visualization id', () => {
|
||||
global.h3dVenueSceneGetState = () => ({ active: !!global._h3dActive, assetsLoaded: false, loadFailed: false });
|
||||
global.v3VenueViz = venueViz;
|
||||
global.v3VenueInstrumentPov = pov;
|
||||
global.slopsmith = { on() {} };
|
||||
global.feedBack = { on() {} };
|
||||
try {
|
||||
venueScene.deactivate();
|
||||
venueScene.syncViz('highway_3d');
|
||||
@@ -229,7 +229,7 @@ test('syncViz activates only for venue visualization id', () => {
|
||||
delete global.h3dVenueSceneGetState;
|
||||
delete global.v3VenueViz;
|
||||
delete global.v3VenueInstrumentPov;
|
||||
delete global.slopsmith;
|
||||
delete global.feedBack;
|
||||
delete global._h3dActive;
|
||||
delete global._h3dMood;
|
||||
}
|
||||
@@ -262,7 +262,7 @@ test('live performance state forwards mood to highway venue scene API', () => {
|
||||
isVenueVisualization: () => true,
|
||||
readVizSelection: () => 'venue',
|
||||
};
|
||||
global.slopsmith = { on() {} };
|
||||
global.feedBack = { on() {} };
|
||||
try {
|
||||
venueScene.activate();
|
||||
venueScene.onPerformanceState({ detail: { state: 'fire' } });
|
||||
@@ -276,7 +276,7 @@ test('live performance state forwards mood to highway venue scene API', () => {
|
||||
delete global.h3dVenueSceneSetInstrumentPov;
|
||||
delete global.h3dVenueSceneGetState;
|
||||
delete global.v3VenueViz;
|
||||
delete global.slopsmith;
|
||||
delete global.feedBack;
|
||||
delete global._mood;
|
||||
}
|
||||
});
|
||||
@@ -325,7 +325,7 @@ test('venue-scene-3d syncs motion on activate', () => {
|
||||
global.v3VenueMoodFx = { getMotion: () => 'full' };
|
||||
global.v3VenueViz = venueViz;
|
||||
global.v3VenueInstrumentPov = pov;
|
||||
global.slopsmith = { on() {} };
|
||||
global.feedBack = { on() {} };
|
||||
try {
|
||||
venueScene.activate();
|
||||
assert.equal(global._venueMotion, 'full');
|
||||
@@ -342,7 +342,7 @@ test('venue-scene-3d syncs motion on activate', () => {
|
||||
delete global.v3VenueMoodFx;
|
||||
delete global.v3VenueViz;
|
||||
delete global.v3VenueInstrumentPov;
|
||||
delete global.slopsmith;
|
||||
delete global.feedBack;
|
||||
delete global._venueMotion;
|
||||
}
|
||||
});
|
||||
@@ -360,7 +360,7 @@ test('runtime safety: motion pass does not touch scoring detection timing or aud
|
||||
'plugins/scoring',
|
||||
'static/audio',
|
||||
'AudioEngine',
|
||||
'slopsmith-desktop',
|
||||
'feedBack-desktop',
|
||||
];
|
||||
const allowedTouched = [
|
||||
'plugins/highway_3d/screen.js',
|
||||
|
||||
Reference in New Issue
Block a user