rename: slopsmith → feedBack, byron → got-feedBack (#537)

* Update GitHub repo references from feedback* to feedBack*

* rename: slopsmith -> feedBack, byron -> got-feedBack

Renames across the entire codebase:
- slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack
- byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack
- /home/byron/ -> /opt/got-feedBack/
- byron@ougsoft.com -> hi@got-feedBack.org
- github.com/byrongamatos/ -> github.com/got-feedback/
- com.byron. -> com.got-feedback.
- SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback
- Protocol/storage strings migrated with read-old/write-new pattern
- window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias

Refs: #rename-slopsmith

* rename: complete regen against current main + fix backward-compat alias

Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of
current main (3 commits had landed since the branch: #572/#554/#574),
resolving the four content conflicts in favour of main's newer content
(autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge).

Completion fixes on top of the mechanical rename:
- Re-apply rename to post-branch content the original rename never saw:
  window.slopsmith(.Tour) consumers in lessons.js / notifications.js /
  onboarding-tour.js, and the matching JS + python tests (autoplay_exit,
  progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env
  vars now match server.py (which reads FEEDBACK_SYNC_STARTUP /
  FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real
  path again.
- Restore the window.slopsmith backward-compat alias dropped during conflict
  resolution, and move the bus aliases to AFTER the _feedBackExisting merge
  block so they reference the fully-assembled object (also fixes the
  loop_api.test.js API-surface regex, which the original PR latently broke).
- Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR)
  and gitignore it.
- Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped
  source labels.

Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669
passed / 1683 collected with 0 import errors; zero residual slopsmith/byron
except the two intentional window.slopsmith aliases.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* rename: implement advertised backward-compat + prune dead community plugins

Address gaps where PR #537's "Backward compatibility" section was advertised
but not implemented, and clean up the community plugin list.

Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured):
- New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py
  (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and
  tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI /
  SLOPSMITH_PLUGINS_DIR / etc. deployments keep working.
- Fix the rename collapsing plugins/__init__.py and minigames/routes.py from
  `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant
  `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost).

Storage (app.js update-channel):
- Read feedBack-update-channel, fall back to legacy slopsmith-update-channel,
  and clear the legacy key on write — so a user's update-channel preference
  survives the rename instead of resetting to "stable".

Community plugin list (README): the rename rewrote third-party repo URLs we
don't own. Probed every one; their owners never renamed, so:
- Restore the 13 live community plugins to their real slopsmith-* names.
- Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex
  tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle).
- Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory).

Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors,
rename-sensitive + startup suites green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: byrongamatos <xasiklas@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bret Mogilefsky
2026-06-23 11:03:01 +02:00
committed by GitHub
co-authored by Claude Opus 4.8 byrongamatos
parent a8ad02739a
commit af2949677a
257 changed files with 2389 additions and 2293 deletions
@@ -12,7 +12,7 @@ function fixture(name) {
test('manifest participants are visible before runtime handlers register', () => {
const window = loadCapabilities();
const api = window.slopsmith.capabilities;
const api = window.feedBack.capabilities;
api.registerParticipants([fixture('valid_owner_provider.json'), fixture('valid_requester_observer.json')]);
const stems = api.inspect('stems');
@@ -27,7 +27,7 @@ test('manifest participants are visible before runtime handlers register', () =>
test('runtime registration refreshes an existing manifest participant without duplicating it', async () => {
const window = loadCapabilities();
const api = window.slopsmith.capabilities;
const api = window.feedBack.capabilities;
api.registerParticipants([fixture('valid_owner_provider.json')]);
api.registerParticipant('stems', {
capabilities: {
@@ -74,7 +74,7 @@ test('native library provider capability coordinates providers', async () => {
}
throw new Error(`unexpected fetch ${text}`);
};
const api = window.slopsmith.capabilities;
const api = window.feedBack.capabilities;
const events = [];
api.subscribe('library:source-changed', event => events.push(event));
@@ -101,7 +101,7 @@ test('native library provider capability coordinates providers', async () => {
assert.equal(selected.payload.current, 'remote:frodo');
assert.equal(events.length, 1);
assert.equal(events[0].payload.to, 'remote:frodo');
assert.equal(window.slopsmith.libraryProviders.snapshot().current, 'remote:frodo');
assert.equal(window.feedBack.libraryProviders.snapshot().current, 'remote:frodo');
const syncResult = await api.command('library', 'sync-song', {
requester: 'test',
@@ -123,7 +123,7 @@ test('removed library providers are unregistered as library participants on refr
if (String(url) === '/api/library/providers') return { ok: true, json: async () => ({ providers: providerSet }) };
throw new Error(`unexpected fetch ${url}`);
};
const api = window.slopsmith.capabilities;
const api = window.feedBack.capabilities;
await api.command('library', 'refresh-providers', { requester: 'test' });
let ids = api.inspect('library').participants.map(p => p.pluginId);
@@ -160,7 +160,7 @@ test('a plugin with non-provider library roles is not wiped when its provider di
if (String(url) === '/api/library/providers') return { ok: true, json: async () => ({ providers: providerSet }) };
throw new Error(`unexpected fetch ${url}`);
};
const api = window.slopsmith.capabilities;
const api = window.feedBack.capabilities;
// The same plugin also declares an observer library role via its manifest —
// legitimate participation the provider-cleanup path must not delete.
@@ -187,7 +187,7 @@ test('a plugin with non-provider library roles is not wiped when its provider di
test('runtime domain library declarations appear as library participants', () => {
const window = loadCapabilities();
const api = window.slopsmith.capabilities;
const api = window.feedBack.capabilities;
const touched = api.registerParticipants([{
id: 'remote-library-client',