mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-13 20:21:40 +00:00
rename: slopsmith → feedBack, byron → got-feedBack (#537)
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.8
byrongamatos
parent
a8ad02739a
commit
af2949677a
@@ -4,9 +4,9 @@ const { loadAudioSession } = require('./audio_session_test_harness');
|
||||
|
||||
test('audio-mix commands inspect register and unregister participants', async () => {
|
||||
const window = loadAudioSession();
|
||||
const api = window.slopsmith.capabilities;
|
||||
const api = window.feedBack.capabilities;
|
||||
const events = [];
|
||||
window.slopsmith.on('audio-mix:participant-registered', event => events.push(event.detail.payload.participantId));
|
||||
window.feedBack.on('audio-mix:participant-registered', event => events.push(event.detail.payload.participantId));
|
||||
|
||||
const registered = await api.dispatch({
|
||||
capability: 'audio-mix',
|
||||
@@ -29,12 +29,12 @@ test('audio-mix commands inspect register and unregister participants', async ()
|
||||
assert.equal(inspected.payload.participants.some(p => p.participantId === 'plugin.delay'), true);
|
||||
assert.equal(events.includes('plugin.delay'), true);
|
||||
assert.equal(removed.status, 'applied');
|
||||
assert.equal(window.slopsmith.audioSession.snapshot().domains['audio-mix'].participants.some(p => p.participantId === 'plugin.delay'), false);
|
||||
assert.equal(window.feedBack.audioSession.snapshot().domains['audio-mix'].participants.some(p => p.participantId === 'plugin.delay'), false);
|
||||
});
|
||||
|
||||
test('audio-mix registration reports incompatible participants explicitly', async () => {
|
||||
const window = loadAudioSession();
|
||||
const result = await window.slopsmith.capabilities.dispatch({
|
||||
const result = await window.feedBack.capabilities.dispatch({
|
||||
capability: 'audio-mix',
|
||||
command: 'register-participant',
|
||||
source: 'test',
|
||||
@@ -43,13 +43,13 @@ test('audio-mix registration reports incompatible participants explicitly', asyn
|
||||
|
||||
assert.equal(result.status, 'incompatible-version');
|
||||
assert.equal(result.outcome, 'incompatible-version');
|
||||
assert.equal(window.slopsmith.audioSession.snapshot().recentOutcomes.at(-1).outcome, 'incompatible-version');
|
||||
assert.equal(window.feedBack.audioSession.snapshot().recentOutcomes.at(-1).outcome, 'incompatible-version');
|
||||
});
|
||||
|
||||
test('audio-mix lists required participant kinds and commits provider fader values', async () => {
|
||||
const window = loadAudioSession();
|
||||
const api = window.slopsmith.capabilities;
|
||||
const audioSession = window.slopsmith.audioSession;
|
||||
const api = window.feedBack.capabilities;
|
||||
const audioSession = window.feedBack.audioSession;
|
||||
audioSession.startSession({ sessionId: 'main:test-song', songKey: 'test-song', songFormat: 'sloppak' });
|
||||
|
||||
let pluginValue = 0.25;
|
||||
@@ -99,10 +99,10 @@ test('audio-mix lists required participant kinds and commits provider fader valu
|
||||
|
||||
test('audio-mix reports invalid unavailable and timed-out fader operations', async () => {
|
||||
const window = loadAudioSession();
|
||||
const api = window.slopsmith.capabilities;
|
||||
const api = window.feedBack.capabilities;
|
||||
const events = [];
|
||||
window.slopsmith.on('audio-mix:fader-unavailable', event => events.push(event.detail.payload.participantId));
|
||||
window.slopsmith.audioSession.startSession({ sessionId: 'main:test-song' });
|
||||
window.feedBack.on('audio-mix:fader-unavailable', event => events.push(event.detail.payload.participantId));
|
||||
window.feedBack.audioSession.startSession({ sessionId: 'main:test-song' });
|
||||
|
||||
await api.dispatch({
|
||||
capability: 'audio-mix',
|
||||
@@ -150,7 +150,7 @@ test('audio-mix reports invalid unavailable and timed-out fader operations', asy
|
||||
|
||||
test('audio-mix keeps pre-session participants pending then attaches them on session start', async () => {
|
||||
const window = loadAudioSession();
|
||||
const api = window.slopsmith.capabilities;
|
||||
const api = window.feedBack.capabilities;
|
||||
|
||||
await api.dispatch({
|
||||
capability: 'audio-mix',
|
||||
@@ -166,7 +166,7 @@ test('audio-mix keeps pre-session participants pending then attaches them on ses
|
||||
},
|
||||
});
|
||||
const pending = await api.dispatch({ capability: 'audio-mix', command: 'list-faders', source: 'test' });
|
||||
window.slopsmith.audioSession.startSession({ sessionId: 'main:next-song' });
|
||||
window.feedBack.audioSession.startSession({ sessionId: 'main:next-song' });
|
||||
const active = await api.dispatch({ capability: 'audio-mix', command: 'list-faders', source: 'test' });
|
||||
|
||||
assert.equal(pending.payload.faders.find(fader => fader.participantId === 'plugin.presession').availability, 'pending');
|
||||
@@ -175,7 +175,7 @@ test('audio-mix keeps pre-session participants pending then attaches them on ses
|
||||
|
||||
test('audio-mix registration is idempotent and song switching keeps known participants without stale route', async () => {
|
||||
const window = loadAudioSession();
|
||||
const audioSession = window.slopsmith.audioSession;
|
||||
const audioSession = window.feedBack.audioSession;
|
||||
audioSession.startSession({ sessionId: 'main:first-song', songKey: 'first-song' });
|
||||
audioSession.setRoute({ routeKind: 'stems', availability: 'available' });
|
||||
|
||||
@@ -189,11 +189,11 @@ test('audio-mix registration is idempotent and song switching keeps known partic
|
||||
operations: ['fader.get-value', 'fader.set-value'],
|
||||
});
|
||||
}
|
||||
const beforeStop = await window.slopsmith.capabilities.dispatch({ capability: 'audio-mix', command: 'list-faders', source: 'test' });
|
||||
const beforeStop = await window.feedBack.capabilities.dispatch({ capability: 'audio-mix', command: 'list-faders', source: 'test' });
|
||||
audioSession.stopSession('song switch');
|
||||
const stopped = audioSession.snapshot();
|
||||
audioSession.startSession({ sessionId: 'main:second-song', songKey: 'second-song' });
|
||||
const afterStart = await window.slopsmith.capabilities.dispatch({ capability: 'audio-mix', command: 'list-faders', source: 'test' });
|
||||
const afterStart = await window.feedBack.capabilities.dispatch({ capability: 'audio-mix', command: 'list-faders', source: 'test' });
|
||||
|
||||
assert.equal(beforeStop.payload.faders.filter(fader => fader.participantId === 'plugin.rehydrated').length, 1);
|
||||
assert.equal(stopped.domains['audio-mix'].route.availability, 'unavailable');
|
||||
@@ -207,7 +207,7 @@ test('re-registering a mix participant without handlers preserves the existing s
|
||||
// wiped the fader.set-value handler installed at init — the mixer slider
|
||||
// then moved visually but never applied the volume (archive and sloppak).
|
||||
const window = loadAudioSession();
|
||||
const audioSession = window.slopsmith.audioSession;
|
||||
const audioSession = window.feedBack.audioSession;
|
||||
audioSession.startSession({ sessionId: 'main:test-song', songKey: 'test-song', songFormat: 'sloppak' });
|
||||
|
||||
const applied = [];
|
||||
|
||||
Reference in New Issue
Block a user