mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-11 19:29:33 +00:00
rename: slopsmith → feedBack, byron → got-feedBack (#537)
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bret Mogilefsky
co-authored by
Claude Opus 4.8
byrongamatos
Claude Opus 4.8
byrongamatos
parent
a8ad02739a
commit
af2949677a
@@ -26,7 +26,7 @@ test('legacy fader API remains compatible while bridge hits are attributed', asy
|
||||
runBrowserScript(window, 'static/audio-mixer.js');
|
||||
|
||||
let volume = 0.5;
|
||||
window.slopsmith.audio.registerFader({
|
||||
window.feedBack.audio.registerFader({
|
||||
id: 'plugin.delay',
|
||||
label: 'Delay',
|
||||
min: 0,
|
||||
@@ -37,8 +37,8 @@ test('legacy fader API remains compatible while bridge hits are attributed', asy
|
||||
setValue: value => { volume = value; },
|
||||
});
|
||||
|
||||
const snapshot = window.slopsmith.audioSession.snapshot();
|
||||
assert.equal(window.slopsmith.audio.getFaders().some(fader => fader.id === 'plugin.delay'), true);
|
||||
const snapshot = window.feedBack.audioSession.snapshot();
|
||||
assert.equal(window.feedBack.audio.getFaders().some(fader => fader.id === 'plugin.delay'), true);
|
||||
assert.equal(snapshot.domains['audio-mix'].participants.some(participant => participant.participantId === 'fader.plugin.delay'), true);
|
||||
assert.equal(snapshot.domains['audio-mix'].bridges.some(bridge => bridge.bridgeId === 'audio-mix.fader-registry'), true);
|
||||
});
|
||||
@@ -48,9 +48,9 @@ test('legacy analyser fallback records bridge status without losing analyser out
|
||||
installAnalyserDom(window);
|
||||
runBrowserScript(window, 'plugins/highway_3d/screen.js');
|
||||
|
||||
const analyser = window.slopsmithViz_highway_3d.__test.getAnalyserForBridgeTest();
|
||||
const bands = window.slopsmithViz_highway_3d.__test.readBandsForBridgeTest();
|
||||
const bridge = window.slopsmith.audioSession.snapshot().domains['audio-mix'].bridges.find(entry => entry.bridgeId === 'audio-mix.analyser');
|
||||
const analyser = window.feedBackViz_highway_3d.__test.getAnalyserForBridgeTest();
|
||||
const bands = window.feedBackViz_highway_3d.__test.readBandsForBridgeTest();
|
||||
const bridge = window.feedBack.audioSession.snapshot().domains['audio-mix'].bridges.find(entry => entry.bridgeId === 'audio-mix.analyser');
|
||||
|
||||
assert.equal(analyser.source, 'core');
|
||||
assert.equal(bands.bass > 0, true);
|
||||
@@ -59,9 +59,9 @@ test('legacy analyser fallback records bridge status without losing analyser out
|
||||
|
||||
test('barrier and input compatibility surfaces are visible in diagnostics', () => {
|
||||
const window = loadAudioSession();
|
||||
const audioSession = window.slopsmith.audioSession;
|
||||
const audioSession = window.feedBack.audioSession;
|
||||
|
||||
audioSession.recordBridgeHit({ domain: 'audio-monitoring', bridgeId: 'audio-monitoring.audio-barrier', legacySurface: 'window.slopsmithAudioBarrier', participantId: 'note_detect', outcome: 'degraded', reason: 'timeout' });
|
||||
audioSession.recordBridgeHit({ domain: 'audio-monitoring', bridgeId: 'audio-monitoring.audio-barrier', legacySurface: 'window.feedBackAudioBarrier', participantId: 'note_detect', outcome: 'degraded', reason: 'timeout' });
|
||||
audioSession.recordBridgeHit({ domain: 'audio-input', bridgeId: 'audio-input.legacy-source', legacySurface: 'navigator.mediaDevices.getUserMedia', participantId: 'note_detect', outcome: 'denied', reason: 'permission denied' });
|
||||
|
||||
const snapshot = audioSession.snapshot();
|
||||
@@ -71,7 +71,7 @@ test('barrier and input compatibility surfaces are visible in diagnostics', () =
|
||||
|
||||
test('a legacy bridge hit with unsafe fields never leaks a path/token into diagnostics', () => {
|
||||
const window = loadAudioSession();
|
||||
const audioSession = window.slopsmith.audioSession;
|
||||
const audioSession = window.feedBack.audioSession;
|
||||
|
||||
audioSession.recordBridgeHit({
|
||||
domain: 'audio-input',
|
||||
@@ -91,7 +91,7 @@ test('a legacy bridge hit with unsafe fields never leaks a path/token into diagn
|
||||
|
||||
test('audio-input explicit enumeration registers provider sources without list prompting', async () => {
|
||||
const window = loadAudioSession();
|
||||
const api = window.slopsmith.capabilities;
|
||||
const api = window.feedBack.capabilities;
|
||||
const provider = makeInputProvider({
|
||||
providerId: 'desktop_audio',
|
||||
sourceId: 'bootstrap-source',
|
||||
@@ -106,7 +106,7 @@ test('audio-input explicit enumeration registers provider sources without list p
|
||||
assert.equal(listed.payload.sources.some(source => source.logicalSourceKey === 'desktop:instrument:secondary'), false);
|
||||
assert.deepEqual(provider.calls, []);
|
||||
|
||||
const enumerated = await window.slopsmith.audioSession.enumerateInputSources({ providerId: 'desktop_audio', explicit: true, requesterId: 'settings' });
|
||||
const enumerated = await window.feedBack.audioSession.enumerateInputSources({ providerId: 'desktop_audio', explicit: true, requesterId: 'settings' });
|
||||
const after = await api.dispatch({ capability: 'audio-input', command: 'list-sources', source: 'test' });
|
||||
|
||||
assert.equal(enumerated.outcome, 'handled');
|
||||
@@ -117,7 +117,7 @@ test('audio-input explicit enumeration registers provider sources without list p
|
||||
|
||||
test('audio-input native source wins over compatibility-backed duplicate', async () => {
|
||||
const window = loadAudioSession();
|
||||
const api = window.slopsmith.capabilities;
|
||||
const api = window.feedBack.capabilities;
|
||||
|
||||
await api.dispatch({
|
||||
capability: 'audio-input',
|
||||
@@ -150,7 +150,7 @@ test('audio-input native source wins over compatibility-backed duplicate', async
|
||||
});
|
||||
|
||||
const listed = await api.dispatch({ capability: 'audio-input', command: 'list-sources', source: 'test' });
|
||||
const snapshot = window.slopsmith.audioSession.snapshot().domains['audio-input'];
|
||||
const snapshot = window.feedBack.audioSession.snapshot().domains['audio-input'];
|
||||
|
||||
assert.equal(listed.payload.sources.length, 1);
|
||||
assert.equal(listed.payload.sources[0].providerId, 'native_input');
|
||||
@@ -160,7 +160,7 @@ test('audio-input native source wins over compatibility-backed duplicate', async
|
||||
|
||||
test('audio-monitoring native provider wins over legacy compatibility provider and overshadows its compatibility bridge', async () => {
|
||||
const window = loadAudioSession();
|
||||
const api = window.slopsmith.capabilities;
|
||||
const api = window.feedBack.capabilities;
|
||||
const legacy = makeMonitoringProvider({
|
||||
providerId: 'legacy_monitor',
|
||||
logicalMonitoringKey: 'shared:monitor:primary',
|
||||
@@ -177,7 +177,7 @@ test('audio-monitoring native provider wins over legacy compatibility provider a
|
||||
await api.dispatch({ capability: 'audio-monitoring', command: 'register-provider', source: 'native_monitor', payload: native.provider });
|
||||
|
||||
const listed = await api.dispatch({ capability: 'audio-monitoring', command: 'list-providers', source: 'test' });
|
||||
const snapshot = window.slopsmith.audioSession.snapshot().domains['audio-monitoring'];
|
||||
const snapshot = window.feedBack.audioSession.snapshot().domains['audio-monitoring'];
|
||||
|
||||
// The compatibility bridge below is the one the registration/supersession path actually produces;
|
||||
// asserting only on it (not on manually pre-seeded bridge hits) keeps this test honest if the
|
||||
@@ -192,10 +192,10 @@ test('legacy registerFader callbacks are usable through audio-mix get and set op
|
||||
const window = loadAudioSession();
|
||||
installMixerDom(window);
|
||||
runBrowserScript(window, 'static/audio-mixer.js');
|
||||
window.slopsmith.audioSession.startSession({ sessionId: 'main:test-song' });
|
||||
window.feedBack.audioSession.startSession({ sessionId: 'main:test-song' });
|
||||
|
||||
let gain = 0.35;
|
||||
window.slopsmith.audio.registerFader({
|
||||
window.feedBack.audio.registerFader({
|
||||
id: 'plugin.gain',
|
||||
label: 'Plugin Gain',
|
||||
min: 0,
|
||||
@@ -206,7 +206,7 @@ test('legacy registerFader callbacks are usable through audio-mix get and set op
|
||||
setValue: value => { gain = Math.min(0.9, value); return gain; },
|
||||
});
|
||||
|
||||
const api = window.slopsmith.capabilities;
|
||||
const api = window.feedBack.capabilities;
|
||||
const listed = await api.dispatch({ capability: 'audio-mix', command: 'list-faders', source: 'test' });
|
||||
const read = await api.dispatch({ capability: 'audio-mix', command: 'get-fader-value', source: 'test', payload: { participantId: 'fader.plugin.gain', faderId: 'plugin.gain' } });
|
||||
const written = await api.dispatch({ capability: 'audio-mix', command: 'set-fader-value', source: 'test', payload: { participantId: 'fader.plugin.gain', faderId: 'plugin.gain', value: 1 } });
|
||||
@@ -216,7 +216,7 @@ test('legacy registerFader callbacks are usable through audio-mix get and set op
|
||||
assert.equal(written.payload.committedValue, 0.9);
|
||||
assert.equal(gain, 0.9);
|
||||
|
||||
window.slopsmith.audio.unregisterFader('plugin.gain');
|
||||
assert.equal(window.slopsmith.audio.getFaders().some(fader => fader.id === 'plugin.gain'), false);
|
||||
assert.equal(window.slopsmith.audioSession.snapshot().domains['audio-mix'].participants.some(participant => participant.participantId === 'fader.plugin.gain'), false);
|
||||
window.feedBack.audio.unregisterFader('plugin.gain');
|
||||
assert.equal(window.feedBack.audio.getFaders().some(fader => fader.id === 'plugin.gain'), false);
|
||||
assert.equal(window.feedBack.audioSession.snapshot().domains['audio-mix'].participants.some(participant => participant.participantId === 'fader.plugin.gain'), false);
|
||||
});
|
||||
Reference in New Issue
Block a user